CSR-2276 restructure the external parm checking for isinsurance to properly check the experimet thresholds

CSR-2276 restructure the external parm checking for isinsurance to properly check the experimet thresholds
This commit is contained in:
CarlNation 2024-10-25 13:30:24 -04:00
parent 3f3038bf18
commit df99b06743
3 changed files with 31 additions and 18 deletions

View file

@ -351,16 +351,21 @@ export default {
); );
const isExternalParameter = store.getters.externalParameterState?.isExternalParameter; const isExternalParameter = store.getters.externalParameterState?.isExternalParameter;
if ( // prettier-ignore
isExternalParameter === externalParameterStatus.NOT_SET || {
isExternalParameter === externalParameterStatus.INACTIVE const log = getQuerystringParameter(queryStrings.LOG);
) { if (eval(log)) {
// there are no active or inactive external parameters; use internal threshold console.log("------------- quote.vue thresholds start -----------------");
if (isExternalParameter === externalParameterStatus.INACTIVE) { console.log(new Date() + " isExternalParameter: " + isExternalParameter);
if (internalThreshold) thresholdToUse = externalThreshold; console.log(new Date() + " internalThreshold: " + internalThreshold);
} else { console.log(new Date() + " externalThreshold: " + externalThreshold);
if (internalThreshold) thresholdToUse = internalThreshold; console.log("------------- quote.vue thresholds end -----------------");
} }
}
if (isExternalParameter === externalParameterStatus.NOT_SET) {
// there are no active or inactive external parameters; use internal threshold
if (internalThreshold) thresholdToUse = internalThreshold;
vm.isInsuranceSelected = getIsInsuranceSelectedValue( vm.isInsuranceSelected = getIsInsuranceSelectedValue(
vm.availableLineItems, vm.availableLineItems,
@ -368,20 +373,23 @@ export default {
); );
baseMixin.methods.ResetExternalParamsAndHideModal(); baseMixin.methods.ResetExternalParamsAndHideModal();
} else { } else {
// user came from an external source // user came from an external source, however, the externalParms may have been reset on service-zip, property-questions, etc...
if (store.getters.externalParameterQuote?.isInsurance == true) { if (eval(store.getters.externalParameterQuote?.isInsurance)) {
// did user intentionally select insurance? // did user intentionally select insurance?
vm.isInsuranceSelected = true; vm.isInsuranceSelected = true;
vm.servicePackage = store.getters.externalParameterQuote.servicePackage; vm.servicePackage = store.getters.externalParameterQuote.servicePackage;
await nextTick(); await nextTick();
const isValid = await baseMixin.methods.isFormValid(vm.$refs.theForm);
if (isValid) { if (vm.servicePackage != null && isExternalParameter === externalParameterStatus.ACTIVE) {
vm.forwardButtonAction(); const isValid = await baseMixin.methods.isFormValid(vm.$refs.theForm);
} else { if (isValid) {
baseMixin.methods.ResetExternalParamsAndHideModal(); baseMixin.methods.ResetExternalParamsAndHideModal();
vm.forwardButtonAction();
}
} }
baseMixin.methods.ResetExternalParamsAndHideModal();
} else { } else {
thresholdToUse = externalThreshold; if (externalThreshold) thresholdToUse = externalThreshold;
vm.isInsuranceSelected = getIsInsuranceSelectedValue( vm.isInsuranceSelected = getIsInsuranceSelectedValue(
vm.availableLineItems, vm.availableLineItems,

View file

@ -669,6 +669,12 @@ function updateExternalParameterState() {
if (externalParameterZipCode) { if (externalParameterZipCode) {
store.commit(storeMutations.UPDATE_EXTERNAL_PARAMETER_ZIP_CODE, externalParameterZipCode); store.commit(storeMutations.UPDATE_EXTERNAL_PARAMETER_ZIP_CODE, externalParameterZipCode);
} }
if (externalParameterEmail) {
store.commit(
storeMutations.UPDATE_EXTERNAL_PARAMETER_EMAIL_ADDRESS,
externalParameterEmail
);
}
if (externalParameterIsInsurance?.toUpperCase() == "TRUE") { if (externalParameterIsInsurance?.toUpperCase() == "TRUE") {
store.commit(storeMutations.UPDATE_EXTERNAL_PARAMETER_IS_INSURANCE, true); store.commit(storeMutations.UPDATE_EXTERNAL_PARAMETER_IS_INSURANCE, true);
store.commit( store.commit(

View file

@ -505,7 +505,6 @@ export const mutations = {
saveExternalParameterState(externalParameterState); saveExternalParameterState(externalParameterState);
}, },
resetExternalParameterQuoteState(state) { resetExternalParameterQuoteState(state) {
externalParameterState.quote.isInsurance = null;
externalParameterState.quote.servicePackage = null; externalParameterState.quote.servicePackage = null;
saveExternalParameterState(externalParameterState); saveExternalParameterState(externalParameterState);
}, },