jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

CSR-120: update unit tests, remove setTimeouts

Browse source
This commit is contained in:
Adam Caouette 2021-11-29 17:22:19 -05:00
parent 314df2d116
commit df92be576d
2 changed files with 17 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
src/common-components/vehicle-banner/vehicle-banner.spec.js
View file

@ -2,6 +2,7 @@ import { shallowMount } from '@vue/test-utils';
import vehicleBanner from './vehicle-banner'; import vehicleBanner from './vehicle-banner';
import { getMountOptions } from "@/helpers/unit-test-helper.js"; import { getMountOptions } from "@/helpers/unit-test-helper.js";
import { storeActions } from "@/constants/store-actions"; import { storeActions } from "@/constants/store-actions";
import { nextTick } from 'vue';
describe('vehicleBanner', () => { describe('vehicleBanner', () => {
const $store = { const $store = {
@ -44,7 +45,7 @@ describe('vehicleBanner', () => {
] ]
}; };
test('renders the blurrycar image when vehicleImageSrc is not present', async () => { test('renders the blurrycar image when vehicleImageSrc is not present', () => {
// Arrange // Arrange
const mountOptions = getMountOptions(actionList); const mountOptions = getMountOptions(actionList);
mountOptions.global.mocks = { mountOptions.global.mocks = {
@ -60,7 +61,7 @@ describe('vehicleBanner', () => {
wrapper.unmount(); wrapper.unmount();
}); });
test('does not render the blurrycar image when vehicleImageSrc exists', async () => { test('does not render the blurrycar image when vehicleImageSrc exists', () => {
// Arrange // Arrange
const mountOptions = getMountOptions(actionList); const mountOptions = getMountOptions(actionList);
mountOptions.global.mocks = { mountOptions.global.mocks = {
@ -77,9 +78,7 @@ describe('vehicleBanner', () => {
} }
}); });
// Assert // Assert
setTimeout(() => { expect(wrapper.find('img').attributes('class')).not.toContain('blurrycar');
expect(wrapper.find('img').attributes('class')).not.toContain('blurrycar');
}, 500);
wrapper.unmount(); wrapper.unmount();
}); });
@ -98,13 +97,12 @@ describe('vehicleBanner', () => {
} }
}); });
// Assert // Assert
setTimeout(() => { await nextTick();
expect(wrapper.find('img').attributes('class')).not.toContain('blurrycar'); expect(wrapper.find('img').attributes('class')).not.toContain('blurrycar');
}, 500);
wrapper.unmount(); wrapper.unmount();
}); });
test('does not render the blurrycar image when a YMMS object is found', async () => { test('receives a carId when a YMMS object is found', async () => {
// Arrange // Arrange
$store.state.order.vehicle.year = "2019" $store.state.order.vehicle.year = "2019"
$store.state.order.vehicle.make = "acura" $store.state.order.vehicle.make = "acura"
@ -120,14 +118,12 @@ describe('vehicleBanner', () => {
...mountOptions ...mountOptions
}); });
// Assert // Assert
setTimeout(() => { await nextTick();
expect(wrapper.find('img').attributes('class')).not.toContain('blurrycar'); expect(wrapper.vm.$data.carId.length).toBeGreaterThan(0);
}, 500);
wrapper.unmount(); wrapper.unmount();
}); });
test('does not render the blurrycar image when a VIN is found', async () => { test('receives a carId when a VIN is found', async () => {
// Arrange // Arrange
$store.state.order.vehicle.vin = "1J4GW58S4XC541166"; $store.state.order.vehicle.vin = "1J4GW58S4XC541166";
const mountOptions = getMountOptions(actionList); const mountOptions = getMountOptions(actionList);
@ -140,9 +136,9 @@ describe('vehicleBanner', () => {
...mountOptions ...mountOptions
}); });
// Assert // Assert
setTimeout(() => { await nextTick();
expect(wrapper.find('img').attributes('class')).not.toContain('blurrycar'); expect(wrapper.vm.$data.carId.length).toBeGreaterThan(0);
}, 500);
wrapper.unmount(); wrapper.unmount();
}); });
}); });

8
src/common-components/vehicle-banner/vehicle-banner.vue
View file

@ -53,14 +53,14 @@ export default {
methods: { methods: {
getCarIdWithYmms(ymms) { // retrieve carId with YMMS object getCarIdWithYmms(ymms) { // retrieve carId with YMMS object
this.dispatchNonBlockingStoreAction(this.storeActions.LOOKUP_VEHICLE_BY_YMMS, ymms).then((response) => { this.dispatchNonBlockingStoreAction(this.storeActions.LOOKUP_VEHICLE_BY_YMMS, ymms).then((response) => {
const carId = response.data[0].CarId; this.carId = response.data[0].CarId;
this.getVehicleImage(carId) this.getVehicleImage(this.carId)
}); });
}, },
getCarIdWithVin(vin) { // retrieve carId with VIN string getCarIdWithVin(vin) { // retrieve carId with VIN string
this.dispatchNonBlockingStoreAction(this.storeActions.LOOKUP_VEHICLE_BY_VIN, vin).then((response) => { this.dispatchNonBlockingStoreAction(this.storeActions.LOOKUP_VEHICLE_BY_VIN, vin).then((response) => {
const carId = response.data[0].CarId; this.carId = response.data[0].CarId;
this.getVehicleImage(carId) this.getVehicleImage(this.carId)
}); });
}, },
getVehicleImage(carId) { // look up evox with carId getVehicleImage(carId) { // look up evox with carId