Merge pull request #109 from Safelite/brm-back-button-update

Update back button to remove text as link.
This commit is contained in:
bmauger 2021-12-21 14:16:47 -05:00 committed by GitHub
commit dcfd404abe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 26 deletions

View file

@ -14,19 +14,4 @@ describe("FunnelSubHeader.vue", () => {
expect(wrapper.find("h2").text()).toContain("FunnelSubHeader Content"); expect(wrapper.find("h2").text()).toContain("FunnelSubHeader Content");
wrapper.unmount(); wrapper.unmount();
}); });
it("Should render the button inside of header if backButtonAction provided", () => {
// Act
const testFn = () => {}
const wrapper = shallowMount(FunnelSubHeader, {
propsData: {
text: "FunnelSubHeader Content",
hasBackButton: true,
backButtonAction: testFn,
},
});
// Assert
expect(wrapper.find("h2").find("button").text()).toContain("FunnelSubHeader Content");
wrapper.unmount();
});
}); });

View file

@ -2,18 +2,16 @@
<div class="current_car_info-text"> <div class="current_car_info-text">
<div class="d-flex align-items-center justify-content-center"> <div class="d-flex align-items-center justify-content-center">
<h2 class="text-center fs-5 d-block fw-normal mb-0"> <h2 class="text-center fs-5 d-block fw-normal mb-0">
<button v-if="hasBackButton && backButtonAction" @click="backButtonAction"> <p class="m-0" v-if="hasBackButton">
{{ text }} {{ text }}
</button> </p>
<span v-else> <span v-else>
{{ text }} {{ text }}
</span> </span>
</h2> </h2>
<buttonBack <buttonBack
v-if="hasBackButton" v-if="hasBackButton"
:backButtonAccessibleText="backButtonAccessibleText"
:backButtonAction="backButtonAction" :backButtonAction="backButtonAction"
:backButtonUrl="backButtonUrl"
/> />
</div> </div>
</div> </div>
@ -48,6 +46,6 @@ export default {
} }
} }
.back-button-wrapper { .back-button-wrapper {
margin-left: .25rem; margin-left: 0;
} }
</style> </style>

View file

@ -39,7 +39,7 @@
</div> </div>
<div class="row"> <div class="row">
<div class="col my-3 d-flex align-items-center"> <div class="col my-3 d-flex align-items-center">
<buttonBack <buttonBack
backButtonUrl="#" backButtonUrl="#"
backButtonAccessibleText="Back button label" backButtonAccessibleText="Back button label"
/> />
@ -618,7 +618,6 @@ export default {
alert, alert,
vehicleBanner, vehicleBanner,
listButtonHorizontal, listButtonHorizontal,
siteHeader,
checkbox, checkbox,
funnelHeader, funnelHeader,
}, },

View file

@ -1,8 +1,8 @@
<template> <template>
<button <button
v-if="backButtonAction" v-if="backButtonAction"
@click="backButtonAction" @click="backButtonAction"
class="back-button-wrapper d-flex p-0" class="back-button-wrapper d-flex p-3"
:aria-label="backButtonAccessibleText" :aria-label="backButtonAccessibleText"
> >
<div class="button-back"> <div class="button-back">