From 87820950aeece2a875cab94e777c832d43bc9bd5 Mon Sep 17 00:00:00 2001 From: Katie Date: Tue, 29 Mar 2022 11:58:54 -0400 Subject: [PATCH 1/2] CSR-98 Remove commented code --- src/helpers/heritage-integration/navigation-helper.js | 2 -- src/helpers/heritage-integration/order-helper.js | 1 - src/helpers/heritage-integration/order-helper.spec.js | 3 +-- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/helpers/heritage-integration/navigation-helper.js b/src/helpers/heritage-integration/navigation-helper.js index 0aad13e50..20a4315bf 100644 --- a/src/helpers/heritage-integration/navigation-helper.js +++ b/src/helpers/heritage-integration/navigation-helper.js @@ -60,8 +60,6 @@ export async function getPageToRouteExistingOrderTo(toRoute = {}, existingHerita export async function navigateToHeritageFunnel() { // Create the order (or save existing order) when navigating to Heritage Funnel. - // console.log(exports) - // await self.saveOrder(); await saveOrder(); router.navigateToExternalUrl( diff --git a/src/helpers/heritage-integration/order-helper.js b/src/helpers/heritage-integration/order-helper.js index 8d8fe01d4..cf8a45d16 100644 --- a/src/helpers/heritage-integration/order-helper.js +++ b/src/helpers/heritage-integration/order-helper.js @@ -10,7 +10,6 @@ import baseMixin from "@/mixins/base-mixin"; */ export async function loadOrderIfPresent() { console.log("attempting to load referral...."); - // const conceptCookie = self.getConceptCookie(); const conceptCookie = getConceptCookie(); console.log(conceptCookie) diff --git a/src/helpers/heritage-integration/order-helper.spec.js b/src/helpers/heritage-integration/order-helper.spec.js index 37eb48687..473e6c842 100644 --- a/src/helpers/heritage-integration/order-helper.spec.js +++ b/src/helpers/heritage-integration/order-helper.spec.js @@ -48,7 +48,6 @@ describe("loadOrderIfPresent", () => { expect(mocks.baseMixin.methods.dispatchNonBlockingStoreAction).toHaveBeenCalledWith(storeActions.RESET_STATE); cookieHelper.getConceptCookie.mockRestore(); - // store.dispatch.mockRestore(); }); test("Concept cookie is null => store is unchanged", () => { @@ -144,7 +143,7 @@ describe("saveOrder", () => { // Act await saveOrder(); - + // Assert expect(cookieHelper.getConceptCookie().DidHeritageFunnelUpdateLast).toEqual(false); }); From 9f49aafb7b8752379cc881d62acbfd9de40d4437 Mon Sep 17 00:00:00 2001 From: Katie Date: Tue, 29 Mar 2022 12:09:28 -0400 Subject: [PATCH 2/2] CSR-98 Remove mockRestore() --- src/helpers/heritage-integration/order-helper.spec.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/helpers/heritage-integration/order-helper.spec.js b/src/helpers/heritage-integration/order-helper.spec.js index 4a24c0573..fd0507bbb 100644 --- a/src/helpers/heritage-integration/order-helper.spec.js +++ b/src/helpers/heritage-integration/order-helper.spec.js @@ -46,8 +46,6 @@ describe("loadOrderIfPresent", () => { // Assert expect(cookieHelper.getConceptCookie).toHaveBeenCalled(); expect(mocks.baseMixin.methods.dispatchNonBlockingStoreAction).toHaveBeenCalledWith(storeActions.RESET_STATE); - - cookieHelper.getConceptCookie.mockRestore(); }); test("Concept cookie is null => store is unchanged", () => {