diff --git a/jest.config.js b/jest.config.js index dae094119..b387a0e5d 100644 --- a/jest.config.js +++ b/jest.config.js @@ -13,6 +13,8 @@ module.exports = { "!src/helpers/unit-test-helper.js", "!src/layouts/component-test/component-test.vue", "!src/layouts/form-test/form-test.vue", + "!src/layouts/license-plate-lookup/license-plate-lookup.vue", + "!src/layouts/vin-lookup/vin-lookup.vue", "!src/layouts/vehicle-damage/windshield-damage-type-question/windshield-damage-type-question.vue", "!src/layouts/vehicle-damage/windshield-options/windshield-options.vue", "!src/layouts/address-poc/address-poc.vue", @@ -29,7 +31,8 @@ module.exports = { testMatch: ["**/*.spec.(js|jsx|ts|tsx)|**/__tests__/*.(js|jsx|ts|tsx)"], coverageThreshold: { global: { - statements: 89, + statements: 87, + // Got the go ahead from Mark to temporarily lower this. Taking out initialize component made the year,make,model and style coverage drop a bit. Once unit tests for license plate lookup, vin lookup and address lookup are in the coverage should go back up to 90 }, }, }; diff --git a/src/common-components/button-question/button-question.vue b/src/common-components/button-question/button-question.vue index b46d933c0..79937c780 100644 --- a/src/common-components/button-question/button-question.vue +++ b/src/common-components/button-question/button-question.vue @@ -160,6 +160,7 @@ export default { .overflow-scroll { // Height will be determined by overall height of content above list height: calc(100% - 300px); + overflow-x: hidden !important; -webkit-overflow-scrolling: touch; } } diff --git a/src/common-components/funnel-footer/funnel-footer.spec.js b/src/common-components/funnel-footer/funnel-footer.spec.js index 6b2bd8335..30dc14fd3 100644 --- a/src/common-components/funnel-footer/funnel-footer.spec.js +++ b/src/common-components/funnel-footer/funnel-footer.spec.js @@ -16,8 +16,8 @@ describe("funnel-footer.vue", () => { }); const wrapper = mount(funnelFooter, { + mixins: [mockMixin] }); - wrapper.vm.initializeComponent(cmsContent); // Assert const link = wrapper.find("a"); @@ -30,6 +30,7 @@ describe("funnel-footer.vue", () => { it("Should emit ForwardClicked on button click", async () => { // Act const wrapper = mount(funnelFooter, { + mixins: [mockMixin] }); wrapper.vm.buttonClick(); // Assert @@ -39,16 +40,28 @@ describe("funnel-footer.vue", () => { it("Should emit BackClicked on link click", async () => { // Act const wrapper = mount(funnelFooter, { + mixins: [mockMixin] }); wrapper.vm.linkClick(); // Assert expect(wrapper.emitted()["BackClicked"][0]).toHaveBeenCalled; }); + it("Should change button text when update button text is called", async () => { + // Act + const wrapper = mount(funnelFooter, { + mixins: [mockMixin] + }); + wrapper.vm.updateButtonText('newText'); + + // Assert + expect(wrapper.componentVM.customButtontext).toBe('newText'); + }); + }); -//Mock CMS content -const cmsContent = { - backLink: "text", - buttonText: "text", -}; +const mockMixin = { + methods: { + getCmsContent: jest.fn() + } +} \ No newline at end of file diff --git a/src/common-components/funnel-footer/funnel-footer.vue b/src/common-components/funnel-footer/funnel-footer.vue index cb83ecae1..cea6b403e 100644 --- a/src/common-components/funnel-footer/funnel-footer.vue +++ b/src/common-components/funnel-footer/funnel-footer.vue @@ -18,6 +18,7 @@
.container-fluid { + overflow-x: visible; // needed to fix hidden footer on some iphones + } } diff --git a/src/common-components/funnel-header/funnel-header.spec.js b/src/common-components/funnel-header/funnel-header.spec.js index ed60d5f73..a9b9535aa 100644 --- a/src/common-components/funnel-header/funnel-header.spec.js +++ b/src/common-components/funnel-header/funnel-header.spec.js @@ -10,8 +10,8 @@ describe("funnelHeader", () => { setData: { imageSrc: "image_url", }, + mixins: [mockMixin] }); - wrapper.vm.initializeComponent(cmsContent); // Assert expect(wrapper.find("img")).toBeTruthy(); @@ -19,7 +19,8 @@ describe("funnelHeader", () => { }); }); -//Mock CMS content -const cmsContent = { - imageSrc: "image_url", -}; +const mockMixin = { + methods: { + getCmsContent: jest.fn() + } +} diff --git a/src/common-components/funnel-header/funnel-header.vue b/src/common-components/funnel-header/funnel-header.vue index 3266b88a9..97c67bd40 100644 --- a/src/common-components/funnel-header/funnel-header.vue +++ b/src/common-components/funnel-header/funnel-header.vue @@ -24,7 +24,6 @@ export default { name: "funnel-header", data() { return { - imageSrc: "", displayGlobalAlert: false, globalAlertMessage: { isDismissible: false, @@ -34,10 +33,13 @@ export default { }, }; }, - methods: { - initializeComponent(cmsContent) { - this.imageSrc = cmsContent.LogoImage; - }, + props: { + cmsWidgetName: String, + }, + computed: { + imageSrc(){ + return this.getCmsContent(this.cmsWidgetName, 'LogoImage'); + } }, components: { alert, diff --git a/src/common-components/funnel-sub-header/funnel-sub-header.spec.js b/src/common-components/funnel-sub-header/funnel-sub-header.spec.js index 5a48d126d..ebcb9ca91 100644 --- a/src/common-components/funnel-sub-header/funnel-sub-header.spec.js +++ b/src/common-components/funnel-sub-header/funnel-sub-header.spec.js @@ -4,19 +4,18 @@ import FunnelSubHeader from "./funnel-sub-header"; describe("FunnelSubHeader.vue", () => { it("Should render the 'text' data value as a span value for the header span text value.", async () => { // Act - const wrapper = shallowMount(FunnelSubHeader); - await wrapper.setData({ - text: "FunnelSubHeader Content", + const wrapper = shallowMount(FunnelSubHeader, { + mixins: [mockMixin] }); - //wrapper.vm.initializeComponent(cmsContent); + wrapper.vm.clickEvent(); // Assert - expect(wrapper.find("h5").text()).toContain("FunnelSubHeader Content"); - wrapper.unmount(); + expect(wrapper.emitted()).toEqual({"click-event": [[]]}); }); }); -//Mock CMS content -const cmsContent = { - HeaderText: "FunnelSubHeader Content", -}; +const mockMixin = { + methods: { + getCmsContent: jest.fn() + } +} diff --git a/src/common-components/funnel-sub-header/funnel-sub-header.vue b/src/common-components/funnel-sub-header/funnel-sub-header.vue index db10885f7..f8ac3134a 100644 --- a/src/common-components/funnel-sub-header/funnel-sub-header.vue +++ b/src/common-components/funnel-sub-header/funnel-sub-header.vue @@ -1,7 +1,7 @@