From d6102ca1bc0e18662728b038577322a61f9d2343 Mon Sep 17 00:00:00 2001 From: Mark Harris Date: Wed, 15 Jun 2022 15:17:25 -0400 Subject: [PATCH] treat ancillary parts different than glass parts --- src/constants/store-mutations.js | 4 ++-- src/layouts/part-questions/part-questions.vue | 2 +- src/layouts/reveal/reveal.vue | 2 +- src/layouts/vehicle-parts/vehicle-parts.vue | 2 +- src/mixins/vin-pages-mixin.js | 2 +- src/mixins/vin-pages-mixin.spec.js | 2 +- src/store/index.js | 11 +++++------ src/store/store.spec.js | 10 +++++----- 8 files changed, 17 insertions(+), 18 deletions(-) diff --git a/src/constants/store-mutations.js b/src/constants/store-mutations.js index e8349ef40..1924b0063 100644 --- a/src/constants/store-mutations.js +++ b/src/constants/store-mutations.js @@ -14,7 +14,7 @@ const storeMutations = { UPDATE_IS_REPAIR: "updateIsRepair", UPDATE_NUMBER_OF_CHIPS: "updateNumberOfChips", UPDATE_GLASS_TO_REPLACE: "updateGlassToReplace", - UPDATE_PARTS: "updateParts", + UPDATE_GLASS_PARTS: "updateGlassParts", UPDATE_REGISTRATION_LICENSE_PLATE : "updateRegistrationLicensePlate", UPDATE_REGISTRATION_ADDRESS: "updateRegistrationAddress", UPDATE_REGISTRATION_CITY: "updateRegistrationCity", @@ -40,7 +40,7 @@ const storeMutations = { RESET_VEHICLE_STATE: "resetVehicleState", RESET_DAMAGE_STATE: "resetDamageState", RESET_REGISTRATION_STATE: "resetRegistrationState", - RESET_PARTS_STATE: "resetPartsState", + RESET_GLASS_PARTS_STATE: "resetGlassPartsState", RESET_STATE: "resetState", // OTHER MUTATIONS diff --git a/src/layouts/part-questions/part-questions.vue b/src/layouts/part-questions/part-questions.vue index 36a7d6465..af202feed 100644 --- a/src/layouts/part-questions/part-questions.vue +++ b/src/layouts/part-questions/part-questions.vue @@ -67,7 +67,7 @@ export default { }, resetDependentState() { // Set - store.commit(storeMutations.UPDATE_PARTS, null); + store.commit(storeMutations.UPDATE_GLASS_PARTS, null); // Invokes store.dispatch(storeActions.RESET_PARTS_AND_DEPS); diff --git a/src/layouts/reveal/reveal.vue b/src/layouts/reveal/reveal.vue index 200fec263..7ca9d903f 100644 --- a/src/layouts/reveal/reveal.vue +++ b/src/layouts/reveal/reveal.vue @@ -50,7 +50,7 @@ export default { }, resetDependentState() { // Set - store.commit(storeMutations.UPDATE_PARTS, null); + store.commit(storeMutations.UPDATE_GLASS_PARTS, null); // Invokes store.dispatch(storeActions.RESET_PARTS_AND_DEPS); diff --git a/src/layouts/vehicle-parts/vehicle-parts.vue b/src/layouts/vehicle-parts/vehicle-parts.vue index d876f132f..24b0b5033 100644 --- a/src/layouts/vehicle-parts/vehicle-parts.vue +++ b/src/layouts/vehicle-parts/vehicle-parts.vue @@ -177,7 +177,7 @@ export default { } // Save parts to the store. - store.commit(storeMutations.UPDATE_PARTS, matchedParts); + store.commit(storeMutations.UPDATE_GLASS_PARTS, matchedParts); // Navigate to the next page. this.$router.navigateAfterSave( diff --git a/src/mixins/vin-pages-mixin.js b/src/mixins/vin-pages-mixin.js index 8f33fdf92..383bcf237 100644 --- a/src/mixins/vin-pages-mixin.js +++ b/src/mixins/vin-pages-mixin.js @@ -19,7 +19,7 @@ export default { this.$router.navigateAfterSave(this.navigationScenarios.SELECTED_VIN_WITH_MULTIPLE_PARTS, this.$route, {}, {}, result.data); } else { - store.commit(storeMutations.UPDATE_PARTS, result.data); + store.commit(storeMutations.UPDATE_GLASS_PARTS, result.data); this.$refs.loadingModal.showModal(); navigateAfterSaveToHeritageFunnel(this.$route); } diff --git a/src/mixins/vin-pages-mixin.spec.js b/src/mixins/vin-pages-mixin.spec.js index 747b62793..aef929d52 100644 --- a/src/mixins/vin-pages-mixin.spec.js +++ b/src/mixins/vin-pages-mixin.spec.js @@ -872,7 +872,7 @@ describe("vin-pages-mixin", () => { // Assert expect(store.commit).toHaveBeenCalledTimes(1); - expect(store.commit).toHaveBeenCalledWith(storeMutations.UPDATE_PARTS, { partsOrQuestions }) + expect(store.commit).toHaveBeenCalledWith(storeMutations.UPDATE_GLASS_PARTS, { partsOrQuestions }) expect(wrapper.vm.$refs.loadingModal.showModal).toHaveBeenCalledTimes(1); expect(navigateAfterSaveToHeritageFunnel).toHaveBeenCalledTimes(1); }); diff --git a/src/store/index.js b/src/store/index.js index c3e54d27b..5730adf53 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -111,7 +111,7 @@ export const mutations = { updateGlassToReplace(state, glassToReplace) { state.order.damage.glassToReplace = glassToReplace; }, - updateParts(state, partsData) { + updateGlassParts(state, partsData) { state.order.lineItems.glassParts = partsData; }, updatePageData(state, pageData) { @@ -212,9 +212,8 @@ export const mutations = { state.order.vehicle.registration.firstName = null; state.order.vehicle.registration.lastName = null; }, - resetPartsState(state) { + resetGlassPartsState(state) { state.order.lineItems.glassParts = null; - state.order.lineItems.otherParts = null; }, resetState(state) { Object.assign(state, getDefaultState()); @@ -400,14 +399,14 @@ export const actions = { }, resetDamageAndDependencies(context) { context.commit(storeMutations.RESET_DAMAGE_STATE); - context.commit(storeMutations.RESET_PARTS_STATE); + context.commit(storeMutations.RESET_GLASS_PARTS_STATE); }, resetRegistrationAndDependencies(context) { context.commit(storeMutations.RESET_REGISTRATION_STATE); - context.commit(storeMutations.RESET_PARTS_STATE) + context.commit(storeMutations.RESET_GLASS_PARTS_STATE) }, resetPartsAndDependencies(context) { - context.commit(storeMutations.RESET_PARTS_STATE); + context.commit(storeMutations.RESET_GLASS_PARTS_STATE); }, resetState(context) { context.commit(storeMutations.RESET_STATE); diff --git a/src/store/store.spec.js b/src/store/store.spec.js index bdb49ece7..c70629296 100644 --- a/src/store/store.spec.js +++ b/src/store/store.spec.js @@ -183,7 +183,7 @@ describe("Mutations", () => { const storeState = state; // Act - mutations.updateParts(storeState, { 'Windshield-Single': 'PARTNUM101'}); + mutations.updateGlassParts(storeState, { 'Windshield-Single': 'PARTNUM101'}); // Assert expect(storeState.order.lineItems.glassParts).toEqual({ 'Windshield-Single': 'PARTNUM101'}); @@ -446,7 +446,7 @@ describe("Actions", () => { await actions.resetDamageAndDependencies(context) expect(commit).toBeCalledWith(storeMutations.RESET_DAMAGE_STATE); - expect(commit).toBeCalledWith(storeMutations.RESET_PARTS_STATE); + expect(commit).toBeCalledWith(storeMutations.RESET_GLASS_PARTS_STATE); }); @@ -462,7 +462,7 @@ describe("Actions", () => { await actions.resetRegistrationAndDependencies(context) expect(commit).toBeCalledWith(storeMutations.RESET_REGISTRATION_STATE); - expect(commit).toBeCalledWith(storeMutations.RESET_PARTS_STATE); + expect(commit).toBeCalledWith(storeMutations.RESET_GLASS_PARTS_STATE); }); @@ -477,7 +477,7 @@ describe("Actions", () => { // Act await actions.resetPartsAndDependencies(context) - expect(commit).toBeCalledWith(storeMutations.RESET_PARTS_STATE); + expect(commit).toBeCalledWith(storeMutations.RESET_GLASS_PARTS_STATE); }); @@ -747,7 +747,7 @@ describe("Getters", () => { const storeState = state; // Act - mutations.updateParts(storeState, {"Rear-Stationary": 'PART101'}); + mutations.updateGlassParts(storeState, {"Rear-Stationary": 'PART101'}); // Assert expect(getters.lineItems(storeState).glassParts).toEqual({"Rear-Stationary": 'PART101'});