CSR-762 Fix keyboard navigation

This commit is contained in:
Katie 2022-09-20 11:23:59 -04:00
parent f7ab4ab503
commit ccab154426

View file

@ -2,6 +2,7 @@
<label <label
:class="[buttonWrapperClasses, { 'has-error': errors.length > 0 }]" :class="[buttonWrapperClasses, { 'has-error': errors.length > 0 }]"
:for="buttonId" :for="buttonId"
@mousedown.left="handleEventAction('click', $event)"
> >
selectOnKeypress: {{ selectOnKeypress }} selectOnKeypress: {{ selectOnKeypress }}
<!-- classes: {{classes}}<br/> <!-- classes: {{classes}}<br/>
@ -102,56 +103,58 @@ export default {
hasFirstEventFired: this.hasFirstEventFired, hasFirstEventFired: this.hasFirstEventFired,
}); });
// switch (eventType) {
// case eventTypes.CLICK:
// case eventTypes.KEYPRESS_SUBMIT:
// console.log("clicking");
// this.hasFirstEventFired = true;
// this.handleClick(e);
// break;
// case eventTypes.CHANGE:
// console.log("selectOnKeypress: ", this.selectOnKeypress);
// this.hasFirstEventFired = false;
// this.selectOnKeypress
// ? this.handleClick(e)
// : this.handleSelectionChange(e);
// break;
// }
if (this.isMultiSelect) {
// if (true) {
switch (eventType) { switch (eventType) {
case eventTypes.CLICK: // case eventTypes.CLICK:
case eventTypes.KEYPRESS_SUBMIT: case eventTypes.KEYPRESS_SUBMIT:
console.log("clicking"); console.log("clicking");
this.hasFirstEventFired = true; // this.hasFirstEventFired = true;
this.handleClick(e); this.handleClick(e);
break; break;
case eventTypes.CHANGE: case eventTypes.CHANGE:
console.log("selectOnKeypress: ", this.selectOnKeypress); console.log("selectOnKeypress: ", this.selectOnKeypress);
this.hasFirstEventFired = false; // this.hasFirstEventFired = false;
this.selectOnKeypress this.selectOnKeypress
? this.handleClick(e) ? this.handleClick(e)
: this.handleSelectionChange(e); : this.handleSelectionChange(e);
break; break;
} }
} else {
switch (eventType) {
case eventTypes.CLICK:
case eventTypes.KEYPRESS_SUBMIT:
console.log("clicking");
// if (this.isMultiSelect) { // TODO KO may still need this since GA events, wouldn't want to trigger twice
// // if (true) {
// switch (eventType) {
// case eventTypes.CLICK:
// case eventTypes.KEYPRESS_SUBMIT:
// console.log("clicking");
// this.hasFirstEventFired = true; // this.hasFirstEventFired = true;
// this.handleClick(e); this.handleClick(e);
// break; break;
// case eventTypes.CHANGE: case eventTypes.CHANGE:
// console.log("selectOnKeypress: ", this.selectOnKeypress); console.log("selectOnKeypress: ", this.selectOnKeypress);
// this.hasFirstEventFired = false; // this.hasFirstEventFired = false;
// this.selectOnKeypress this.selectOnKeypress
// ? this.handleClick(e) ? this.handleClick(e)
// : this.handleSelectionChange(e); : this.handleSelectionChange(e);
// break; break;
// } }
// } else { }
// switch (eventType) {
// case eventTypes.CLICK:
// case eventTypes.KEYPRESS_SUBMIT:
// console.log("clicking");
// this.hasFirstEventFired = true;
// this.handleClick(e);
// break;
// case eventTypes.CHANGE:
// console.log("selectOnKeypress: ", this.selectOnKeypress);
// this.hasFirstEventFired = false;
// this.selectOnKeypress
// ? this.handleClick(e)
// : this.handleSelectionChange(e);
// break;
// }
// }
// if (!this.hasFirstEventFired) { // if (!this.hasFirstEventFired) {