From 8baa213004a25daca7f17992a4746ad84a939302 Mon Sep 17 00:00:00 2001 From: Scott Kiener Date: Mon, 28 Oct 2024 15:49:45 -0400 Subject: [PATCH 1/2] CSR-2266 | Get bill-to earlier in flow --- src/layouts/address-lookup/address-lookup.vue | 1 + .../license-plate-lookup/license-plate-lookup.vue | 1 + src/layouts/service-zip/service-zip.vue | 1 + src/layouts/vin-lookup/vin-lookup.vue | 3 ++- src/mixins/vin-pages-mixin.js | 14 ++++++++++++++ src/store/index.js | 6 ++---- 6 files changed, 21 insertions(+), 5 deletions(-) diff --git a/src/layouts/address-lookup/address-lookup.vue b/src/layouts/address-lookup/address-lookup.vue index 403982a83..6ac7a3d9a 100644 --- a/src/layouts/address-lookup/address-lookup.vue +++ b/src/layouts/address-lookup/address-lookup.vue @@ -375,6 +375,7 @@ export default { }, false ); + await this.getAndSaveBillToAccountNumber(); return await this.navigateForward(carsFound); }, diff --git a/src/layouts/license-plate-lookup/license-plate-lookup.vue b/src/layouts/license-plate-lookup/license-plate-lookup.vue index 308180d20..2f82691ce 100644 --- a/src/layouts/license-plate-lookup/license-plate-lookup.vue +++ b/src/layouts/license-plate-lookup/license-plate-lookup.vue @@ -323,6 +323,7 @@ export default { false ); + await this.getAndSaveBillToAccountNumber(); return await this.navigateForward(); }, lookupVin(plate, state) { diff --git a/src/layouts/service-zip/service-zip.vue b/src/layouts/service-zip/service-zip.vue index ddcc4edf0..25045af0a 100644 --- a/src/layouts/service-zip/service-zip.vue +++ b/src/layouts/service-zip/service-zip.vue @@ -198,6 +198,7 @@ export default { }, false ); + await this.getAndSaveBillToAccountNumber(); if (!zipCodeData.isValid) { this.displayInvalidZipAlert = true; diff --git a/src/layouts/vin-lookup/vin-lookup.vue b/src/layouts/vin-lookup/vin-lookup.vue index b63158680..b8253c456 100644 --- a/src/layouts/vin-lookup/vin-lookup.vue +++ b/src/layouts/vin-lookup/vin-lookup.vue @@ -345,7 +345,8 @@ export default { }, false ); - + + await this.getAndSaveBillToAccountNumber(); return await this.navigateForward(); } diff --git a/src/mixins/vin-pages-mixin.js b/src/mixins/vin-pages-mixin.js index 75054f776..7d15066c5 100644 --- a/src/mixins/vin-pages-mixin.js +++ b/src/mixins/vin-pages-mixin.js @@ -42,5 +42,19 @@ export default { }; return vinLookupMethods[vinSelection] || null; }, + async getAndSaveBillToAccountNumber() { + const pageName = this.$options?.name; + const billToAccountNumber = await this.dispatchStoreActionWithLogging( + storeActions.GET_BILL_TO_ACCOUNT_NUMBER, + {}, + pageName, + false + ); + await this.dispatchStoreAction( + this.storeActions.SAVE_BILL_TO_ACCOUNT_NUMBER, + billToAccountNumber, + false + ); + }, }, }; diff --git a/src/store/index.js b/src/store/index.js index 14b9ff7f9..b132311c7 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -2804,10 +2804,8 @@ export const actions = { pageNameToLog, } ) { - // Cash orders default to 87291 - update if/when more detailed - // billToAccountNumbers are needed for cash - if (parentAccountNumber == applicationConfig.CASH_PARENT_ACCOUNT_NUMBER) { - return applicationConfig.CASH_DEFAULT_BILL_TO_ACCOUNT_NUMBER; + if (!parentAccountNumber) { + parentAccountNumber = applicationConfig.CASH_PARENT_ACCOUNT_NUMBER; } const queryString = `ParentAccountNumber=${parentAccountNumber}` + From 5c2876d6a40c9b457df28981aa3b36c5d7cb79ae Mon Sep 17 00:00:00 2001 From: Scott Kiener Date: Mon, 28 Oct 2024 15:56:45 -0400 Subject: [PATCH 2/2] CSR-2266 | Unit Tests & formatting --- src/layouts/service-zip/service-zip.spec.js | 1 + src/layouts/vin-lookup/vin-lookup.vue | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/layouts/service-zip/service-zip.spec.js b/src/layouts/service-zip/service-zip.spec.js index 1a22bb03b..214fd96f0 100644 --- a/src/layouts/service-zip/service-zip.spec.js +++ b/src/layouts/service-zip/service-zip.spec.js @@ -485,6 +485,7 @@ function setupMocks({ customMountOptions, customZipQuery, customZipDataResponse }), setCmsContent: jest.fn(), navigateForwardWithSingleCarMatch: jest.fn(), + getAndSaveBillToAccountNumber: jest.fn(), getZipCodeData: jest.fn().mockImplementation(() => { if (customZipDataResponse) { return customZipDataResponse; diff --git a/src/layouts/vin-lookup/vin-lookup.vue b/src/layouts/vin-lookup/vin-lookup.vue index b8253c456..6bac87c19 100644 --- a/src/layouts/vin-lookup/vin-lookup.vue +++ b/src/layouts/vin-lookup/vin-lookup.vue @@ -345,7 +345,7 @@ export default { }, false ); - + await this.getAndSaveBillToAccountNumber(); return await this.navigateForward(); }