jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1752 from Safelite/feature/skiener/CSR-1975

Browse source 
CSR-1975 | Wiper promo bug on Quote fix
This commit is contained in:
scottkiener 2024-02-14 10:21:51 -05:00 committed by GitHub
commit c47274f38e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/layouts/quote/quote.vue
View file

@ -43,7 +43,6 @@
class="small mt-4"
v-model="lineItems"
:availableVaps="availableVaps"
:availableLineItems="availableLineItems"
pageName="quote"
:taxPromos="false"
modalWidgetName="PromoModalWidget" />

3
src/store/index.js
View file

@ -2310,6 +2310,9 @@ export const actions = {
) {
const order = context.getters.order;
lineItemsToUse = lineItemsToUse ?? order.lineItems;
addGuidToLineItemsIfNotAlreadyThere(lineItemsToUse.vaps);
syncLineItemIds(addableVaps, lineItemsToUse.vaps);
// addableVaps still won't have IDs if they weren't already in lineItemsToUse
addGuidToLineItemsIfNotAlreadyThere(addableVaps);
const requestObject = {
promoCode: promoCode,

10
src/store/store.spec.js
View file

@ -2933,7 +2933,7 @@ describe("Actions", () => {
// Arrange
const context = state;
const promoCode = "testPromo";
const lineItemsToUse = { vaps: [1], promos: [2] };
const lineItemsToUse = { vaps: [{ partNumber: 1 }], promos: [2] };
const addableVaps = [{ partNumber: "addableVap" }];
context["getters"] = {
@ -3013,7 +3013,7 @@ describe("Actions", () => {
},
referralSequenceNumber: "test",
lineItems: {
vaps: [1],
vaps: [{ partNumber: 1 }],
promos: [2],
serverData: "test",
},
@ -3026,7 +3026,7 @@ describe("Actions", () => {
crypto.randomUUID = jest.fn(() => "GUID");
const expectedLineItemsOnOrder = [1, 2];
const expectedLineItemsOnOrder = [{ partNumber: 1, id: "GUID" }, 2];
// Act
actions.validateOrderPromoAndSaveServerData(context, {
@ -3073,7 +3073,7 @@ describe("Actions", () => {
},
referralSequenceNumber: "test",
lineItems: {
vaps: [1],
vaps: [{ partNumber: 1 }],
promos: [2],
serverData: "test",
},
@ -3131,7 +3131,7 @@ describe("Actions", () => {
},
referralSequenceNumber: "test",
lineItems: {
vaps: [1],
vaps: [{ partNumber: 1 }],
promos: [2],
serverData: "test",
},