CSR-1452 | Multiple bug fixes
additionalButtonData was used incorrectly 404's from validatePromo were handled incorrectly
This commit is contained in:
parent
dfd8413312
commit
c21d50c3ba
4 changed files with 7 additions and 6 deletions
|
|
@ -133,7 +133,6 @@ export default {
|
||||||
suppressError: Boolean,
|
suppressError: Boolean,
|
||||||
useTextForValue: Boolean,
|
useTextForValue: Boolean,
|
||||||
valueToLogType: String,
|
valueToLogType: String,
|
||||||
additionalButtonData: Object,
|
|
||||||
isSmallQuestionText: Boolean,
|
isSmallQuestionText: Boolean,
|
||||||
customButtonQuestionId: String,
|
customButtonQuestionId: String,
|
||||||
logDisplayedValuesEvent: {
|
logDisplayedValuesEvent: {
|
||||||
|
|
@ -256,7 +255,7 @@ export default {
|
||||||
buttonFooterCopy: answer.buttonFooterCopy ?? answer.buttonFooterCopy,
|
buttonFooterCopy: answer.buttonFooterCopy ?? answer.buttonFooterCopy,
|
||||||
buttonImage: answer.buttonImage ?? answer.AnswerImageUrl,
|
buttonImage: answer.buttonImage ?? answer.AnswerImageUrl,
|
||||||
buttonImageId: answer.buttonImageId ?? answer.ImageId,
|
buttonImageId: answer.buttonImageId ?? answer.ImageId,
|
||||||
additionalButtonData: answer.additionalButtonData ?? answer.additionalButtonData,
|
additionalButtonData: answer.additionalButtonData,
|
||||||
groupName: this.formatString(this.groupName),
|
groupName: this.formatString(this.groupName),
|
||||||
value:
|
value:
|
||||||
answer.value ??
|
answer.value ??
|
||||||
|
|
|
||||||
|
|
@ -37,8 +37,7 @@
|
||||||
v-model="selectedWipers"
|
v-model="selectedWipers"
|
||||||
isMultiSelect
|
isMultiSelect
|
||||||
isRequired
|
isRequired
|
||||||
validationRules="checkbox-required"
|
validationRules="checkbox-required" />
|
||||||
:additionalButtonData="additionalButtonData" />
|
|
||||||
</div>
|
</div>
|
||||||
<div v-else-if="wipersOffered === wipersOfferedStrings.FRONT" class="wiper-options">
|
<div v-else-if="wipersOffered === wipersOfferedStrings.FRONT" class="wiper-options">
|
||||||
<p class="price">+${{ wipersModal.totalFrontPrice }}</p>
|
<p class="price">+${{ wipersModal.totalFrontPrice }}</p>
|
||||||
|
|
|
||||||
|
|
@ -19,8 +19,7 @@
|
||||||
textPosition="text-start"
|
textPosition="text-start"
|
||||||
v-model="selectedProviderNumber"
|
v-model="selectedProviderNumber"
|
||||||
isRequired
|
isRequired
|
||||||
validationRules="option-required"
|
validationRules="option-required" />
|
||||||
:additionalButtonData="additionalButtonData" />
|
|
||||||
<textLink
|
<textLink
|
||||||
v-if="displaySeeMoreLocationsLink"
|
v-if="displaySeeMoreLocationsLink"
|
||||||
ref="showMoreShopsLink"
|
ref="showMoreShopsLink"
|
||||||
|
|
@ -156,6 +155,7 @@ export default {
|
||||||
buttonLabel: city,
|
buttonLabel: city,
|
||||||
buttonLabelSubCopy: `${distanceInMiles} mi`,
|
buttonLabelSubCopy: `${distanceInMiles} mi`,
|
||||||
buttonBodyCopy: `${streetAddress}, ${city}, ${state} ${zipCode}`,
|
buttonBodyCopy: `${streetAddress}, ${city}, ${state} ${zipCode}`,
|
||||||
|
additionalButtonData: this.additionalButtonData,
|
||||||
value: shopProvider.providerNumber,
|
value: shopProvider.providerNumber,
|
||||||
};
|
};
|
||||||
});
|
});
|
||||||
|
|
|
||||||
|
|
@ -2273,6 +2273,9 @@ export const actions = {
|
||||||
payload: requestObject,
|
payload: requestObject,
|
||||||
logApiCall: true,
|
logApiCall: true,
|
||||||
pageNameToLog: pageNameToLog,
|
pageNameToLog: pageNameToLog,
|
||||||
|
}).catch((error) => {
|
||||||
|
// Validate promo will return 4xx errors when an invalid promo
|
||||||
|
return error;
|
||||||
});
|
});
|
||||||
|
|
||||||
if (validateResponse?.data?.serverData) {
|
if (validateResponse?.data?.serverData) {
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue