From c18af60165c0ef85c396287c57c7dc942e085f39 Mon Sep 17 00:00:00 2001 From: Scott Kiener Date: Tue, 26 Jul 2022 12:07:03 -0400 Subject: [PATCH] CSR-706 | Refactoring savedQuote -> SavedSession --- src/constants/store-mutations.js | 2 +- src/helpers/heritage-integration/cookie-helper.js | 2 +- .../heritage-integration/navigation-helper.spec.js | 8 ++++---- src/helpers/heritage-integration/order-helper.js | 2 +- .../heritage-integration/order-helper.spec.js | 10 +++++----- src/helpers/heritage-integration/session-helper.js | 2 +- .../heritage-integration/session-helper.spec.js | 4 ++-- src/helpers/unit-test-helper.js | 4 ++-- src/store/index.js | 12 ++++++------ 9 files changed, 23 insertions(+), 23 deletions(-) diff --git a/src/constants/store-mutations.js b/src/constants/store-mutations.js index 66b9ded0e..508f59bf7 100644 --- a/src/constants/store-mutations.js +++ b/src/constants/store-mutations.js @@ -39,7 +39,7 @@ const storeMutations = { UPDATE_REFERRAL_DATE: "updateReferralDate", UPDATE_REFERRAL_CORRELATION_ID: "updateReferralCorrelationId", UPDATE_PARENT_ACCT_NUMBER: "updateParentAcctNumber", - UPDATE_SAVE_QUOTE_ID: "updateSaveQuoteId", + UPDATE_SAVED_SESSION_ID: "updateSavedSessionId", UPDATE_CRM_CUSTOMER_ID: "updateCrmCustomerId", // EVENT BUS MUTATIONS diff --git a/src/helpers/heritage-integration/cookie-helper.js b/src/helpers/heritage-integration/cookie-helper.js index 3a8614661..775a64fec 100644 --- a/src/helpers/heritage-integration/cookie-helper.js +++ b/src/helpers/heritage-integration/cookie-helper.js @@ -15,7 +15,7 @@ export function updateOrCreateFunnelCookie() { // Set up cookie with all the props. setFunnelCookieProperties({ LastTouched: new Date().toUTCString(), - SavedQuoteTimeoutDate: store.getters.applicationUser.savedSessionTimeout, + SavedSessionTimeoutDate: store.getters.applicationUser.savedSessionTimeout, DidHeritageFunnelUpdateLast: false, ShouldResetState: false, ReferralNumber: store.getters.order.referralNumber, diff --git a/src/helpers/heritage-integration/navigation-helper.spec.js b/src/helpers/heritage-integration/navigation-helper.spec.js index 7337bf98e..0e615aef5 100644 --- a/src/helpers/heritage-integration/navigation-helper.spec.js +++ b/src/helpers/heritage-integration/navigation-helper.spec.js @@ -309,10 +309,10 @@ describe("navigateToHeritageFunnel", () => { const mockCorrelationId = "55"; const mockReferralDate = "2022"; const mockAccountNumber = "167132"; - const mockavedSessionId = "xxx-xxx-xxx"; + const mockSavedSessionId = "xxx-xxx-xxx"; const mockCrmCustomerId = "xxx-xxx-xxx" - const mockOrderInfo = getMockOrderInfo(mockReferralNumber, mockCorrelationId, mockReferralDate, mockAccountNumber, mockSaveQuoteId, mockCrmCustomerId); + const mockOrderInfo = getMockOrderInfo(mockReferralNumber, mockCorrelationId, mockReferralDate, mockAccountNumber, mockSavedSessionId, mockCrmCustomerId); const mockData = { actionList: [{ @@ -344,10 +344,10 @@ describe("navigateToHeritageFunnel", () => { const mockCorrelationId = "55"; const mockReferralDate = "2022"; const mockAccountNumber = "167132"; - const mockSaveQuoteId = "xxx-xxx-xxx"; + const mockSavedSessionId = "xxx-xxx-xxx"; const mockCrmCustomerId = "xxx-xxx-xxx" - const mockOrderInfo = getMockOrderInfo(mockReferralNumber, mockCorrelationId, mockReferralDate, mockAccountNumber, mockSaveQuoteId, mockCrmCustomerId); + const mockOrderInfo = getMockOrderInfo(mockReferralNumber, mockCorrelationId, mockReferralDate, mockAccountNumber, mockSavedSessionId, mockCrmCustomerId); const mockData = { actionList: [{ diff --git a/src/helpers/heritage-integration/order-helper.js b/src/helpers/heritage-integration/order-helper.js index 2e6fcade0..870ee190b 100644 --- a/src/helpers/heritage-integration/order-helper.js +++ b/src/helpers/heritage-integration/order-helper.js @@ -84,7 +84,7 @@ async function saveOrderHelper() { referralCorrelationId: savedOrderInfo.data.referralCorrelationId, referralDate: savedOrderInfo.data.referralDate, accountNumber: savedOrderInfo.data.accountNumber.toString(), - saveQuoteId: savedOrderInfo.data.saveQuoteId, + savedSessionId: savedOrderInfo.data.savedSessionId, crmCustomerId: savedOrderInfo.data.crmCustomerId.toString(), }, false); diff --git a/src/helpers/heritage-integration/order-helper.spec.js b/src/helpers/heritage-integration/order-helper.spec.js index c3a581e41..400ab46e4 100644 --- a/src/helpers/heritage-integration/order-helper.spec.js +++ b/src/helpers/heritage-integration/order-helper.spec.js @@ -112,10 +112,10 @@ describe("saveOrder", () => { const mockCorrelationId = "55"; const mockReferralDate = "2022"; const mockAccountNumber = "167132"; - const mockSaveQuoteId = "xxx-xxx-xxx"; + const mockSavedSessionId = "xxx-xxx-xxx"; const mockCrmCustomerId = "xxx-xxx-xxx" - const mockOrderInfo = getMockOrderInfo(mockReferralNumber, mockCorrelationId, mockReferralDate, mockAccountNumber, mockSaveQuoteId, mockCrmCustomerId); + const mockOrderInfo = getMockOrderInfo(mockReferralNumber, mockCorrelationId, mockReferralDate, mockAccountNumber, mockSavedSessionId, mockCrmCustomerId); const mockData = { actionList: [ @@ -141,7 +141,7 @@ describe("saveOrder", () => { referralDate: mockReferralDate, referralCorrelationId: mockCorrelationId, accountNumber: mockAccountNumber, - saveQuoteId: mockSaveQuoteId, + savedSessionId: mockSavedSessionId, crmCustomerId: mockCrmCustomerId, }, false); }); @@ -152,10 +152,10 @@ describe("saveOrder", () => { const mockReferralDate = "2022-03-15T10:56:24.597"; const mockReferralCorrelationId = "404d2b04-f86e-45c3-b373-127b6217b060"; const mockAccountNumber = "167132"; - const mockSaveQuoteId = "xxx-xxx-xxx"; + const mockSavedSessionId = "xxx-xxx-xxx"; const mockCrmCustomerId = "xxx-xxx-xxx" - const mockOrderInfo = getMockOrderInfo(mockReferralNumber, mockReferralCorrelationId, mockReferralDate, mockAccountNumber, mockSaveQuoteId, mockCrmCustomerId); + const mockOrderInfo = getMockOrderInfo(mockReferralNumber, mockReferralCorrelationId, mockReferralDate, mockAccountNumber, mockSavedSessionId, mockCrmCustomerId); const mockData = { actionList: [{ diff --git a/src/helpers/heritage-integration/session-helper.js b/src/helpers/heritage-integration/session-helper.js index ba816cdb1..ca50a4e7b 100644 --- a/src/helpers/heritage-integration/session-helper.js +++ b/src/helpers/heritage-integration/session-helper.js @@ -28,7 +28,7 @@ export function isAnalyticsSessionStillActive() { */ export function isSavedSessionStillActive() { if (getFunnelCookie() !== null) { - const savedSessionTimeStamp = new Date(getFunnelCookie().SavedQuoteTimeoutDate); + const savedSessionTimeStamp = new Date(getFunnelCookie().SavedSessionTimeoutDate); const isSavedSessionTimedOut = (new Date(new Date().toUTCString()) > savedSessionTimeStamp); if (isSavedSessionTimedOut) { diff --git a/src/helpers/heritage-integration/session-helper.spec.js b/src/helpers/heritage-integration/session-helper.spec.js index 8a17743d1..b41827bf7 100644 --- a/src/helpers/heritage-integration/session-helper.spec.js +++ b/src/helpers/heritage-integration/session-helper.spec.js @@ -41,7 +41,7 @@ describe("isSavedSessionStillActive", () => { mockDate.setDate(mockDate.getDate() + 1); cookieHelper.getFunnelCookie = jest.spyOn(cookieHelper, "getFunnelCookie") - .mockReturnValue({ SavedQuoteTimeoutDate: mockDate }); + .mockReturnValue({ SavedSessionTimeoutDate: mockDate }); // Act const result = isSavedSessionStillActive(); @@ -56,7 +56,7 @@ describe("isSavedSessionStillActive", () => { mockDate.setDate(mockDate.getDate() - 1) cookieHelper.getFunnelCookie = jest.spyOn(cookieHelper, "getFunnelCookie") - .mockReturnValue({ SavedQuoteTimeoutDate: mockDate }); + .mockReturnValue({ SavedSessionTimeoutDate: mockDate }); // Act const result = isSavedSessionStillActive(); diff --git a/src/helpers/unit-test-helper.js b/src/helpers/unit-test-helper.js index 36745d28a..13436be78 100644 --- a/src/helpers/unit-test-helper.js +++ b/src/helpers/unit-test-helper.js @@ -90,13 +90,13 @@ export function removeAllTestCookies() { }); } -export function getMockOrderInfo(mockReferralNumber, mockCorrelationId, mockReferralDate, accountNumber = "0", saveQuoteId, crmCustomerId) { +export function getMockOrderInfo(mockReferralNumber, mockCorrelationId, mockReferralDate, accountNumber = "0", savedSessionId, crmCustomerId) { return { referralNumber: mockReferralNumber, referralCorrelationId: mockCorrelationId, referralDate: mockReferralDate, accountNumber: accountNumber, - saveQuoteId: saveQuoteId, + savedSessionId: savedSessionId, crmCustomerId: crmCustomerId, } } diff --git a/src/store/index.js b/src/store/index.js index 64ba356e6..2c507a123 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -66,7 +66,7 @@ const getDefaultState = () => { pageData: {}, savedSessionTimeout: getDateForSavedSessionTimeout(), saveOrderPromise: null, - saveQuoteId: null, + savedSessionId: null, crmCustomerId: null, lastPageVisited: null, experiments: [] @@ -209,8 +209,8 @@ export const mutations = { updateSaveOrderPromise(state, saveOrderPromise){ state.applicationUser.saveOrderPromise = saveOrderPromise; }, - updateSaveQuoteId(state, saveQuoteId) { - state.applicationUser.saveQuoteId = saveQuoteId; + updateSavedSessionId(state, savedSessionId) { + state.applicationUser.savedSessionId = savedSessionId; }, updateCrmCustomerId(state, crmCustomerId) { state.applicationUser.crmCustomerId = crmCustomerId; @@ -502,12 +502,12 @@ export const actions = { }, // Misc Actions - updateStoreWithSaveOrderResponse(context, { referralNumber, referralDate, referralCorrelationId, accountNumber, saveQuoteId, crmCustomerId }) { + updateStoreWithSaveOrderResponse(context, { referralNumber, referralDate, referralCorrelationId, accountNumber, savedSessionId, crmCustomerId }) { context.commit(storeMutations.UPDATE_REFERRAL_NUMBER, referralNumber); context.commit(storeMutations.UPDATE_REFERRAL_DATE, referralDate); context.commit(storeMutations.UPDATE_REFERRAL_CORRELATION_ID, referralCorrelationId); context.commit(storeMutations.UPDATE_PARENT_ACCT_NUMBER, accountNumber); - context.commit(storeMutations.UPDATE_SAVE_QUOTE_ID, saveQuoteId); + context.commit(storeMutations.UPDATE_SAVED_SESSION_ID, savedSessionId); context.commit(storeMutations.UPDATE_CRM_CUSTOMER_ID, crmCustomerId); }, @@ -690,7 +690,7 @@ export const actions = { existingPromoCode: null, lastPage: applicationUser.lastPageVisited, crmCustomerId: applicationUser.crmCustomerId, - saveQuoteId: applicationUser.saveQuoteId, + savedSessionId: applicationUser.savedSessionId, }, });