CSR-480: clean up some faulty logic I discovered that was only clearing answers if multi-select

src/common-components/button-question/button-question.spec.js

@@ -112,7 +112,8 @@ describe("buttonQuestion.vue", () => {
     const wrapper = shallowMount(buttonQuestion, setupMocks({}));
     await wrapper.setProps({
       answers: ["2022", "2021", "2020"],
-      isMultiSelect: false
+      isMultiSelect: false,
+      modelValue: []
     });
     const val = { checkValue: true, value: "2021", }
     wrapper.vm.handleCheckedChanged(val);

src/common-components/button-question/button-question.vue

@@ -133,17 +133,14 @@ export default {
       return answer.Name ? answer.Name : answer;
     },
     handleCheckedChanged(val) {
-
+      if(this.selectingInitiatesLoad) {
-      if(this.isMultiSelect && this.selectedValues) {
+        this.selectedValues = [val.value];
-        // Add or remove item to array of data to emit
+      } else {
-        const newSelectedValues = this.selectedValues;
-
         if(Array.isArray(this.selectedValues)) {
+          const newSelectedValues = this.selectedValues;
           val.checkValue ? newSelectedValues.push(val.value) : newSelectedValues.splice(newSelectedValues.indexOf(val.value), 1);
           this.selectedValues = newSelectedValues;
         }
-      } else {
-        this.selectedValues = [val.value];
       }
     },
   },

src/ux-components/list-button-horizontal/list-button-horizontal.vue

@@ -92,7 +92,7 @@ export default {
         : this.selectedValues[0];
     }
   },
-  unmounted() { // needed to clear this button's selectedValues if it is removed
+  unmounted() { // needed to clear this button's selectedValues if it is removed to keep validation in sync
     this.checkValue = false;
     this.handleCheckChange();
   },

src/ux-components/list-button/list-button.vue

@@ -92,7 +92,7 @@ export default {
         : this.selectedValues[0];
     }
   },
-  unmounted() { // needed to clear this button's selectedValues if it is removed
+  unmounted() { // needed to clear this button's selectedValues if it is removed to keep validation in sync
     this.checkValue = false;
     this.handleCheckChange();
   },

src/ux-components/list-card/list-card.vue

@@ -99,7 +99,7 @@ export default {
         : this.selectedValues[0];
     }
   },
-  unmounted() { // needed to clear this button's selectedValues if it is removed
+  unmounted() { // needed to clear this button's selectedValues if it is removed to keep validation in sync
     this.checkValue = false;
     this.handleCheckChange();
   },