readability changes

This commit is contained in:
Frank 2021-11-30 15:11:57 -05:00
parent 6bafa88c28
commit becd4b9e93
2 changed files with 16 additions and 12 deletions

View file

@ -16,12 +16,12 @@ describe("vehicle-year.vue", () => {
// Our mock data for our call to settleAllPromises
const mockData = {
pageContentPromise: {
getPageContent: {
PageHeaderWidget: [{ HeaderText: "Select a year to get started" }],
RadioQuestionWidget: [{ QuestionText: "What year is your vehicle?" }],
isCmsContentReady: true,
},
vehicleYearsPromise: [2023, 2022, 2021]
getVehicleYear: [2023, 2022, 2021]
}
// our router information needed.

View file

@ -27,25 +27,29 @@ export default {
computed: {},
beforeRouteEnter(to, from, next) {
const layoutPromiseTable = [
const contentPromise = fetchCmsContentForPage(to.query.fmgPage);
const getVehicleYearPromise = store.dispatch(storeActions.GET_VEHICLE_YEARS, {});
const promiseResultMap = [
{
key: "pageContentPromise",
promise: fetchCmsContentForPage(to.query.fmgPage),
resultKey: "getPageContent",
promise: contentPromise,
},
{
key: "vehicleYearsPromise",
promise: store.dispatch(storeActions.GET_VEHICLE_YEARS, {}),
resultKey: "getVehicleYear",
promise: getVehicleYearPromise,
},
];
settleAllPromises(layoutPromiseTable).then((resultMap) => {
settleAllPromises(promiseResultMap).then((resultMap) => {
// Call our next function to transition to the next page.
next((vm) => {
vm.pageHeaderWidgets = resultMap.pageContentPromise.PageHeaderWidget[0];
vm.radioQuestionWidgets = resultMap.pageContentPromise.RadioQuestionWidget[0];
vm.vehicleYears = resultMap.vehicleYearsPromise;
vm.pageHeaderWidgets = resultMap.getPageContent.PageHeaderWidget[0];
vm.radioQuestionWidgets = resultMap.getPageContent.RadioQuestionWidget[0];
vm.vehicleYears = resultMap.getVehicleYear;
});
});
},