From 66b79e7409d207dd4ebe76fe03e0213f6a7c9f8f Mon Sep 17 00:00:00 2001 From: Max Date: Wed, 23 Feb 2022 14:40:39 -0500 Subject: [PATCH 01/22] updating style --- src/styles/common-error-styles.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/styles/common-error-styles.scss b/src/styles/common-error-styles.scss index b5017fc60..2c26e69d7 100644 --- a/src/styles/common-error-styles.scss +++ b/src/styles/common-error-styles.scss @@ -1,7 +1,7 @@ .has-error { &.list-button, &.list-card { - border: 1px solid $red; + border: 1px solid $gray-500; color: $red; label { box-shadow: 0 0 1px $red; From 550c0d6e732c80de730b97b4a263982d729a423e Mon Sep 17 00:00:00 2001 From: Max Date: Wed, 23 Feb 2022 15:59:18 -0500 Subject: [PATCH 02/22] Side door options fixes --- .../button-question/button-question.vue | 6 ++- .../side-door-options.spec.js | 4 +- .../side-door-options/side-door-options.vue | 40 ++++++------------- src/layouts/vehicle-damage/vehicle-damage.vue | 2 +- 4 files changed, 20 insertions(+), 32 deletions(-) diff --git a/src/common-components/button-question/button-question.vue b/src/common-components/button-question/button-question.vue index c828f9ff9..7937f0cca 100644 --- a/src/common-components/button-question/button-question.vue +++ b/src/common-components/button-question/button-question.vue @@ -122,15 +122,17 @@ export default { }, methods: { handleCheckedChanged(val) { + const newSelectedValues = this.selectedValues; if(this.isMultiSelect && this.selectedValues) { // Add or remove item to array of data to emit if(Array.isArray(this.selectedValues)) { - const newSelectedValues = this.selectedValues; val.checkValue ? newSelectedValues.push(val.value) : newSelectedValues.splice(newSelectedValues.indexOf(val.value), 1); this.selectedValues = newSelectedValues; } } else { - this.selectedValues = [val.value]; + newSelectedValues.splice(0,newSelectedValues.length); + newSelectedValues.push(val.value); + this.selectedValues = newSelectedValues; } }, }, diff --git a/src/layouts/vehicle-damage/side-door-options/side-door-options.spec.js b/src/layouts/vehicle-damage/side-door-options/side-door-options.spec.js index 239a54fd4..245076308 100644 --- a/src/layouts/vehicle-damage/side-door-options/side-door-options.spec.js +++ b/src/layouts/vehicle-damage/side-door-options/side-door-options.spec.js @@ -43,11 +43,11 @@ describe("replace-options-question.vue", () => { const { wrapper } = setupMocks({}); //Act - wrapper.vm.selectedDriverSideReplacOptionsValues = ["FrontDoor"] + wrapper.vm.selectedDriverSideReplaceOptionsValues = ["FrontDoor"] await wrapper.vm.$nextTick(); //Assert - expect(wrapper.emitted()["update:selectedDriverSideReplacOptions"][0]).toEqual([["FrontDoor"]]); + expect(wrapper.emitted()["update:selectedDriverSideReplaceOptions"][0]).toEqual([["FrontDoor"]]); }); }); diff --git a/src/layouts/vehicle-damage/side-door-options/side-door-options.vue b/src/layouts/vehicle-damage/side-door-options/side-door-options.vue index 1372f23f6..540074779 100644 --- a/src/layouts/vehicle-damage/side-door-options/side-door-options.vue +++ b/src/layouts/vehicle-damage/side-door-options/side-door-options.vue @@ -13,9 +13,9 @@ - + - + @@ -30,10 +30,6 @@ export default ({ return { questionText: String, answersFromCms: Array, - selectedDoorSides: [], - // Child component data - selectedDriverSideReplacOptions: [], - selectedPassengerSideReplaceOptions: [], } }, props: { @@ -49,11 +45,11 @@ export default ({ this.$refs.driverSideOptions.initializeComponent(driverSideReplaceOptions, driverSideOptions); this.$refs.passengerSideOptions.initializeComponent(passengerSideReplaceOptions, passengerSideOptions); }, - getSideDoorReplacementOptions(){ + getSideDoorReplacementOptions(selectedDoorSides, selectedDriverSideReplaceOptions, selectedPassengerSideReplaceOptions){ return { - selectedDoorSides: this.selectedDoorSides, - selectedDriverSideReplacOptions: this.selectedDriverSideReplacOptions, - selectedPassengerSideReplaceOptions: this.selectedPassengerSideReplaceOptions + selectedDoorSides: selectedDoorSides, + selectedDriverSideReplaceOptions: selectedDriverSideReplaceOptions, + selectedPassengerSideReplaceOptions: selectedPassengerSideReplaceOptions } }, }, @@ -68,29 +64,26 @@ export default ({ }, selectedDoorSidesValues: { get: function() { - return this.selectedDoorSides; + return this.selectedValues.selectedDoorSides; }, set: function(newValue) { - this.$emit("update:selectedDoorSides", newValue); - this.selectedValues = this.getSideDoorReplacementOptions(); + this.selectedValues = this.getSideDoorReplacementOptions(newValue, this.selectedValues.selectedDriverSideReplaceOptions, this.selectedValues.selectedPassengerSideReplaceOptions); } }, - selectedDriverSideReplacOptionsValues: { + selectedDriverSideReplaceOptionsValues: { get: function() { - return this.selectedDriverSideReplacOptions; + return this.selectedValues.selectedDriverSideReplaceOptions; }, set: function(newValue) { - this.$emit("update:selectedDriverSideReplacOptions", newValue); - this.selectedValues = this.getSideDoorReplacementOptions(); + this.selectedValues = this.getSideDoorReplacementOptions(this.selectedValues.selectedDoorSides, newValue, this.selectedValues.selectedPassengerSideReplaceOptions); } }, selectedPassengerSideReplaceOptionsValues: { get: function() { - return this.selectedPassengerSideReplaceOptions; + return this.selectedValues.selectedPassengerSideReplaceOptions; }, set: function(newValue) { - this.$emit("update:selectedPassengerSideReplaceOptions", newValue); - this.selectedValues = this.getSideDoorReplacementOptions(); + this.selectedValues = this.getSideDoorReplacementOptions(this.selectedValues.selectedDoorSides, this.selectedValues.selectedDriverSideReplaceOptions, newValue); } }, answersToDisplay(){ @@ -115,13 +108,6 @@ export default ({ return Array.isArray(this.selectedDoorSidesValues) && this.selectedDoorSidesValues.includes("PassengerSide"); }, }, - mounted() { - if(typeof(this.selectedValues) === "object"){ - this.selectedDoorSides = this.selectedValues.selectedDoorSides; - this.selectedDriverSideReplacOptions = this.selectedValues.selectedDriverSideReplacOptions; - this.selectedPassengerSideReplaceOptions = this.selectedValues.selectedPassengerSideReplaceOptions; - } - }, components: { buttonQuestion, replaceOptionsQuestion, diff --git a/src/layouts/vehicle-damage/vehicle-damage.vue b/src/layouts/vehicle-damage/vehicle-damage.vue index edbaf3a0c..aa888e14a 100644 --- a/src/layouts/vehicle-damage/vehicle-damage.vue +++ b/src/layouts/vehicle-damage/vehicle-damage.vue @@ -115,7 +115,7 @@ export default { selectedDamageLocations: [], sideDoorOptionsData: { selectedDoorSides: [], - selectedDriverSideReplacOptions: [], + selectedDriverSideReplaceOptions: [], selectedPassengerSideReplaceOptions: [] }, selectedWindshieldOptions: [], From b2a94baad5c999f5e6cd71ca691645adc3ed7bf4 Mon Sep 17 00:00:00 2001 From: Max Date: Wed, 23 Feb 2022 16:00:45 -0500 Subject: [PATCH 03/22] array fix --- src/common-components/button-question/button-question.vue | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/common-components/button-question/button-question.vue b/src/common-components/button-question/button-question.vue index 7937f0cca..e29639e09 100644 --- a/src/common-components/button-question/button-question.vue +++ b/src/common-components/button-question/button-question.vue @@ -130,9 +130,11 @@ export default { this.selectedValues = newSelectedValues; } } else { - newSelectedValues.splice(0,newSelectedValues.length); - newSelectedValues.push(val.value); - this.selectedValues = newSelectedValues; + if(this.isMultiSelect && this.selectedValues) { + newSelectedValues.splice(0,newSelectedValues.length); + newSelectedValues.push(val.value); + this.selectedValues = newSelectedValues; + } } }, }, From 74122ae7dc70e63bb73e88e004488843641253f7 Mon Sep 17 00:00:00 2001 From: Max Date: Wed, 23 Feb 2022 21:38:43 -0500 Subject: [PATCH 04/22] Changing button question logic back on radio button select --- src/common-components/button-question/button-question.vue | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/common-components/button-question/button-question.vue b/src/common-components/button-question/button-question.vue index e29639e09..6bc67a273 100644 --- a/src/common-components/button-question/button-question.vue +++ b/src/common-components/button-question/button-question.vue @@ -122,19 +122,15 @@ export default { }, methods: { handleCheckedChanged(val) { - const newSelectedValues = this.selectedValues; if(this.isMultiSelect && this.selectedValues) { // Add or remove item to array of data to emit + const newSelectedValues = this.selectedValues; if(Array.isArray(this.selectedValues)) { val.checkValue ? newSelectedValues.push(val.value) : newSelectedValues.splice(newSelectedValues.indexOf(val.value), 1); this.selectedValues = newSelectedValues; } } else { - if(this.isMultiSelect && this.selectedValues) { - newSelectedValues.splice(0,newSelectedValues.length); - newSelectedValues.push(val.value); - this.selectedValues = newSelectedValues; - } + this.selectedValues = [val.value]; } }, }, From 4ffa8d75fe65feb459056c703db1ebae95e0cbf0 Mon Sep 17 00:00:00 2001 From: Max Date: Wed, 23 Feb 2022 22:05:08 -0500 Subject: [PATCH 05/22] Fixing method name typo for radio button --- src/ux-components/radio/radio.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ux-components/radio/radio.vue b/src/ux-components/radio/radio.vue index 8d1ed6210..ed08026b2 100644 --- a/src/ux-components/radio/radio.vue +++ b/src/ux-components/radio/radio.vue @@ -10,7 +10,7 @@ :aria-required="isRequired" :value="value" :v-model="checkValue" - @change="handleCheckChanged()" + @change="handleCheckChange()" />