jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

CSR-748 Fix tests

Browse source
This commit is contained in:
Katie 2022-11-09 08:36:28 -05:00
parent 8075df60ad
commit b402894b0b
3 changed files with 32 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/layouts/estimate/estimate.vue
View file

@ -171,7 +171,6 @@ export default {
}, },
async forwardButtonAction() { async forwardButtonAction() {
if (this.isRepair) { if (this.isRepair) {
console.log("REPAIRRR")
const zipCodeData = await this.getZipCodeData(this.serviceZipCode); const zipCodeData = await this.getZipCodeData(this.serviceZipCode);
//todo: validation //todo: validation
await this.dispatchStoreAction(storeActions.SAVE_EMAIL, this.emailAddress, false); await this.dispatchStoreAction(storeActions.SAVE_EMAIL, this.emailAddress, false);

18
src/layouts/vehicle-parts/vehicle-parts.spec.js
View file

@ -232,6 +232,9 @@ describe("vehicle-parts.vue", () => {
lineItems: { lineItems: {
glassParts: null, glassParts: null,
}, },
vehicle: {
vin: "MY_VIN"
}
}, },
}, },
}, },
@ -275,6 +278,9 @@ describe("vehicle-parts.vue", () => {
lineItems: { lineItems: {
glassParts: null, glassParts: null,
}, },
vehicle: {
vin: "MY_VIN"
}
}, },
}, },
}, },
@ -292,7 +298,7 @@ describe("vehicle-parts.vue", () => {
//Assert //Assert
expect(wrapper.vm.$router.navigateWithoutSaving).toHaveBeenCalledWith( expect(wrapper.vm.$router.navigateWithoutSaving).toHaveBeenCalledWith(
navigationScenarios.CLICKED_BACK_WITH_NO_QUESTIONS, navigationScenarios.CLICKED_BACK_WITH_VIN_AND_NO_MORE_QUESTIONS,
wrapper.vm.$route wrapper.vm.$route
); );
}); });
@ -488,10 +494,12 @@ describe("vehicle-parts.vue", () => {
//Assert //Assert
expect(wrapper.vm.$store.commit).toHaveBeenCalled(); expect(wrapper.vm.$store.commit).toHaveBeenCalled();
expect(wrapper.vm.$router.navigateWithSaving).toHaveBeenCalledWith(
navigationScenarios.HAS_NO_MORE_QUESTIONS, // TODO KO UNCOMMENT FOR QUOTE PAGES RELEASE
{ query: { fmgPage: "vehicle-parts" } } // expect(wrapper.vm.$router.navigateWithSaving).toHaveBeenCalledWith(
); // navigationScenarios.HAS_NO_MORE_QUESTIONS,
// { query: { fmgPage: "vehicle-parts" } }
// );
}); });
}); });

26
src/mixins/vehicle-questions-mixin.spec.js
View file

@ -4,7 +4,6 @@ import { setupMocksForJsFiles, getMountOptions } from "@/helpers/unit-test-helpe
import { fmgPageValues } from "@/router/router-constants/fmgPage-values"; import { fmgPageValues } from "@/router/router-constants/fmgPage-values";
import { storeMutations } from "@/constants/store-mutations"; import { storeMutations } from "@/constants/store-mutations";
import { storeActions } from "@/constants/store-actions"; import { storeActions } from "@/constants/store-actions";
import { navigateToHeritageFunnel } from "@/helpers/heritage-integration/navigation-helper";
import { navigationScenarios } from "../router/router-constants/navigation-scenarios"; import { navigationScenarios } from "../router/router-constants/navigation-scenarios";
import { getters } from "@/store"; import { getters } from "@/store";
@ -1295,7 +1294,8 @@ describe("vehicle-questions-mixin", () => {
}); });
}); });
describe("should go to quote page", () => { // TODO KO UNSKIP FOR QUOTE MVP
describe.skip("should go to quote page", () => {
test("single glass location selected, has no part questions and has one part => go to heritage funnel", async () => { test("single glass location selected, has no part questions and has one part => go to heritage funnel", async () => {
// Arrange // Arrange
const partsOrQuestions = [ const partsOrQuestions = [
@ -1452,16 +1452,21 @@ describe("vehicle-questions-mixin", () => {
}); });
describe("backButtonAction", () => { describe("backButtonAction", () => {
test("current page is quote and there are no questions => go to vin-lookup", () => { // TODO KO
test.todo(
"current page is quote, there are no questions, and we don't have their vin => go to estimate"
);
test("current page is quote, there are no questions, and we have their vin => go to vin-lookup", () => {
// Arrange // Arrange
const { wrapper } = setupMocks({ fmgPage: fmgPageValues.QUOTE }); const { wrapper } = setupMocks({ fmgPage: fmgPageValues.QUOTE, hasVin: true });
// Act // Act
wrapper.vm.backButtonAction(); wrapper.vm.backButtonAction();
// Assert // Assert
expect(wrapper.vm.$router.navigateWithoutSaving).toHaveBeenCalledWith( expect(wrapper.vm.$router.navigateWithoutSaving).toHaveBeenCalledWith(
navigationScenarios.CLICKED_BACK_WITH_NO_QUESTIONS, navigationScenarios.CLICKED_BACK_WITH_VIN_AND_NO_MORE_QUESTIONS,
{ query: { fmgPage: fmgPageValues.QUOTE } } { query: { fmgPage: fmgPageValues.QUOTE } }
); );
}); });
@ -1535,7 +1540,7 @@ describe("vehicle-questions-mixin", () => {
}); });
}); });
function setupMocks({ fmgPage = fmgPageValues.VIN_LOOKUP }) { function setupMocks({ fmgPage = fmgPageValues.VIN_LOOKUP, hasVin, carId }) {
const baseMixin = setupMocksForJsFiles({ const baseMixin = setupMocksForJsFiles({
actionList: [ actionList: [
{ {
@ -1562,7 +1567,13 @@ function setupMocks({ fmgPage = fmgPageValues.VIN_LOOKUP }) {
store: { store: {
commit: jest.fn(), commit: jest.fn(),
dispatch: jest.fn(), dispatch: jest.fn(),
getters: getters, getters: {
...getters,
vehicle: {
vin: hasVin ? "VIN" : undefined,
carId: carId,
},
},
}, },
route: { route: {
query: { query: {
@ -1574,6 +1585,7 @@ function setupMocks({ fmgPage = fmgPageValues.VIN_LOOKUP }) {
// store.dispatch = jest.fn(); // store.dispatch = jest.fn();
const mockVehicleQuestionComponent = { const mockVehicleQuestionComponent = {
template: "<div />",
mixins: [vehicleQuestionsMixin, baseMixin.baseMixin], mixins: [vehicleQuestionsMixin, baseMixin.baseMixin],
}; };