From b350eaae933b69f616a0178f233bd542441a231d Mon Sep 17 00:00:00 2001 From: Katie Date: Thu, 8 Sep 2022 08:24:08 -0400 Subject: [PATCH] Revert commit 'CSR-743 experiment integration testing' and change hasSettingEqualTo to use loose equality --- .../heritage-integration/cookie-helper.js | 2 +- src/layouts/test-one.vue | 15 -- src/layouts/test-two.vue | 15 -- src/layouts/vehicle-make/vehicle-make.vue | 177 ++++++++---------- src/mixins/experiment-mixin.js | 3 - src/router/index.js | 19 +- src/router/router-constants/routing-table.js | 10 - 7 files changed, 76 insertions(+), 165 deletions(-) delete mode 100644 src/layouts/test-one.vue delete mode 100644 src/layouts/test-two.vue diff --git a/src/helpers/heritage-integration/cookie-helper.js b/src/helpers/heritage-integration/cookie-helper.js index 98e96fdb3..3eed5950b 100644 --- a/src/helpers/heritage-integration/cookie-helper.js +++ b/src/helpers/heritage-integration/cookie-helper.js @@ -74,7 +74,7 @@ export function getDeviceIdValue(){ return cookieValueMatch[0].split('=')[1]; } - return 'cf1ec454-36a8-4137-8842-5207e86ca0be'; + return '00000000-0000-0000-0000-000000000000'; } /* diff --git a/src/layouts/test-one.vue b/src/layouts/test-one.vue deleted file mode 100644 index 5ba269f2a..000000000 --- a/src/layouts/test-one.vue +++ /dev/null @@ -1,15 +0,0 @@ - - - - \ No newline at end of file diff --git a/src/layouts/test-two.vue b/src/layouts/test-two.vue deleted file mode 100644 index 2ea5fd624..000000000 --- a/src/layouts/test-two.vue +++ /dev/null @@ -1,15 +0,0 @@ - - - - \ No newline at end of file diff --git a/src/layouts/vehicle-make/vehicle-make.vue b/src/layouts/vehicle-make/vehicle-make.vue index 0fc05ec75..f5a42eefe 100644 --- a/src/layouts/vehicle-make/vehicle-make.vue +++ b/src/layouts/vehicle-make/vehicle-make.vue @@ -1,23 +1,20 @@ diff --git a/src/mixins/experiment-mixin.js b/src/mixins/experiment-mixin.js index 5161c0764..2a6b10f34 100644 --- a/src/mixins/experiment-mixin.js +++ b/src/mixins/experiment-mixin.js @@ -3,9 +3,6 @@ import store from "@/store"; export default { methods: { hasSettingEqualTo(settingName, settingValue) { - console.log(store.getters.experimentSettings) - console.log(store.getters.experimentSettings[settingName]) - console.log(settingValue) return store.getters.experimentSettings[settingName] == settingValue; }, hasSetting(settingName) { diff --git a/src/router/index.js b/src/router/index.js index 7a5855a40..4d14f70de 100644 --- a/src/router/index.js +++ b/src/router/index.js @@ -20,23 +20,8 @@ import store from "@/store"; import analyticsMixin from "@/mixins/analytics-mixin"; import { experimentTriggers } from "../constants/experiments"; import { applicationConfig } from "../constants/application-config"; -import TestOne from "@/layouts/test-one"; -import TestTwo from "@/layouts/test-two"; + const routes = [ - { - path: "/test1", - name: "test1", - components: { - default: TestOne - } - }, - { - path: "/test2", - name: "test2", - components: { - default: TestTwo - } - }, { path: "/", name: "root", @@ -240,8 +225,6 @@ function navigateToUrl(url, optionalQuery = {}) { externalUrl.searchParams.append(queryKey, optionalQuery[queryKey]); } - externalUrl.searchParams.append("experiments", "ConceptFunnel=ConceptFunnel_V1=ConceptFunnel_TEST=true"); - window.location.assign(externalUrl); } diff --git a/src/router/router-constants/routing-table.js b/src/router/router-constants/routing-table.js index f4b47bca9..d17530145 100644 --- a/src/router/router-constants/routing-table.js +++ b/src/router/router-constants/routing-table.js @@ -7,16 +7,6 @@ const routingTable = function(store) { { fmgPageValue: fmgPageValues.VEHICLE_YEAR, maps: [ - { - scenario: navigationScenarios.SELECTED_YEAR, - destinationFmgPageValue: "test1", - filter: store.getters.vehicle.year === 2010 - }, - { - scenario: navigationScenarios.SELECTED_YEAR, - destinationFmgPageValue: "test2", - filter: store.getters.vehicle.year < 1954 - }, { scenario: navigationScenarios.SELECTED_YEAR, destinationFmgPageValue: fmgPageValues.VEHICLE_MAKE,