jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1281 from Safelite/CSR-1585-footer-spacing-and-toggle-once

Browse source 
CSR-1585 Remove calculated height from menu-modal.
This commit is contained in:
bmauger 2023-07-31 14:13:02 -04:00 committed by GitHub
commit b0cb6a12a8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/fmg-components/funnel-header/menu-modal/menu-modal.vue
View file

@ -19,15 +19,13 @@
tabindex="-1" tabindex="-1"
aria-labelledby="footerModalLabel" aria-labelledby="footerModalLabel"
aria-hidden="true" aria-hidden="true"
v-on="{ 'show.bs.modal': show, 'hide.bs.modal': hide }" v-on="{ 'show.bs.modal': show, 'hide.bs.modal': hide }">
:style="`height: calc(100% - ${currentFooterAndHeaderHeight}px);`">
<div class="menu-modal-container"> <div class="menu-modal-container">
<button <button
class="menu-button" class="menu-button"
type="button" type="button"
:class="[isActive ? 'active' : '']" :class="[isActive ? 'active' : '']"
data-bs-toggle="modal" @click="toggleModal"
data-bs-target="#footerModal"
aria-label="Hamburger Menu (modal window)"> aria-label="Hamburger Menu (modal window)">
<div class="bar1"></div> <div class="bar1"></div>
<div class="bar2"></div> <div class="bar2"></div>
@ -86,7 +84,6 @@ export default {
data() { data() {
return { return {
isActive: false, isActive: false,
currentFooterAndHeaderHeight: 0,
}; };
}, },
methods: { methods: {
@ -104,7 +101,6 @@ export default {
Modal.getInstance(document.getElementById("footerModal")).hide(); Modal.getInstance(document.getElementById("footerModal")).hide();
}, },
show() { show() {
this.currentFooterAndHeaderHeight = this.getFooterInfoBoxHeight() + 72;
this.isActive = true; this.isActive = true;
this.scrollToPageTop(); this.scrollToPageTop();
}, },