From ae505070c27da80ba5004cbd0c963a4216d8682c Mon Sep 17 00:00:00 2001
From: Sneha <sneha.a@safelite.com>
Date: Mon, 13 Nov 2023 20:11:00 +0530
Subject: [PATCH] CSR-1393

---
 src/helpers/promotions-helper.js                  |  2 +-
 .../promo-modal-question/promo-modal-question.vue | 15 +++++++++------
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/src/helpers/promotions-helper.js b/src/helpers/promotions-helper.js
index d18a4aa17..996ca1aa6 100644
--- a/src/helpers/promotions-helper.js
+++ b/src/helpers/promotions-helper.js
@@ -16,7 +16,7 @@ export const addableVapsPromoPartNumbers = [
     promoPartNumberStrings.WIPER_DISCOUNT_PART_NUMBER,
 ];
 
-const promoErrorCodes = {
+export const promoErrorCodes = {
     UNKNOWN: "Unknown",
     PROMO_NOT_YET_IN_USE: "PromoNotYetInUse",
     PROMO_USAGE_COUNT_EXCEEDED: "PromoUsageCountExceeded",
diff --git a/src/layouts/payment-method/promo-modal-question/promo-modal-question.vue b/src/layouts/payment-method/promo-modal-question/promo-modal-question.vue
index 574d5356c..db04dfb00 100644
--- a/src/layouts/payment-method/promo-modal-question/promo-modal-question.vue
+++ b/src/layouts/payment-method/promo-modal-question/promo-modal-question.vue
@@ -9,6 +9,7 @@
         <modal
             :ref="modalName"
             :headerText="modalHeaderText"
+            :onModalClosedCallback="onModalClosed"
             :footerButtonText="modalFooterText"
             @footer-button-event="addPromoCode">
             <promoQuestion
@@ -50,7 +51,10 @@ import promoQuestion from "@/layouts/payment-method/promo-modal-question/promo-q
 import modal from "@/digital-components/modal/modal";
 import alert from "@/ux-components/alert/alert";
 import { storeActions } from "@/constants/store-actions.js";
-import { getVapsThatNeedToBeAddedToSatisfyPromos } from "@/helpers/promotions-helper";
+import {
+    getVapsThatNeedToBeAddedToSatisfyPromos,
+    promoErrorCodes,
+} from "@/helpers/promotions-helper";
 import { deepClone } from "@/helpers/object-helper";
 import baseMixin from "@/mixins/base-mixin.js";
 import { cartItemCategories } from "@/constants/cart-item-categories";
@@ -125,6 +129,9 @@ export default {
         closeModal() {
             this.modal.closeModal();
         },
+        onModalClosed() {
+            this.$emit("update:modelValue", this.lineItems);
+        },
         focusOnPromoInput() {
             const input = document.getElementById(this.promoTextInputId);
             input?.focus();
@@ -160,12 +167,9 @@ export default {
             };
         },
         removeItem(promo) {
-            //let lineItems = this.modelValue;
             this.lineItems[cartItemCategories.PROMOS] = this.lineItems[
                 cartItemCategories.PROMOS
             ].filter((lineItemsToKeep) => lineItemsToKeep.promoCode != promo);
-
-            this.$emit("update:modelValue", this.lineItems);
         },
         async addPromoCode() {
             if (this.promoCode) {
@@ -212,10 +216,9 @@ export default {
                     this.lineItems?.promos.push(...promoCodeData.promoCode);
                     this.lineItems.vaps?.push(...getVaps);
                     this.closeModal();
-                    this.$emit("update:modelValue", this.lineItems);
                     this.promoCode = "";
                 } else {
-                    if (promoCodeData.errorCode == "PromoStackingNotAllowed") {
+                    if (promoCodeData.errorCode == promoErrorCodes.PROMO_STACKING_NOT_ALLOWED) {
                         this.displayInvalidPromoOnOrderAlert = true;
                         this.focusOnPromoInput();
                         this.resetModalButtonStyle();