From 46865fe2bcdfd0267c014caee04e72df24f9b4b3 Mon Sep 17 00:00:00 2001 From: Adam Caouette Date: Wed, 15 Dec 2021 18:13:03 -0500 Subject: [PATCH 01/23] CSR-222: update button-back component; rename site-header and header components --- .../funnel-header.spec.js} | 6 +-- .../funnel-header.vue} | 3 +- .../funnel-sub-header.spec.js | 16 ++++++++ .../funnel-sub-header/funnel-sub-header.vue | 38 +++++++++++++++++++ .../vehicle-banner/vehicle-banner.vue | 1 + src/layouts/component-test/component-test.vue | 11 ++++-- src/layouts/vehicle-year/vehicle-year.vue | 15 +++++--- .../button-back/button-back.spec.js | 21 +++++++++- src/ux-components/button-back/button-back.vue | 20 ++++++++-- src/ux-components/header/header.spec.js | 16 -------- src/ux-components/header/header.vue | 22 ----------- 11 files changed, 113 insertions(+), 56 deletions(-) rename src/common-components/{site-header/site-header.spec.js => funnel-header/funnel-header.spec.js} (68%) rename src/common-components/{site-header/site-header.vue => funnel-header/funnel-header.vue} (90%) create mode 100644 src/common-components/funnel-sub-header/funnel-sub-header.spec.js create mode 100644 src/common-components/funnel-sub-header/funnel-sub-header.vue delete mode 100644 src/ux-components/header/header.spec.js delete mode 100644 src/ux-components/header/header.vue diff --git a/src/common-components/site-header/site-header.spec.js b/src/common-components/funnel-header/funnel-header.spec.js similarity index 68% rename from src/common-components/site-header/site-header.spec.js rename to src/common-components/funnel-header/funnel-header.spec.js index 2a471fe26..cae21a179 100644 --- a/src/common-components/site-header/site-header.spec.js +++ b/src/common-components/funnel-header/funnel-header.spec.js @@ -1,12 +1,12 @@ import { shallowMount } from "@vue/test-utils"; -import siteHeader from "./site-header"; +import funnelHeader from "./funnel-header"; -describe("siteHeader", () => { +describe("funnelHeader", () => { test("renders the logo image", () => { // Arrange // Act - const wrapper = shallowMount(siteHeader, { + const wrapper = shallowMount(funnelHeader, { propsData: { imageSrc: "image_url", }, diff --git a/src/common-components/site-header/site-header.vue b/src/common-components/funnel-header/funnel-header.vue similarity index 90% rename from src/common-components/site-header/site-header.vue rename to src/common-components/funnel-header/funnel-header.vue index 441b188c4..7b6c6efc6 100644 --- a/src/common-components/site-header/site-header.vue +++ b/src/common-components/funnel-header/funnel-header.vue @@ -9,11 +9,12 @@ + + diff --git a/src/common-components/vehicle-banner/vehicle-banner.vue b/src/common-components/vehicle-banner/vehicle-banner.vue index 51e8d8aa3..e369cddb9 100644 --- a/src/common-components/vehicle-banner/vehicle-banner.vue +++ b/src/common-components/vehicle-banner/vehicle-banner.vue @@ -15,6 +15,7 @@ export default { vehicleImageSrc: { type: String, required: true, + default: "", }, }, }; diff --git a/src/layouts/component-test/component-test.vue b/src/layouts/component-test/component-test.vue index 624469e8a..5d2bb02e7 100644 --- a/src/layouts/component-test/component-test.vue +++ b/src/layouts/component-test/component-test.vue @@ -52,7 +52,10 @@
- +
@@ -398,7 +401,7 @@
-
@@ -426,7 +429,7 @@ import listCard from "@/ux-components/list-card/list-card"; import listButton from "@/ux-components/list-button/list-button"; import alert from "@/ux-components/alert/alert"; import vehicleBanner from "@/common-components/vehicle-banner/vehicle-banner"; -import siteHeader from "@/common-components/site-header/site-header"; +import funnelHeader from "@/common-components/funnel-header/funnel-header"; import listButtonHorizontal from "@/ux-components/list-button-horizontal/list-button-horizontal"; export default { name: "App", @@ -439,7 +442,7 @@ export default { alert, vehicleBanner, listButtonHorizontal, - siteHeader, + funnelHeader, }, data() { return { diff --git a/src/layouts/vehicle-year/vehicle-year.vue b/src/layouts/vehicle-year/vehicle-year.vue index f5ce99324..692526cf5 100644 --- a/src/layouts/vehicle-year/vehicle-year.vue +++ b/src/layouts/vehicle-year/vehicle-year.vue @@ -1,10 +1,13 @@