From e725baf852d34be95701181deb133d2aa02f9ce4 Mon Sep 17 00:00:00 2001
From: Adam Caouette <adam.caouette@safelite.com>
Date: Wed, 29 Nov 2023 08:04:31 -0500
Subject: [PATCH] CSR-1843: fix places where link causes scroll to top

---
 src/fmg-components/cart/cart.vue                          | 8 ++++----
 .../promo-modal-question/promo-modal-question.vue         | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/fmg-components/cart/cart.vue b/src/fmg-components/cart/cart.vue
index 1180b3152..a373bb874 100644
--- a/src/fmg-components/cart/cart.vue
+++ b/src/fmg-components/cart/cart.vue
@@ -7,7 +7,7 @@
                 @click="toggleIsExpanded()">
                 <a
                     aria-label="expand cart"
-                    href="#!"
+                    href="javascript:void(0)"
                     class="col d-flex justify-content-between py-0">
                     <span class="label">{{ amountDueText }}</span>
                     <span class="label amount-due">{{ getFormattedAmount("", amountDue) }}</span>
@@ -30,7 +30,7 @@
                         ref="removeLink"
                         linkType="text"
                         :text="removeLinkText"
-                        href="#!"
+                        href="javascript:void(0)"
                         @click-event="removeItem(cartItem.cartItemType, cartItem.category)">
                         <template v-slot:after-text>
                             <span class="sr-only">{{ cartItem.name }}</span>
@@ -53,13 +53,13 @@
                         ref="removeLink"
                         linkType="text"
                         :text="removeLinkText"
-                        href="#!"
+                        href="javascript:void(0)"
                         @click-event="removeItem(cartItem.cartItemType, cartItem.category)" />
                     <textLink
                         v-else-if="cartItem == recycleFeeCartItem && recyclingModalCmsWidgetName"
                         linkType="text"
                         :text="recycleFeeCartItem.name"
-                        href="#!"
+                        href="javascript:void(0)"
                         @click-event="openModal(recyclingModalCmsWidgetName)" />
                     <span v-else-if="cartItem == recycleFeeCartItem">
                         {{ recycleFeeCartItem.name }}
diff --git a/src/layouts/payment-method/promo-modal-question/promo-modal-question.vue b/src/layouts/payment-method/promo-modal-question/promo-modal-question.vue
index e6ea27737..5ef5049a0 100644
--- a/src/layouts/payment-method/promo-modal-question/promo-modal-question.vue
+++ b/src/layouts/payment-method/promo-modal-question/promo-modal-question.vue
@@ -4,7 +4,7 @@
             id="promoLinkPromptId"
             linkType="text"
             :text="promoLinkText"
-            href="#!"
+            href="javascript:void(0)"
             @click-event="openModal" />
         <modal
             :ref="modalName"
@@ -57,7 +57,7 @@
                     ref="removeLink"
                     linkType="text"
                     :text="removeLinkText"
-                    href="#!"
+                    href="javascript:void(0)"
                     @click-event="removeItem(promoCode)" />
             </div>
         </modal>