Bug fixes, 1) added zipToDisplay datum for cases when registration zip entered is also not valid, 2) changed navigateAfterSaveToHeritageFunnel function to exported function as it is not in global and fixed unit tests with it. 3) Fixed updateServiceLocationZipCode name in vuex.
This commit is contained in:
parent
f802035b26
commit
aab32ef7b1
3 changed files with 12 additions and 7 deletions
|
|
@ -3,6 +3,7 @@ import licensePlateLookup from "@/layouts/license-plate-lookup/license-plate-loo
|
||||||
|
|
||||||
// Supporting Files
|
// Supporting Files
|
||||||
import { settleAllPromises } from "@/helpers/layout-helper.js";
|
import { settleAllPromises } from "@/helpers/layout-helper.js";
|
||||||
|
import * as navigateToHeritage from "@/helpers/heritage-integration/navigation-helper";
|
||||||
import baseMixin from "@/mixins/base-mixin";
|
import baseMixin from "@/mixins/base-mixin";
|
||||||
import { fetchCmsContentForPage } from "@/helpers/cms-content-helper";
|
import { fetchCmsContentForPage } from "@/helpers/cms-content-helper";
|
||||||
import { shallowMount, flushPromises } from "@vue/test-utils";
|
import { shallowMount, flushPromises } from "@vue/test-utils";
|
||||||
|
|
@ -377,15 +378,14 @@ describe("license-plate-lookup.vue", () => {
|
||||||
|
|
||||||
//Act
|
//Act
|
||||||
wrapper.vm.isCarIdDifferent = false;
|
wrapper.vm.isCarIdDifferent = false;
|
||||||
wrapper.vm.$router.navigateAfterSaveToHeritageFunnel = jest.fn();
|
|
||||||
wrapper.vm.getCmsContent = jest.fn().mockImplementation(() => {
|
wrapper.vm.getCmsContent = jest.fn().mockImplementation(() => {
|
||||||
return '';
|
return '';
|
||||||
});
|
});
|
||||||
|
navigateToHeritage.navigateAfterSaveToHeritageFunnel = jest.fn();
|
||||||
await wrapper.vm.navigateForward();
|
await wrapper.vm.navigateForward();
|
||||||
|
|
||||||
//Assert
|
//Assert
|
||||||
expect(wrapper.vm.$router.navigateAfterSaveToHeritageFunnel).toHaveBeenCalled();
|
expect(navigateToHeritage.navigateAfterSaveToHeritageFunnel).toHaveBeenCalled();
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -61,6 +61,9 @@ import {
|
||||||
import {
|
import {
|
||||||
errorMessages
|
errorMessages
|
||||||
} from "@/constants/error-messages";
|
} from "@/constants/error-messages";
|
||||||
|
import {
|
||||||
|
navigateAfterSaveToHeritageFunnel
|
||||||
|
} from "@/helpers/heritage-integration/navigation-helper";
|
||||||
import {
|
import {
|
||||||
getDamageString,
|
getDamageString,
|
||||||
isGlassAvailableForCarId,
|
isGlassAvailableForCarId,
|
||||||
|
|
@ -125,6 +128,7 @@ export default {
|
||||||
previouslyEnteredCarId: "",
|
previouslyEnteredCarId: "",
|
||||||
customAlertData: {},
|
customAlertData: {},
|
||||||
isSelectedGlassAvailableForVehicle: true,
|
isSelectedGlassAvailableForVehicle: true,
|
||||||
|
zipToDisplay: this.getRegistrationZipFromStore(),
|
||||||
};
|
};
|
||||||
},
|
},
|
||||||
mounted() {
|
mounted() {
|
||||||
|
|
@ -162,7 +166,7 @@ export default {
|
||||||
let text = this.getCmsContent(
|
let text = this.getCmsContent(
|
||||||
"NoServiceZipWidget",
|
"NoServiceZipWidget",
|
||||||
"HeadlineText"
|
"HeadlineText"
|
||||||
).replaceAll("{custom:zip}", this.registrationZip);
|
).replaceAll("{custom:zip}", this.zipToDisplay);
|
||||||
return text;
|
return text;
|
||||||
},
|
},
|
||||||
NoServiceZipBody() {
|
NoServiceZipBody() {
|
||||||
|
|
@ -214,6 +218,7 @@ export default {
|
||||||
this.isVinValid = true;
|
this.isVinValid = true;
|
||||||
this.isRegistrationZipServicable = false;
|
this.isRegistrationZipServicable = false;
|
||||||
this.isCarIdDifferent = false;
|
this.isCarIdDifferent = false;
|
||||||
|
this.zipToDisplay = this.serviceZip ? this.serviceZip : this.registrationZip;
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
@ -265,7 +270,7 @@ export default {
|
||||||
);
|
);
|
||||||
return;
|
return;
|
||||||
} else {
|
} else {
|
||||||
this.$router.navigateAfterSaveToHeritageFunnel(this.$route);
|
navigateAfterSaveToHeritageFunnel(this.$route);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
|
|
|
||||||
|
|
@ -144,9 +144,9 @@ export const mutations = {
|
||||||
updateRegistrationAddress(state, registrationAddress){
|
updateRegistrationAddress(state, registrationAddress){
|
||||||
state.order.vehicle.registration.address = registrationAddress;
|
state.order.vehicle.registration.address = registrationAddress;
|
||||||
},
|
},
|
||||||
updateServiceLocationZip(state, serviceLocationZip){
|
updateServiceLocationZipCode(state, serviceLocationZip){
|
||||||
state.order.vehicle.registration.zip = serviceLocationZip;
|
state.order.vehicle.registration.zip = serviceLocationZip;
|
||||||
},
|
},
|
||||||
updateRegistrationCity(state, serviceCity){
|
updateRegistrationCity(state, serviceCity){
|
||||||
state.order.vehicle.registration.city = serviceCity;
|
state.order.vehicle.registration.city = serviceCity;
|
||||||
},
|
},
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue