From 1a5ed36e97a7b1b8399b2382e0d70581776499b3 Mon Sep 17 00:00:00 2001 From: CarlNation <32103961+CarlNation@users.noreply.github.com> Date: Fri, 12 Apr 2024 10:21:52 -0400 Subject: [PATCH 1/4] CSR-2063 CSR-2063 allow users that select 'vehicle not listed' button to return to concept and change their vehicle --- src/layouts/vehicle-damage/vehicle-damage.vue | 3 +- src/layouts/vehicle/vehicle.vue | 41 +++++++++++++++++-- 2 files changed, 38 insertions(+), 6 deletions(-) diff --git a/src/layouts/vehicle-damage/vehicle-damage.vue b/src/layouts/vehicle-damage/vehicle-damage.vue index 866567101..61a606978 100644 --- a/src/layouts/vehicle-damage/vehicle-damage.vue +++ b/src/layouts/vehicle-damage/vehicle-damage.vue @@ -528,8 +528,7 @@ export default { }, shouldHideBackButton() { return ( - this.$store.getters.payment.insuranceCoverage.isVerified || - getFunnelCookie()?.HasDelayedClaimRegistration + this.$store.getters.payment.insuranceCoverage.isVerified ); }, }, diff --git a/src/layouts/vehicle/vehicle.vue b/src/layouts/vehicle/vehicle.vue index 18f9064d2..2376b2a3d 100644 --- a/src/layouts/vehicle/vehicle.vue +++ b/src/layouts/vehicle/vehicle.vue @@ -12,7 +12,7 @@ Date: Fri, 12 Apr 2024 10:25:31 -0400 Subject: [PATCH 2/4] remove test code --- src/layouts/vehicle/vehicle.vue | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/layouts/vehicle/vehicle.vue b/src/layouts/vehicle/vehicle.vue index 2376b2a3d..6efd0a953 100644 --- a/src/layouts/vehicle/vehicle.vue +++ b/src/layouts/vehicle/vehicle.vue @@ -97,10 +97,6 @@ import { errorMessages } from "@/constants/error-messages"; import store from "@/store"; import { storeActions } from "@/constants/store-actions.js"; import baseMixin from "@/mixins/base-mixin.js"; - -import { applicationConfig } from "@/constants/application-config.js"; -import { getDeviceIdValue } from "@/helpers/heritage-integration/cookie-helper"; -import { experimentTriggers } from "@/constants/experiments"; import { getFunnelCookie } from "@/helpers/heritage-integration/cookie-helper"; //define validation rules @@ -132,14 +128,6 @@ export default { async beforeRouteEnter(to, from, next) { // Call APIs - if (applicationConfig.CURRENT_ENVIRONMENT === "Localhost") { - storeActions.RUN_EXPERIMENTS_FOR_TRIGGER, - { - userId: getDeviceIdValue(), - triggerEvent: experimentTriggers.PAGE_ENTRY, - triggerValue: "vehicle", - }; - } const cmsContentPromise = fetchCmsContentForPage(to.query.fmgPage); const experimentForLogging = store.getters.applicationUser.experiments.find( From 4e245fd08e10fa96231fbd58445214b53bfdacf6 Mon Sep 17 00:00:00 2001 From: CarlNation Date: Fri, 12 Apr 2024 10:26:53 -0400 Subject: [PATCH 3/4] prettier --- src/layouts/vehicle-damage/vehicle-damage.vue | 4 +--- src/layouts/vehicle/vehicle.vue | 11 +++++++---- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/layouts/vehicle-damage/vehicle-damage.vue b/src/layouts/vehicle-damage/vehicle-damage.vue index 61a606978..38430754c 100644 --- a/src/layouts/vehicle-damage/vehicle-damage.vue +++ b/src/layouts/vehicle-damage/vehicle-damage.vue @@ -527,9 +527,7 @@ export default { return this.$route.params[this.routerParams.DISPLAY_VEHICLE_CHANGE_ALERT]; }, shouldHideBackButton() { - return ( - this.$store.getters.payment.insuranceCoverage.isVerified - ); + return this.$store.getters.payment.insuranceCoverage.isVerified; }, }, diff --git a/src/layouts/vehicle/vehicle.vue b/src/layouts/vehicle/vehicle.vue index 6efd0a953..e4a19d335 100644 --- a/src/layouts/vehicle/vehicle.vue +++ b/src/layouts/vehicle/vehicle.vue @@ -346,13 +346,16 @@ export default { }, methods: { isDisabled(options) { - if (!options.length || store.getters.payment?.insuranceCoverage?.isVerified || getFunnelCookie()?.HasDelayedClaimRegistration) { + if ( + !options.length || + store.getters.payment?.insuranceCoverage?.isVerified || + getFunnelCookie()?.HasDelayedClaimRegistration + ) { return true; - } - else { + } else { return false; } - }, + }, getVehicle(year, make, model, style) { return this.dispatchStoreActionWithLogging( this.storeActions.GET_VEHICLE, From 53f74d20dddd9a3276b86a3871d6aab1b4ff6d22 Mon Sep 17 00:00:00 2001 From: CarlNation Date: Fri, 12 Apr 2024 10:40:21 -0400 Subject: [PATCH 4/4] CSR-2063 CSR-2063 will allow hasclaimregistration to go to vehicle page now but disable vehicle dropdowns --- src/layouts/vehicle-damage/vehicle-damage.spec.js | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/layouts/vehicle-damage/vehicle-damage.spec.js b/src/layouts/vehicle-damage/vehicle-damage.spec.js index efe06a350..1a2939d3d 100644 --- a/src/layouts/vehicle-damage/vehicle-damage.spec.js +++ b/src/layouts/vehicle-damage/vehicle-damage.spec.js @@ -718,18 +718,6 @@ describe("vehicle-damage.vue", () => { ); }); describe("hide back button", () => { - test("if claim registration is delayed => should hide back button", () => { - // Arrange - const { wrapper } = setupMocks({ - funnelCookie: { - HasDelayedClaimRegistration: true, - }, - }); - - // Assert - expect(wrapper.vm.shouldHideBackButton).toBe(true); - }); - test("if claim is verified => should hide back button", () => { // Arrange const { wrapper } = setupMocks({