From 3399ef24a046cea060c3e18050d9905119bf9f85 Mon Sep 17 00:00:00 2001 From: CarlNation Date: Thu, 23 Feb 2023 08:09:53 -0500 Subject: [PATCH 1/3] CSR-1212 reworked to be more specific so it doesn't pass prereq for an empty array --- src/layouts/vehicle-parts/vehicle-parts.vue | 6 ++++-- vue.config.js | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/layouts/vehicle-parts/vehicle-parts.vue b/src/layouts/vehicle-parts/vehicle-parts.vue index 1c35f96fa..3c2978744 100644 --- a/src/layouts/vehicle-parts/vehicle-parts.vue +++ b/src/layouts/vehicle-parts/vehicle-parts.vue @@ -149,10 +149,12 @@ export default { methods: { arePagePrerequisitesValid() { // Check if isRepair is populated and if the pageData we need is here (Parts data) + const vehiclePartsFromPageData = store.getters.pageData( + fmgPageValues.VEHICLE_PARTS + ); return ( store.getters.damage.isRepair != null && - store.getters.pageData(fmgPageValues.VEHICLE_PARTS) && - Object.keys(store.getters.pageData(fmgPageValues.VEHICLE_PARTS)).length !== 0 + vehiclePartsFromPageData?.partsOrQuestions?.some((part) => part?.glassName) ); }, async forwardButtonAction() { diff --git a/vue.config.js b/vue.config.js index 64c83dd9e..e87582db2 100644 --- a/vue.config.js +++ b/vue.config.js @@ -1,7 +1,7 @@ process.env.VUE_APP_CONSUMER_CF_DISTRO = "https://digitalapi.dev.safelite.io"; process.env.VUE_APP_HERITAGE_FUNNEL = - "http://localhost:38000/default.aspx"; + "http://localhost/default.aspx"; process.env.VUE_APP_GOOGLE_PLACES_API_KEY = "AIzaSyDptGCkOPgN2uWJOy4ou4M33phRD4MAoJo"; process.env.VUE_APP_CURRENT_ENVIRONMENT = "Localhost"; From 4fff8b9f6b82b2cf505b9e6f8a5b30cfb36a588e Mon Sep 17 00:00:00 2001 From: CarlNation Date: Thu, 23 Feb 2023 08:18:12 -0500 Subject: [PATCH 2/3] CSR-1212 add back port --- vue.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vue.config.js b/vue.config.js index e87582db2..64c83dd9e 100644 --- a/vue.config.js +++ b/vue.config.js @@ -1,7 +1,7 @@ process.env.VUE_APP_CONSUMER_CF_DISTRO = "https://digitalapi.dev.safelite.io"; process.env.VUE_APP_HERITAGE_FUNNEL = - "http://localhost/default.aspx"; + "http://localhost:38000/default.aspx"; process.env.VUE_APP_GOOGLE_PLACES_API_KEY = "AIzaSyDptGCkOPgN2uWJOy4ou4M33phRD4MAoJo"; process.env.VUE_APP_CURRENT_ENVIRONMENT = "Localhost"; From 36bebf1e0d7dc5a949095f29fec173ef410bbcf5 Mon Sep 17 00:00:00 2001 From: CarlNation Date: Thu, 23 Feb 2023 08:25:34 -0500 Subject: [PATCH 3/3] CSR-1212 prettier --- src/layouts/vehicle-parts/vehicle-parts.vue | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/layouts/vehicle-parts/vehicle-parts.vue b/src/layouts/vehicle-parts/vehicle-parts.vue index 3c2978744..e06604a4a 100644 --- a/src/layouts/vehicle-parts/vehicle-parts.vue +++ b/src/layouts/vehicle-parts/vehicle-parts.vue @@ -149,9 +149,7 @@ export default { methods: { arePagePrerequisitesValid() { // Check if isRepair is populated and if the pageData we need is here (Parts data) - const vehiclePartsFromPageData = store.getters.pageData( - fmgPageValues.VEHICLE_PARTS - ); + const vehiclePartsFromPageData = store.getters.pageData(fmgPageValues.VEHICLE_PARTS); return ( store.getters.damage.isRepair != null && vehiclePartsFromPageData?.partsOrQuestions?.some((part) => part?.glassName)