jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1539 from Safelite/feature/CSR-1388-tech-review-changes

Browse source 
Feature/csr 1388 tech review changes
This commit is contained in:
Leah Schumann 2023-11-16 09:21:38 -05:00 committed by GitHub
commit a73dfc604b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/fmg-components/cart/cart.vue
View file

@ -546,8 +546,9 @@ export default {
otherSupportingItemsCartItem() { otherSupportingItemsCartItem() {
let cartItem = null; let cartItem = null;
const otherSupportingItemsLineItems = this.supportingItems.filter( // Don't include fees they are part of the package total
(lineItem) => lineItem.partType != partTypeStrings.EARLY_BIRD let otherSupportingItemsLineItems = baseMixin.methods.filterOutFees(
this.supportingItems
); );
if (otherSupportingItemsLineItems.length > 0) { if (otherSupportingItemsLineItems.length > 0) {

4
src/store/index.js
View file

@ -2642,7 +2642,7 @@ function addPricesToLineItems(lineItems, pricingLineItems) {
function addTaxesToPricedLineItems(pricedLineItems, taxingLineItems = []) { function addTaxesToPricedLineItems(pricedLineItems, taxingLineItems = []) {
pricedLineItems.forEach((pricedLineItem) => { pricedLineItems.forEach((pricedLineItem) => {
let lineItemIndex = taxingLineItems.findIndex( const lineItemIndex = taxingLineItems.findIndex(
(taxingLineItem) => taxingLineItem.partNumber === pricedLineItem.partNumber (taxingLineItem) => taxingLineItem.partNumber === pricedLineItem.partNumber
); );
@ -2650,7 +2650,7 @@ function addTaxesToPricedLineItems(pricedLineItems, taxingLineItems = []) {
addTaxesToPricedLineItems(pricedLineItem.childParts, taxingLineItems); addTaxesToPricedLineItems(pricedLineItem.childParts, taxingLineItems);
} }
let taxedLineItem = taxingLineItems.splice(lineItemIndex, 1)[0]; const taxedLineItem = taxingLineItems.splice(lineItemIndex, 1)[0];
pricedLineItem.salesTax = taxedLineItem?.salesTax ?? 0; pricedLineItem.salesTax = taxedLineItem?.salesTax ?? 0;
}); });