jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #3102 from Safelite/feature/page-prereqs-refactor-CASH-2456

Browse source 
All refactored pre-req will check all instead of stopping first failr
This commit is contained in:
matthew-sykes 2026-03-16 15:05:57 -04:00 committed by GitHub
commit a64a314f26
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 32 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/layouts/payment-adyen/payment-adyen.vue
View file

@ -146,13 +146,15 @@ export default {
arePagePrerequisitesValid() { arePagePrerequisitesValid() {
const order = store.getters.order; const order = store.getters.order;
const logQueue = []; const logQueue = [];
const result = const results = [
hasServiceLocationInfo(order, logQueue) && hasServiceLocationInfo(order, logQueue),
hasInsuranceInfo(order, logQueue) && hasInsuranceInfo(order, logQueue),
hasSchedulingInfo(order, logQueue) && hasSchedulingInfo(order, logQueue),
hasCustomerInfo(order, logQueue) && hasCustomerInfo(order, logQueue),
hasPaymentMethodInfo(order, logQueue) && hasPaymentMethodInfo(order, logQueue),
hasGlassPartsOrRepairInfo(order, logQueue); hasGlassPartsOrRepairInfo(order, logQueue),
];
const result = results.every(Boolean);
flushPagePrereqsLogs("payment-adyen.vue", result, logQueue); flushPagePrereqsLogs("payment-adyen.vue", result, logQueue);
return result; return result;
}, },

15
src/layouts/payment-method/payment-method.vue
View file

@ -390,12 +390,15 @@ export default {
arePagePrerequisitesValid() { arePagePrerequisitesValid() {
const order = store.getters.order; const order = store.getters.order;
const logQueue = []; const logQueue = [];
const result = const results = [
hasServiceLocationInfo(order, logQueue) && hasServiceLocationInfo(order, logQueue),
hasInsuranceInfo(order, logQueue) && hasInsuranceInfo(order, logQueue),
hasSchedulingInfo(order, logQueue) && hasSchedulingInfo(order, logQueue),
hasCustomerInfo(order, logQueue) && hasCustomerInfo(order, logQueue),
hasGlassPartsOrRepairInfo(order, logQueue); hasGlassPartsOrRepairInfo(order, logQueue),
];
//false if any check is false but calls all checks for logging purposes
const result = results.every(Boolean);
flushPagePrereqsLogs("payment-method.vue", result, logQueue); flushPagePrereqsLogs("payment-method.vue", result, logQueue);
return result; return result;
}, },

16
src/layouts/payment/payment.vue
View file

@ -445,13 +445,15 @@ export default {
arePagePrerequisitesValid() { arePagePrerequisitesValid() {
const order = store.getters.order; const order = store.getters.order;
const logQueue = []; const logQueue = [];
const result = const results = [
hasServiceLocationInfo(order, logQueue) && hasServiceLocationInfo(order, logQueue),
hasInsuranceInfo(order, logQueue) && hasInsuranceInfo(order, logQueue),
hasSchedulingInfo(order, logQueue) && hasSchedulingInfo(order, logQueue),
hasCustomerInfo(order, logQueue) && hasCustomerInfo(order, logQueue),
hasPaymentMethodInfo(order, logQueue) && hasPaymentMethodInfo(order, logQueue),
hasGlassPartsOrRepairInfo(order, logQueue); hasGlassPartsOrRepairInfo(order, logQueue),
];
const result = results.every(Boolean);
flushPagePrereqsLogs("payment.vue", result, logQueue); flushPagePrereqsLogs("payment.vue", result, logQueue);
return result; return result;
}, },

9
src/layouts/quote/quote.vue
View file

@ -739,10 +739,11 @@ export default {
order.payment?.insuranceCoverage?.isVerified == null || order.payment?.insuranceCoverage?.isVerified == null ||
order.payment?.insuranceCoverage?.isVerified === false; order.payment?.insuranceCoverage?.isVerified === false;
const preReqResult = const results = [
hasServiceZipInfo(order, logQueue) && hasServiceZipInfo(order, logQueue),
hasGlassPartsOrRepairInfo(order, logQueue) && hasGlassPartsOrRepairInfo(order, logQueue),
isVerifiedOk; ];
const preReqResult = results.every(Boolean) && isVerifiedOk;
logQueue.push(() => { logQueue.push(() => {
debugLog( debugLog(