From a78030b1174e9846f67771e90b777c1ce0e4c8eb Mon Sep 17 00:00:00 2001 From: Scott Kiener Date: Wed, 14 Feb 2024 09:44:23 -0500 Subject: [PATCH 1/4] CSR-1975 | Wiper promo bug on Quote fix --- src/layouts/quote/quote.vue | 1 - src/store/index.js | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/layouts/quote/quote.vue b/src/layouts/quote/quote.vue index 19fc39074..d29a96b92 100644 --- a/src/layouts/quote/quote.vue +++ b/src/layouts/quote/quote.vue @@ -43,7 +43,6 @@ class="small mt-4" v-model="lineItems" :availableVaps="availableVaps" - :availableLineItems="availableLineItems" pageName="quote" :taxPromos="false" modalWidgetName="PromoModalWidget" /> diff --git a/src/store/index.js b/src/store/index.js index 472e15b6d..02eca9806 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -2310,6 +2310,9 @@ export const actions = { ) { const order = context.getters.order; lineItemsToUse = lineItemsToUse ?? order.lineItems; + addGuidToLineItemsIfNotAlreadyThere(lineItemsToUse.vaps); + syncLineItemIds(addableVaps, lineItemsToUse.vaps); + // addableVaps still won't have IDs if they weren't already in lineItemsToUse addGuidToLineItemsIfNotAlreadyThere(addableVaps); const requestObject = { promoCode: promoCode, From f622f1ad6262b81de57c0667651877388db1651b Mon Sep 17 00:00:00 2001 From: Scott Kiener Date: Wed, 14 Feb 2024 10:11:52 -0500 Subject: [PATCH 2/4] CSR-1975 | Update unit tests --- src/store/store.spec.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/store/store.spec.js b/src/store/store.spec.js index 17dc27ec2..ca5840c4d 100644 --- a/src/store/store.spec.js +++ b/src/store/store.spec.js @@ -2933,7 +2933,7 @@ describe("Actions", () => { // Arrange const context = state; const promoCode = "testPromo"; - const lineItemsToUse = { vaps: [1], promos: [2] }; + const lineItemsToUse = { vaps: [{partNumber: 1}], promos: [2] }; const addableVaps = [{ partNumber: "addableVap" }]; context["getters"] = { @@ -3013,7 +3013,7 @@ describe("Actions", () => { }, referralSequenceNumber: "test", lineItems: { - vaps: [1], + vaps: [{partNumber: 1}], promos: [2], serverData: "test", }, @@ -3026,7 +3026,7 @@ describe("Actions", () => { crypto.randomUUID = jest.fn(() => "GUID"); - const expectedLineItemsOnOrder = [1, 2]; + const expectedLineItemsOnOrder = [{partNumber: 1, id:"GUID"}, 2]; // Act actions.validateOrderPromoAndSaveServerData(context, { @@ -3073,7 +3073,7 @@ describe("Actions", () => { }, referralSequenceNumber: "test", lineItems: { - vaps: [1], + vaps: [{partNumber: 1}], promos: [2], serverData: "test", }, @@ -3131,7 +3131,7 @@ describe("Actions", () => { }, referralSequenceNumber: "test", lineItems: { - vaps: [1], + vaps: [{partNumber: 1}], promos: [2], serverData: "test", }, From 6a55942b567d4d1aa06c43e49dc5944c426d54fc Mon Sep 17 00:00:00 2001 From: Scott Kiener Date: Wed, 14 Feb 2024 10:14:07 -0500 Subject: [PATCH 3/4] CSR-1975 | Unit test formatting --- src/store/store.spec.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/store/store.spec.js b/src/store/store.spec.js index ca5840c4d..bfa09f9a1 100644 --- a/src/store/store.spec.js +++ b/src/store/store.spec.js @@ -2933,7 +2933,7 @@ describe("Actions", () => { // Arrange const context = state; const promoCode = "testPromo"; - const lineItemsToUse = { vaps: [{partNumber: 1}], promos: [2] }; + const lineItemsToUse = { vaps: [{ partNumber: 1 }], promos: [2] }; const addableVaps = [{ partNumber: "addableVap" }]; context["getters"] = { @@ -3013,7 +3013,7 @@ describe("Actions", () => { }, referralSequenceNumber: "test", lineItems: { - vaps: [{partNumber: 1}], + vaps: [{ partNumber: 1 }], promos: [2], serverData: "test", }, @@ -3026,7 +3026,7 @@ describe("Actions", () => { crypto.randomUUID = jest.fn(() => "GUID"); - const expectedLineItemsOnOrder = [{partNumber: 1, id:"GUID"}, 2]; + const expectedLineItemsOnOrder = [{ partNumber: 1, id: "GUID" }, 2]; // Act actions.validateOrderPromoAndSaveServerData(context, { @@ -3073,7 +3073,7 @@ describe("Actions", () => { }, referralSequenceNumber: "test", lineItems: { - vaps: [{partNumber: 1}], + vaps: [{ partNumber: 1 }], promos: [2], serverData: "test", }, @@ -3131,7 +3131,7 @@ describe("Actions", () => { }, referralSequenceNumber: "test", lineItems: { - vaps: [{partNumber: 1}], + vaps: [{ partNumber: 1 }], promos: [2], serverData: "test", }, From e4edb81c3ac756074abed095abbe88e78691cb13 Mon Sep 17 00:00:00 2001 From: Scott Kiener Date: Wed, 14 Feb 2024 10:54:45 -0500 Subject: [PATCH 4/4] Remove email address requirement from address-vehicles --- src/layouts/address-vehicles/address-vehicles.vue | 1 - 1 file changed, 1 deletion(-) diff --git a/src/layouts/address-vehicles/address-vehicles.vue b/src/layouts/address-vehicles/address-vehicles.vue index 7bc59a716..7b5fc72b2 100644 --- a/src/layouts/address-vehicles/address-vehicles.vue +++ b/src/layouts/address-vehicles/address-vehicles.vue @@ -164,7 +164,6 @@ export default { if ( store.getters.order.vehicle.carId && store.getters.order.serviceLocation.zipCode && - store.getters.order.customer.emailAddress && store.getters.pageData(fmgPageValues.ADDRESS_VEHICLES) ) { return true;