From 96a5cdf46e9b8e53c1ff5a9039a56aef95f51a8b Mon Sep 17 00:00:00 2001 From: Adam Caouette Date: Wed, 5 Jan 2022 16:55:10 -0500 Subject: [PATCH] CSR-222: refactor with emit for click event --- .../funnel-sub-header/funnel-sub-header.vue | 16 ++++++---- src/layouts/vehicle-make/vehicle-make.vue | 6 ++-- src/layouts/vehicle-model/vehicle-model.vue | 4 +-- src/layouts/vehicle-style/vehicle-style.vue | 4 +-- src/ux-components/button-back/button-back.vue | 12 +++---- .../list-button-horizontal.spec.js | 3 +- .../list-button-horizontal.vue | 31 ++++++++++++++++--- src/ux-components/list-card/list-card.vue | 31 +++++++++++++------ 8 files changed, 73 insertions(+), 34 deletions(-) diff --git a/src/common-components/funnel-sub-header/funnel-sub-header.vue b/src/common-components/funnel-sub-header/funnel-sub-header.vue index 3fd7ebc15..c86141b8c 100644 --- a/src/common-components/funnel-sub-header/funnel-sub-header.vue +++ b/src/common-components/funnel-sub-header/funnel-sub-header.vue @@ -6,10 +6,10 @@ {{ text }} + v-if="hasBackButton" + :backButtonAccessibleText="backButtonAccessibleText" + @click-event="clickEvent" + /> @@ -24,11 +24,15 @@ export default { text: String, hasBackButton: Boolean, backButtonAccessibleText: String, - backButtonAction: Function, }, components: { buttonBack, - } + }, + methods: { + clickEvent() { + this.$emit('click-event'); + } + }, }; diff --git a/src/layouts/vehicle-make/vehicle-make.vue b/src/layouts/vehicle-make/vehicle-make.vue index f158b754a..400f491ca 100644 --- a/src/layouts/vehicle-make/vehicle-make.vue +++ b/src/layouts/vehicle-make/vehicle-make.vue @@ -8,8 +8,8 @@ :text="funnelSubHeaderWidget.HeaderText" :hasBackButton="true" backButtonAccessibleText="Change Vehicle Year" - :backButtonAction="backButtonAction" - class="Header" + @click-event="backButtonAction" + class="Header" /> @@ -67,7 +67,7 @@ export default { }, methods: { - backButtonAction: function () { + backButtonAction() { // route to move backwards this.$router.navigate(this.navigationScenarios.CLICKED_BACK, this.$route); } diff --git a/src/layouts/vehicle-model/vehicle-model.vue b/src/layouts/vehicle-model/vehicle-model.vue index bac05f3bc..163915ec0 100644 --- a/src/layouts/vehicle-model/vehicle-model.vue +++ b/src/layouts/vehicle-model/vehicle-model.vue @@ -8,7 +8,7 @@ :text="funnelSubHeaderWidget.HeaderText" :hasBackButton="true" backButtonAccessibleText="Change Vehicle Make" - :backButtonAction="backButtonAction" + @click-event="backButtonAction" class="Header" /> @@ -67,7 +67,7 @@ export default { }, methods: { - backButtonAction: function () { + backButtonAction() { // route to move backwards this.$router.navigate(this.navigationScenarios.CLICKED_BACK, this.$route); } diff --git a/src/layouts/vehicle-style/vehicle-style.vue b/src/layouts/vehicle-style/vehicle-style.vue index 22b8b29b1..ecb362663 100644 --- a/src/layouts/vehicle-style/vehicle-style.vue +++ b/src/layouts/vehicle-style/vehicle-style.vue @@ -8,7 +8,7 @@ :text="funnelSubHeaderWidget.HeaderText" :hasBackButton="true" backButtonAccessibleText="Change Vehicle Model" - :backButtonAction="backButtonAction" + @click-event="backButtonAction" class="Header" /> @@ -67,7 +67,7 @@ export default { }, methods: { - backButtonAction: function () { + backButtonAction() { // route to move backwards this.$router.navigate(this.navigationScenarios.CLICKED_BACK, this.$route); } diff --git a/src/ux-components/button-back/button-back.vue b/src/ux-components/button-back/button-back.vue index 55dee6f8f..23d5dd2f8 100644 --- a/src/ux-components/button-back/button-back.vue +++ b/src/ux-components/button-back/button-back.vue @@ -1,7 +1,6 @@