Merge pull request #2332 from Safelite/feature/add-prettier-test-to-PR-check

Add prettier test back to PR check list
This commit is contained in:
scottkiener 2025-02-25 16:17:57 -05:00 committed by GitHub
commit 914c187086
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 21 additions and 15 deletions

View file

@ -22,7 +22,8 @@ resources:
- container: awscli - container: awscli
image: packagerepository.sagaws.net:8082/safelite/awscli2-build:3.9 image: packagerepository.sagaws.net:8082/safelite/awscli2-build:3.9
- container: prettier-node - container: prettier-node
image: packagerepository.sagaws.net:8082/safelite/prettier-node-build:23 image: ghcr.io/safelite/prettier-node-build:23
endpoint: GitHub Docker
repositories: repositories:
- repository: AzureDevOps - repository: AzureDevOps
type: github type: github
@ -37,15 +38,15 @@ variables:
stages: stages:
# PR's # PR's
- ${{ if eq(variables['Build.Reason'], 'PullRequest') }}: - ${{ if eq(variables['Build.Reason'], 'PullRequest') }}:
# - stage: TestFormat - stage: TestFormat
# displayName: Test Code Format displayName: Test Code Format
# jobs: jobs:
# - job: checkFormatting - job: checkFormatting
# displayName: Check formatting displayName: Check formatting
# container: prettier-node container: prettier-node
# steps: steps:
# - bash: prettier --check "$(Build.SourcesDirectory)/src/**/*.(js|vue)" - bash: prettier --check "$(Build.SourcesDirectory)/src/**/*.(js|vue)"
# displayName: Run Prettier check displayName: Run Prettier check
- stage: TestPr - stage: TestPr
displayName: Run Unit Tests For PullRequest displayName: Run Unit Tests For PullRequest

View file

@ -521,7 +521,12 @@ export default {
this.$router.navigateWithSaving(this.navigationScenarios.CLICKED_FORWARD, this.$route); this.$router.navigateWithSaving(this.navigationScenarios.CLICKED_FORWARD, this.$route);
}, },
setDisplayWaitList() { setDisplayWaitList() {
if(experimentMixin.methods.hasSettingEqualTo(experimentSettings.DISPLAY_WAITLIST, "true")){ if (
experimentMixin.methods.hasSettingEqualTo(
experimentSettings.DISPLAY_WAITLIST,
"true"
)
) {
const dateString = this.selectableDatesData.days[0].date; const dateString = this.selectableDatesData.days[0].date;
const [year, month, day] = dateString.split("-").map(Number); const [year, month, day] = dateString.split("-").map(Number);
const targetDate = new Date(year, month - 1, day); const targetDate = new Date(year, month - 1, day);
@ -531,10 +536,10 @@ export default {
experimentSettings.WAITLIST_THRESHOLD_DAYS experimentSettings.WAITLIST_THRESHOLD_DAYS
) )
? parseInt( ? parseInt(
experimentMixin.methods.getSettingValue( experimentMixin.methods.getSettingValue(
experimentSettings.WAITLIST_THRESHOLD_DAYS experimentSettings.WAITLIST_THRESHOLD_DAYS
) )
) )
: 0; : 0;
futureDate.setDate(currentDate.getDate() + experimentThresholdDays); futureDate.setDate(currentDate.getDate() + experimentThresholdDays);