Merge pull request #1840 from Safelite/feature/CSR-1742-ajc

CSR-1742: refactoring logic out of markup
This commit is contained in:
AdamCaouetteSafelite 2024-05-03 10:51:37 -04:00 committed by GitHub
commit 8a5624fd2d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -11,9 +11,7 @@
class="col d-flex justify-content-between py-0"> class="col d-flex justify-content-between py-0">
<span class="label">{{ amountDueText }}</span> <span class="label">{{ amountDueText }}</span>
<span class="label amount-due">{{ <span class="label amount-due">{{
showCoverageAsPending getLineItemAmount(amountDue, showCoverageAsPending)
? verifyingCoverageText
: getFormattedAmount("", amountDue)
}}</span> }}</span>
</a> </a>
</div> </div>
@ -24,9 +22,10 @@
<textBlock cmsWidgetName="DeductibleTextWidget" /> <textBlock cmsWidgetName="DeductibleTextWidget" />
<span> <span>
{{ {{
showCoverageAsPending getLineItemAmount(
? verifyingCoverageText deductibleLineItem.subTotal,
: getFormattedAmount("", deductibleLineItem.subTotal) showCoverageAsPending
)
}} }}
</span> </span>
</div> </div>
@ -35,12 +34,12 @@
<div class="service-type"> <div class="service-type">
<textBlock :cmsWidgetName="servicePackageTitleWidget" /> <textBlock :cmsWidgetName="servicePackageTitleWidget" />
<span> <span>
{{ getFormattedAmount("", packagePrice) }} {{ getLineItemAmount(packagePrice) }}
</span> </span>
<span <span
v-if="packagePriceWithoutDiscount > packagePrice" v-if="packagePriceWithoutDiscount > packagePrice"
class="struck-out-price"> class="struck-out-price">
{{ getFormattedAmount("", packagePriceWithoutDiscount) }} {{ getLineItemAmount(packagePriceWithoutDiscount) }}
</span> </span>
</div> </div>
@ -100,34 +99,28 @@
!showCoverageAsVerified || !showCoverageAsVerified ||
(showCoverageAsVerified && !cartItem.isCoveredByInsurance) (showCoverageAsVerified && !cartItem.isCoveredByInsurance)
" "
>{{ getFormattedAmount(cartItem.category, cartItem.subTotal) }}</span >{{
getLineItemAmount(cartItem.subTotal, null, cartItem.category)
}}</span
> >
</div> </div>
<!-- Sub total, sales tax, total columns --> <!-- Sub total, sales tax, total columns -->
<div class="sub-total"> <div class="sub-total">
<span>{{ subtotalText }}</span> <span>{{ subtotalText }}</span>
<span>{{ <span>{{ getLineItemAmount(subTotal, showCoverageAsPending) }}</span>
showCoverageAsPending
? verifyingCoverageText
: getFormattedAmount("", subTotal)
}}</span>
</div> </div>
<div class="sales-tax"> <div class="sales-tax">
<span>{{ salesTaxText }}</span> <span>{{ salesTaxText }}</span>
<span>{{ getFormattedAmount("", salesTax) }}</span> <span>{{ getLineItemAmount(salesTax) }}</span>
</div> </div>
<div v-if="showAsPaid" class="amount-paid"> <div v-if="showAsPaid" class="amount-paid">
<span>{{ amountPaidText }}</span <span>{{ amountPaidText }}</span>
><span>{{ getFormattedAmount("", amountPaid) }}</span> <span>{{ getLineItemAmount(amountPaid) }}</span>
</div> </div>
<div class="amount-due"> <div class="amount-due">
<span>{{ amountDueText }}</span> <span>{{ amountDueText }}</span>
<span>{{ <span>{{ getLineItemAmount(amountDue, showCoverageAsPending) }}</span>
showCoverageAsPending
? verifyingCoverageText
: getFormattedAmount("", amountDue)
}}</span>
</div> </div>
</div> </div>
<div <div
@ -269,11 +262,14 @@ export default {
return vapsTypeName.Text; return vapsTypeName.Text;
}, },
getFormattedAmount(category, amount) {
getLineItemAmount(amount, useVerifyingText, category) {
if (useVerifyingText) return this.verifyingCoverageText;
return category == "promos" return category == "promos"
? "(" + this.currencyFormatter.format(amount * -1) + ")" ? "(" + this.currencyFormatter.format(amount * -1) + ")"
: this.currencyFormatter.format(amount); : this.currencyFormatter.format(amount);
}, },
removeItem(cartItemType, category) { removeItem(cartItemType, category) {
this.lineItems[category] = this.lineItems[category].filter( this.lineItems[category] = this.lineItems[category].filter(
(lineItemsToKeep) => lineItemsToKeep.cartItemType != cartItemType (lineItemsToKeep) => lineItemsToKeep.cartItemType != cartItemType