From 2160a158000d61253eabd50e2502acbbb47a47d0 Mon Sep 17 00:00:00 2001
From: bmauger <mauger.bryan@gmail.com>
Date: Mon, 6 Jun 2022 15:58:44 -0400
Subject: [PATCH 1/2] CSR-668 clean up code per Mark's request.

---
 .../funnel-header/menu-modal/menu-modal.vue   | 23 ++++++++++---------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/src/common-components/funnel-header/menu-modal/menu-modal.vue b/src/common-components/funnel-header/menu-modal/menu-modal.vue
index 7017947e8..5f2a97327 100644
--- a/src/common-components/funnel-header/menu-modal/menu-modal.vue
+++ b/src/common-components/funnel-header/menu-modal/menu-modal.vue
@@ -7,7 +7,7 @@
     </button>
   </div>
   <!-- Modal -->
-  <div class="modal fade" id="footerModal" tabindex="-1" aria-labelledby="footerModalLabel" aria-hidden="true" :style="`height: calc(100% - ${currentFooterAndHeaderHeight}px);`">
+  <div class="modal fade" id="footerModal" tabindex="-1" aria-labelledby="footerModalLabel" aria-hidden="true" v-on="{ 'show.bs.modal' : show, 'hide.bs.modal' : hide }" :style="`height: calc(100% - ${currentFooterAndHeaderHeight}px);`">
     <div class="modal-dialog modal-fullscreen">
       <div class="modal-content">
         <div class="modal-header visually-hidden">
@@ -36,19 +36,20 @@ export default {
       currentFooterAndHeaderHeight: 0,
     };
   },
-  mounted() {
-    const myModalEl = document.getElementById('footerModal');
-    var self = this;
-    myModalEl.addEventListener('hide.bs.modal', function (event) {
-      self.isActive = false;
-    });
-    myModalEl.addEventListener('show.bs.modal', function (event) {
-      self.currentFooterAndHeaderHeight = self.getFooterInfoBoxHeight() + 72;
-      self.isActive = true;
+  methods: {
+    show() {
+      const myModalEl = document.getElementById('footerModal');
+      this.currentFooterAndHeaderHeight = this.getFooterInfoBoxHeight() + 72;
+      this.isActive = true;
       document.querySelector('.page-container-grouped-styles').scrollTo({
         top: 0,  behavior: 'smooth'
       });
-    })
+    },
+    hide() {
+      const myModalEl = document.getElementById('footerModal');
+      var self = this;
+      self.isActive = false;
+    },
   },
   components: {
     textLink,

From 256e2e88bad2a8b0a051d2da75c1d5cf8c7ca6ec Mon Sep 17 00:00:00 2001
From: bmauger <mauger.bryan@gmail.com>
Date: Tue, 7 Jun 2022 08:10:27 -0400
Subject: [PATCH 2/2] Remove unneeded code.

---
 src/common-components/funnel-header/menu-modal/menu-modal.vue | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/common-components/funnel-header/menu-modal/menu-modal.vue b/src/common-components/funnel-header/menu-modal/menu-modal.vue
index 5f2a97327..c980036e9 100644
--- a/src/common-components/funnel-header/menu-modal/menu-modal.vue
+++ b/src/common-components/funnel-header/menu-modal/menu-modal.vue
@@ -38,7 +38,6 @@ export default {
   },
   methods: {
     show() {
-      const myModalEl = document.getElementById('footerModal');
       this.currentFooterAndHeaderHeight = this.getFooterInfoBoxHeight() + 72;
       this.isActive = true;
       document.querySelector('.page-container-grouped-styles').scrollTo({
@@ -46,7 +45,6 @@ export default {
       });
     },
     hide() {
-      const myModalEl = document.getElementById('footerModal');
       var self = this;
       self.isActive = false;
     },