Merge pull request #2053 from Safelite/feature/CSR-2249

Tech review changes

src/helpers/service-package-helper.js

@@ -239,6 +239,15 @@ export function getPackageNameByType(packageType) {
     return package_names[packageType] || null;
 }
 
+export function getDiscountPackageName(discountPackage) {
+    const package_names = {
+        ECON: packageNames.TIER_ONE,
+        STANDARD: packageNames.TIER_TWO,
+        PREMIUM: packageNames.TIER_THREE,
+    };
+    return package_names[discountPackage] || null;
+}
+
 function maxTier(tierA, tierB) {
     if (tierA === packageNames.TIER_THREE || tierB === packageNames.TIER_THREE) {
         return packageNames.TIER_THREE;

src/layouts/quote/service-package-question/service-package-question.vue

@@ -28,6 +28,7 @@ import {
     containsLineItemWithPartType,
     findLineItemsWithPartType,
     getPackageNameByType,
+    getDiscountPackageName,
 } from "@/helpers/service-package-helper";
 import {
     getPromosThatMatchLineItemsOnOrder,
@@ -161,16 +162,7 @@ export default {
             const discountServicePackage = experimentMixin.methods.getSettingValue(
                 experimentSettings.PROMO_ON_PACKAGE
             );
-            switch (discountServicePackage) {
+            return getDiscountPackageName(discountServicePackage);
-                case "ECON":
-                    return packageNames.TIER_ONE;
-                case "STANDARD":
-                    return packageNames.TIER_TWO;
-                case "PREMIUM":
-                    return packageNames.TIER_THREE;
-                default:
-                    return null;
-            }
         },
         frontWipersApplicableForTierTwo() {
             return shouldFrontWipersBeAvailable(