jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #2053 from Safelite/feature/CSR-2249

Browse source 
Tech review changes
This commit is contained in:
AMSNEHA 2024-10-29 19:28:29 +05:30 committed by GitHub
commit 814b8c9248
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/helpers/service-package-helper.js
View file

@ -239,6 +239,15 @@ export function getPackageNameByType(packageType) {
return package_names[packageType] || null;
}
export function getDiscountPackageName(discountPackage) {
const package_names = {
ECON: packageNames.TIER_ONE,
STANDARD: packageNames.TIER_TWO,
PREMIUM: packageNames.TIER_THREE,
};
return package_names[discountPackage] || null;
}
function maxTier(tierA, tierB) {
if (tierA === packageNames.TIER_THREE || tierB === packageNames.TIER_THREE) {
return packageNames.TIER_THREE;

12
src/layouts/quote/service-package-question/service-package-question.vue
View file

@ -28,6 +28,7 @@ import {
containsLineItemWithPartType,
findLineItemsWithPartType,
getPackageNameByType,
getDiscountPackageName,
} from "@/helpers/service-package-helper";
import {
getPromosThatMatchLineItemsOnOrder,
@ -161,16 +162,7 @@ export default {
const discountServicePackage = experimentMixin.methods.getSettingValue(
experimentSettings.PROMO_ON_PACKAGE
);
switch (discountServicePackage) {
case "ECON":
return packageNames.TIER_ONE;
case "STANDARD":
return packageNames.TIER_TWO;
case "PREMIUM":
return packageNames.TIER_THREE;
default:
return null;
}
return getDiscountPackageName(discountServicePackage);
},
frontWipersApplicableForTierTwo() {
return shouldFrontWipersBeAvailable(