jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1694 from Safelite/rlsmerge/2024.01.19-to-develop

Browse source 
Rlsmerge/2024.01.19 to develop
This commit is contained in:
chloeherdsafelite 2024-01-18 16:28:18 -05:00 committed by GitHub
commit 7fa9b7b0e4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/router/index.js
View file

@ -9,7 +9,7 @@ import { queryStrings } from "@/constants/query-strings";
import { getQuerystringParameter } from "@/helpers/querystring-helper";
import { getDeviceIdValue } from "@/helpers/heritage-integration/cookie-helper";
import { showFmgLoadingModal } from "@/helpers/loading-modal-helper";
import { fmgPageValues, homepageName } from "@/router/router-constants/fmgPage-values";
import { fmgPageValues, funnelStartPageName } from "@/router/router-constants/fmgPage-values";
// Heritage integration
import { isSavedSessionStillActive } from "@/helpers/heritage-integration/session-helper";
@ -17,6 +17,7 @@ import {
updateOrCreateFunnelCookie,
getFunnelCookie,
updateSessionIdCookie,
deleteFunnelCookie,
} from "@/helpers/heritage-integration/cookie-helper";
import { loadSessionIfPresent, saveSession } from "@/helpers/heritage-integration/order-helper";
import {
@ -54,7 +55,7 @@ const routes = [
// Intercept all navigation if a submitted order exists in storage
if (store.getters.hasSubmittedOrder) {
if (to.query.fmgPage !== homepageName) {
if (to.query.fmgPage !== funnelStartPageName) {
to.query.fmgPage = fmgPageValues.CONFIRMATION;
}
}
@ -141,6 +142,11 @@ const routes = [
} catch (error) {
console.log(error);
if (to.query?.fmgPage === funnelStartPageName) {
deleteFunnelCookie();
await baseMixin.methods.dispatchStoreAction(storeActions.RESET_STATE);
}
// If we don't have a route, go to our 404 page.
GoToFunnelStartOn404(next);
}
@ -185,7 +191,7 @@ router.beforeEach(async (to, from, next) => {
// Refresh page if navigating to self to prevent locking.
// For now only carved out for vehicle; all modals are opened through anchor tags at the moment,
// which also self navigate, but relied on the page remaining the same on self-navigation.
} else if (toQueryPage === fromQueryPage && toQueryPage === homepageName) {
} else if (toQueryPage === fromQueryPage && toQueryPage === funnelStartPageName) {
router.go(0);
} else {
next();
@ -403,7 +409,7 @@ function GoToFunnelStartOn404(next) {
next({
path: "/",
query: { fmgPage: homepageName },
query: { fmgPage: funnelStartPageName },
});
}

4
src/router/router-constants/fmgPage-values.js
View file

@ -21,6 +21,6 @@ const fmgPageValues = {
CONFIRMATION: "confirmation",
};
const homepageName = fmgPageValues.VEHICLE;
const funnelStartPageName = fmgPageValues.VEHICLE;
export { fmgPageValues, homepageName };
export { fmgPageValues, funnelStartPageName };