From 82924a69b977b3a5096807131526bd250d2a769d Mon Sep 17 00:00:00 2001 From: Adam Caouette Date: Wed, 22 Dec 2021 16:48:39 -0500 Subject: [PATCH 1/6] CSR-174: restore aria-label prop to back button --- src/common-components/funnel-sub-header/funnel-sub-header.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/src/common-components/funnel-sub-header/funnel-sub-header.vue b/src/common-components/funnel-sub-header/funnel-sub-header.vue index 444674440..630dd9cbe 100644 --- a/src/common-components/funnel-sub-header/funnel-sub-header.vue +++ b/src/common-components/funnel-sub-header/funnel-sub-header.vue @@ -8,6 +8,7 @@ From c5ceb36cfd040c342cc94c61b4dbaf5dc70b3aef Mon Sep 17 00:00:00 2001 From: Adam Caouette Date: Tue, 28 Dec 2021 09:50:58 -0500 Subject: [PATCH 2/6] CSR-174: remove no longer needed prop --- src/common-components/funnel-sub-header/funnel-sub-header.vue | 1 - src/layouts/component-test/component-test.vue | 1 - 2 files changed, 2 deletions(-) diff --git a/src/common-components/funnel-sub-header/funnel-sub-header.vue b/src/common-components/funnel-sub-header/funnel-sub-header.vue index 630dd9cbe..81c741647 100644 --- a/src/common-components/funnel-sub-header/funnel-sub-header.vue +++ b/src/common-components/funnel-sub-header/funnel-sub-header.vue @@ -23,7 +23,6 @@ export default { props: { text: String, hasBackButton: Boolean, - backButtonUrl: String, backButtonAccessibleText: String, backButtonAction: Function, }, diff --git a/src/layouts/component-test/component-test.vue b/src/layouts/component-test/component-test.vue index 6c3af4720..e0ef3ecca 100644 --- a/src/layouts/component-test/component-test.vue +++ b/src/layouts/component-test/component-test.vue @@ -40,7 +40,6 @@
From acb3481e01c559fa0e2af541882936a79491b650 Mon Sep 17 00:00:00 2001 From: Adam Caouette Date: Thu, 30 Dec 2021 13:22:56 -0500 Subject: [PATCH 3/6] CSR-174: add aria-hidden=true to list-button label elements to fix jaws bug --- .../list-button-horizontal/list-button-horizontal.vue | 4 ++-- src/ux-components/list-button/list-button.vue | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ux-components/list-button-horizontal/list-button-horizontal.vue b/src/ux-components/list-button-horizontal/list-button-horizontal.vue index 5df8261ec..88fbf491e 100644 --- a/src/ux-components/list-button-horizontal/list-button-horizontal.vue +++ b/src/ux-components/list-button-horizontal/list-button-horizontal.vue @@ -3,7 +3,7 @@
-
-
@@ -271,7 +271,7 @@ loaderColor="blue" loaderPosition="right" sizeInRem="1" - screenReaderOnlyText="(opens new window)" + screenReaderOnlyText=" opens new window" /> @@ -318,7 +318,7 @@ loaderColor="blue" loaderPosition="right" sizeInRem="1" - screenReaderOnlyText="(opens new window)" + screenReaderOnlyText=" opens new window" /> @@ -361,7 +361,7 @@ loaderColor="blue" loaderPosition="right" sizeInRem="1" - screenReaderOnlyText="(opens new window)" + screenReaderOnlyText=" opens new window" /> @@ -408,7 +408,7 @@ loaderColor="blue" loaderPosition="right" sizeInRem="1" - screenReaderOnlyText="(opens new window)" + screenReaderOnlyText=" opens new window" /> @@ -451,7 +451,7 @@ loaderColor="blue" loaderPosition="right" sizeInRem="1" - screenReaderOnlyText="(opens new window)" + screenReaderOnlyText=" opens new window" /> @@ -502,7 +502,7 @@ sizeInRem="1" v-bind:totalInGroup="3" v-bind:positionInGroup="1" - screenReaderOnlyText="(opens new window)" + screenReaderOnlyText=" opens new window" /> @@ -553,7 +553,7 @@ sizeInRem="1" v-bind:totalInGroup="3" v-bind:positionInGroup="1" - screenReaderOnlyText="(opens new window)" + screenReaderOnlyText=" opens new window" /> From 4b3d8ba33140d1ada766d62e34b84083159c049d Mon Sep 17 00:00:00 2001 From: Adam Caouette Date: Thu, 30 Dec 2021 16:32:51 -0500 Subject: [PATCH 5/6] CSR-174: remove aria-hidden / add additional aria-describedby instead --- .../list-button-horizontal/list-button-horizontal.vue | 4 ++-- src/ux-components/list-button/list-button.vue | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ux-components/list-button-horizontal/list-button-horizontal.vue b/src/ux-components/list-button-horizontal/list-button-horizontal.vue index 88fbf491e..7721917c2 100644 --- a/src/ux-components/list-button-horizontal/list-button-horizontal.vue +++ b/src/ux-components/list-button-horizontal/list-button-horizontal.vue @@ -3,7 +3,7 @@
-
-