From 4aeef51834ca62680f5392131d662567e29ba57f Mon Sep 17 00:00:00 2001 From: Mark Harris Date: Mon, 13 Dec 2021 12:27:33 -0500 Subject: [PATCH 01/86] renamed some variables --- src/layouts/vehicle-year/vehicle-year.vue | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/layouts/vehicle-year/vehicle-year.vue b/src/layouts/vehicle-year/vehicle-year.vue index 4da235fcc..7e2bad0c4 100644 --- a/src/layouts/vehicle-year/vehicle-year.vue +++ b/src/layouts/vehicle-year/vehicle-year.vue @@ -37,14 +37,14 @@ export default { beforeRouteEnter(to, from, next) { // Call APIs - const contentPromise = fetchCmsContentForPage(to.query.fmgPage); + const cmsContentPromise = fetchCmsContentForPage(to.query.fmgPage); const getVehicleYearPromise = store.dispatch(storeActions.GET_VEHICLE_YEARS, {}); // Settle promises and get results const promiseResultMap = [ { - resultKey: "getPageContent", - promise: contentPromise, + resultKey: "cmsContent", + promise: cmsContentPromise, }, { resultKey: "getVehicleYear", @@ -55,10 +55,10 @@ export default { // Call the "next" function to complete the transition to this page. next((vm) => { - vm.pageHeaderWidgets = resultMap.getPageContent.PageHeaderWidget[0]; - vm.siteHeaderWidget = resultMap.getPageContent.SiteHeaderWidget[0]; - vm.radioQuestionWidgets = resultMap.getPageContent.RadioQuestionWidget[0]; - vm.vehicleBannerWidget = resultMap.getPageContent.VehicleBannerWidget[0]; + vm.pageHeaderWidgets = resultMap.cmsContent.PageHeaderWidget[0]; + vm.siteHeaderWidget = resultMap.cmsContent.SiteHeaderWidget[0]; + vm.radioQuestionWidgets = resultMap.cmsContent.RadioQuestionWidget[0]; + vm.vehicleBannerWidget = resultMap.cmsContent.VehicleBannerWidget[0]; vm.vehicleYears = resultMap.getVehicleYear; }); }); From 8b48ec6d11a41f1ff549b5a75e73515faa906273 Mon Sep 17 00:00:00 2001 From: Mark Harris Date: Mon, 13 Dec 2021 12:30:01 -0500 Subject: [PATCH 02/86] renamed some variables --- src/layouts/vehicle-year/vehicle-year.vue | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/layouts/vehicle-year/vehicle-year.vue b/src/layouts/vehicle-year/vehicle-year.vue index 7e2bad0c4..8cf5e9c04 100644 --- a/src/layouts/vehicle-year/vehicle-year.vue +++ b/src/layouts/vehicle-year/vehicle-year.vue @@ -38,7 +38,7 @@ export default { // Call APIs const cmsContentPromise = fetchCmsContentForPage(to.query.fmgPage); - const getVehicleYearPromise = store.dispatch(storeActions.GET_VEHICLE_YEARS, {}); + const yearQuestionInitialDataPromise = store.dispatch(storeActions.GET_VEHICLE_YEARS, {}); // Settle promises and get results const promiseResultMap = [ @@ -47,8 +47,8 @@ export default { promise: cmsContentPromise, }, { - resultKey: "getVehicleYear", - promise: getVehicleYearPromise, + resultKey: "yearQuestionInitialData", + promise: yearQuestionInitialDataPromise, }, ]; settleAllPromises(promiseResultMap).then((resultMap) => { @@ -59,7 +59,7 @@ export default { vm.siteHeaderWidget = resultMap.cmsContent.SiteHeaderWidget[0]; vm.radioQuestionWidgets = resultMap.cmsContent.RadioQuestionWidget[0]; vm.vehicleBannerWidget = resultMap.cmsContent.VehicleBannerWidget[0]; - vm.vehicleYears = resultMap.getVehicleYear; + vm.vehicleYears = resultMap.yearQuestionInitialData; }); }); }, From 06dbf642c909cb486e24b4f94f1c0c37603995a4 Mon Sep 17 00:00:00 2001 From: Mark Harris Date: Mon, 13 Dec 2021 12:33:50 -0500 Subject: [PATCH 03/86] encapsulated api, widget parsing into component --- src/layouts/vehicle-year/vehicle-year.vue | 11 +++-------- .../year-question/year-question.vue | 17 ++++++++++++++--- 2 files changed, 17 insertions(+), 11 deletions(-) diff --git a/src/layouts/vehicle-year/vehicle-year.vue b/src/layouts/vehicle-year/vehicle-year.vue index 8cf5e9c04..13bf9f9fe 100644 --- a/src/layouts/vehicle-year/vehicle-year.vue +++ b/src/layouts/vehicle-year/vehicle-year.vue @@ -4,7 +4,7 @@
- +
@@ -18,15 +18,11 @@ import vehicleBanner from "@/common-components/vehicle-banner/vehicle-banner"; // Supporting files import { fetchCmsContentForPage } from "@/helpers/cms-content-helper"; import { settleAllPromises } from "@/helpers/layout-helper"; -import store from "@/store"; -import { storeActions } from "@/constants/store-actions.js"; export default { name: "vehicle-year", data() { return { pageHeaderWidgets: {}, - radioQuestionWidgets: {}, - vehicleYears: [], siteHeaderWidget: {}, vehicleBannerWidget: {}, selectedYear: null @@ -38,7 +34,7 @@ export default { // Call APIs const cmsContentPromise = fetchCmsContentForPage(to.query.fmgPage); - const yearQuestionInitialDataPromise = store.dispatch(storeActions.GET_VEHICLE_YEARS, {}); + const yearQuestionInitialDataPromise = yearQuestion.methods.loadInitialData(); // Settle promises and get results const promiseResultMap = [ @@ -57,9 +53,8 @@ export default { next((vm) => { vm.pageHeaderWidgets = resultMap.cmsContent.PageHeaderWidget[0]; vm.siteHeaderWidget = resultMap.cmsContent.SiteHeaderWidget[0]; - vm.radioQuestionWidgets = resultMap.cmsContent.RadioQuestionWidget[0]; vm.vehicleBannerWidget = resultMap.cmsContent.VehicleBannerWidget[0]; - vm.vehicleYears = resultMap.yearQuestionInitialData; + vm.$refs.yearQuestion.initializeComponent(resultMap.cmsContent.RadioQuestionWidget[0], resultMap.yearQuestionInitialData); }); }); }, diff --git a/src/layouts/vehicle-year/year-question/year-question.vue b/src/layouts/vehicle-year/year-question/year-question.vue index 4c5bb8d30..ceb6ea9a3 100644 --- a/src/layouts/vehicle-year/year-question/year-question.vue +++ b/src/layouts/vehicle-year/year-question/year-question.vue @@ -8,22 +8,33 @@ diff --git a/src/layouts/component-test/component-test.vue b/src/layouts/component-test/component-test.vue index 4a5d91bd2..9729477d1 100644 --- a/src/layouts/component-test/component-test.vue +++ b/src/layouts/component-test/component-test.vue @@ -55,22 +55,6 @@ -
-
-

List Button

-
-
-
-
- -
-

Radio - Single-Line

@@ -87,7 +71,7 @@

Select Vehicle Year

- - - Select Vehicle Year - - - Multi-Line Centered - - - { // Assert const radioQuestion = await wrapper.findComponent({ - name: "radioQuestion", + name: "buttonQuestion", }); expect(radioQuestion.attributes("questiontext")).toBe( "What year is your vehicle?" diff --git a/src/layouts/vehicle-year/year-question/year-question.vue b/src/layouts/vehicle-year/year-question/year-question.vue index 3b7811713..57c84aeac 100644 --- a/src/layouts/vehicle-year/year-question/year-question.vue +++ b/src/layouts/vehicle-year/year-question/year-question.vue @@ -1,5 +1,5 @@