From 53332003957b480775274f2c198f260cef8d1e4c Mon Sep 17 00:00:00 2001 From: CarlNation <32103961+CarlNation@users.noreply.github.com> Date: Wed, 20 Mar 2024 09:05:09 -0400 Subject: [PATCH 1/2] CSR-2035 CSR-2035 The fees get removed on insurance orders causing the findindex on supportingitems to throw a script error. --- src/helpers/heritage-integration/navigation-helper.js | 5 ----- src/layouts/service-location/service-location.vue | 6 ++++++ 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/helpers/heritage-integration/navigation-helper.js b/src/helpers/heritage-integration/navigation-helper.js index e58dc0a3a..6da22c37c 100644 --- a/src/helpers/heritage-integration/navigation-helper.js +++ b/src/helpers/heritage-integration/navigation-helper.js @@ -129,11 +129,6 @@ export async function navigateToHeritageFunnel({ shouldSaveSession, pageNameToLo heritageParms["forceEndToEndInsurance"] = true; } - // if they are going to heritage and already have a policy number then this is a nav back flow - if (store.getters.policy.policyNumber) { - heritageParms["insuranceNavBack"] = true; - } - router.navigateToExternalUrl(externalUrls.HERITAGE_FUNNEL, heritageParms); } diff --git a/src/layouts/service-location/service-location.vue b/src/layouts/service-location/service-location.vue index 76fd20c5d..4b4be315a 100644 --- a/src/layouts/service-location/service-location.vue +++ b/src/layouts/service-location/service-location.vue @@ -458,6 +458,12 @@ export default { }, updateAndSaveSupportingItems() { const supportingItems = store.getters.lineItems.supportingItems; + + // for insurance orders, fees can get removed causing supportingitems to be null or empty + if (!supportingItems){ + return; + } + // if we have a mobile fee, then save/update supporting items if (this.selectedAppointmentType == "Mobile") { const mobileFeeIndex = supportingItems.findIndex( From 32cef6a21845850ee6f7933fe249cb58ad5efdb7 Mon Sep 17 00:00:00 2001 From: CarlNation Date: Wed, 20 Mar 2024 09:11:39 -0400 Subject: [PATCH 2/2] CSR-2035 csr-2035 PRETTIER --- src/layouts/service-location/service-location.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/layouts/service-location/service-location.vue b/src/layouts/service-location/service-location.vue index 4b4be315a..89b3320fd 100644 --- a/src/layouts/service-location/service-location.vue +++ b/src/layouts/service-location/service-location.vue @@ -460,7 +460,7 @@ export default { const supportingItems = store.getters.lineItems.supportingItems; // for insurance orders, fees can get removed causing supportingitems to be null or empty - if (!supportingItems){ + if (!supportingItems) { return; }