From c7aabc80dd1989971ef25329c704c63c919263f8 Mon Sep 17 00:00:00 2001 From: Matt Caimi Date: Thu, 10 Apr 2025 14:12:56 -0400 Subject: [PATCH 01/11] CASH-500 lowering the z-index for this element ends persistent rendering --- .../list-button-horizontal/list-button-horizontal.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ux-components/list-button-horizontal/list-button-horizontal.vue b/src/ux-components/list-button-horizontal/list-button-horizontal.vue index 4b66023e0..72f7c53e0 100644 --- a/src/ux-components/list-button-horizontal/list-button-horizontal.vue +++ b/src/ux-components/list-button-horizontal/list-button-horizontal.vue @@ -136,7 +136,7 @@ export default { color: $white; background: linear-gradient(84.45deg, #125b7e 0%, #3b8fb8 100%); border-radius: 0.5rem; - z-index: 5; + z-index: 2; } &:checked:focus + .list-button-horizontal-content { From 07c0a0634af6361055dc58a8bcb73cc8bd225219 Mon Sep 17 00:00:00 2001 From: Minojhini Valaiyapathi Date: Fri, 11 Apr 2025 12:02:53 -0400 Subject: [PATCH 02/11] CASH-498 - created custom secondary button just for donation block --- src/experiment-components/donation-block.vue | 3 ++- src/ux-components/button-main/button-main.vue | 14 +++++++++++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/experiment-components/donation-block.vue b/src/experiment-components/donation-block.vue index ae6c69a93..27ce67918 100644 --- a/src/experiment-components/donation-block.vue +++ b/src/experiment-components/donation-block.vue @@ -55,7 +55,8 @@ diff --git a/src/ux-components/button-main/button-main.vue b/src/ux-components/button-main/button-main.vue index 982e7bb1b..fcf78e19b 100644 --- a/src/ux-components/button-main/button-main.vue +++ b/src/ux-components/button-main/button-main.vue @@ -3,7 +3,11 @@ :aria-disabled="isDisabled" class="btn d-flex align-items-center justify-content-center py-3 px-4 delay" :class="[ - isPrimary ? 'btn-primary' : 'btn-secondary', + customSecondary + ? 'btn-secondary custom-secondary' + : isPrimary + ? 'btn-primary' + : 'btn-secondary', isFloat ? 'float-end' : '', isLoaderDisplayed && !suppressLoader ? 'has-loader' : '', ]" @@ -29,6 +33,7 @@ export default { loaderPosition: String, isFloat: Boolean, suppressLoader: Boolean, + customSecondary: Boolean, // New property to check if it comes from donationBlock }, data() { return { @@ -156,6 +161,13 @@ export default { transition: background 0s 0s ease-in-out; } } + &.custom-secondary { + &:hover { + color: $blue !important; + background: transparent !important; + border: 1px solid $blue; + } + } &.btn-success { position: relative; background: $green-100; From 1cb59b1adce9c9f1202752facb65236530edaa80 Mon Sep 17 00:00:00 2001 From: Minojhini Valaiyapathi Date: Mon, 14 Apr 2025 09:16:05 -0400 Subject: [PATCH 03/11] CASH-498 - Code review updates --- src/experiment-components/donation-block.vue | 10 ++++++++-- src/ux-components/button-main/button-main.vue | 14 +------------- 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/src/experiment-components/donation-block.vue b/src/experiment-components/donation-block.vue index 27ce67918..30fe9f8ed 100644 --- a/src/experiment-components/donation-block.vue +++ b/src/experiment-components/donation-block.vue @@ -56,8 +56,7 @@ ref="buttonMain" :buttonText="DonationAddButtonCopy" loaderColor="blue" - customSecondary="true" - class="w-100 mb-2" + class="w-100 mb-2 custom-secondary" @click-event="handleDonationAction" /> @@ -292,5 +291,12 @@ export default { left: -0.25rem; } } + .custom-secondary { + &:hover { + color: $blue; + background: transparent; + border: 1px solid $blue; + } + } } diff --git a/src/ux-components/button-main/button-main.vue b/src/ux-components/button-main/button-main.vue index fcf78e19b..982e7bb1b 100644 --- a/src/ux-components/button-main/button-main.vue +++ b/src/ux-components/button-main/button-main.vue @@ -3,11 +3,7 @@ :aria-disabled="isDisabled" class="btn d-flex align-items-center justify-content-center py-3 px-4 delay" :class="[ - customSecondary - ? 'btn-secondary custom-secondary' - : isPrimary - ? 'btn-primary' - : 'btn-secondary', + isPrimary ? 'btn-primary' : 'btn-secondary', isFloat ? 'float-end' : '', isLoaderDisplayed && !suppressLoader ? 'has-loader' : '', ]" @@ -33,7 +29,6 @@ export default { loaderPosition: String, isFloat: Boolean, suppressLoader: Boolean, - customSecondary: Boolean, // New property to check if it comes from donationBlock }, data() { return { @@ -161,13 +156,6 @@ export default { transition: background 0s 0s ease-in-out; } } - &.custom-secondary { - &:hover { - color: $blue !important; - background: transparent !important; - border: 1px solid $blue; - } - } &.btn-success { position: relative; background: $green-100; From 28e5d40cf127d1c03431dced2f0dc2a18b2d859d Mon Sep 17 00:00:00 2001 From: Bryan Mauger Date: Mon, 14 Apr 2025 15:30:51 -0400 Subject: [PATCH 04/11] CASH-510, CASH-511 QA Ui footer fixes. --- src/fmg-components/funnel-footer/funnel-footer.vue | 14 +++++++++----- src/layouts/customer-details/customer-details.vue | 2 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/fmg-components/funnel-footer/funnel-footer.vue b/src/fmg-components/funnel-footer/funnel-footer.vue index 89db470f0..0cff25b0b 100644 --- a/src/fmg-components/funnel-footer/funnel-footer.vue +++ b/src/fmg-components/funnel-footer/funnel-footer.vue @@ -11,6 +11,7 @@ From b54754f82ce7b3f819af765335c100626ec76fcf Mon Sep 17 00:00:00 2001 From: Bryan Mauger Date: Mon, 14 Apr 2025 15:42:59 -0400 Subject: [PATCH 05/11] Format code. --- src/layouts/customer-details/customer-details.vue | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/layouts/customer-details/customer-details.vue b/src/layouts/customer-details/customer-details.vue index c849491cb..baa8636be 100644 --- a/src/layouts/customer-details/customer-details.vue +++ b/src/layouts/customer-details/customer-details.vue @@ -56,7 +56,10 @@ @back-clicked="backButtonAction" @ForwardClicked="forwardButtonAction" /> - + From 6376b8d89c1a9dfc0766edcd7e5aff81ac14860a Mon Sep 17 00:00:00 2001 From: Minojhini Valaiyapathi Date: Tue, 15 Apr 2025 08:24:43 -0400 Subject: [PATCH 06/11] CASH-505 - Added application name to header in Logger --- src/helpers/logger.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/helpers/logger.js b/src/helpers/logger.js index 8af062c3b..d6f5b25a1 100644 --- a/src/helpers/logger.js +++ b/src/helpers/logger.js @@ -72,6 +72,7 @@ export class Logger { applicationConfig.CONSUMER_CF_DISTRO + applicationConfig.FRONTEND_LOGGER_PATH; const headers = { [headerKeys.EXPERIMENT]: JSON.stringify(store.getters.experimentSettings), + [headerKeys.APPLICATION_NAME]: applicationConfig.APPLICATION_NAME }; axios({ From a8f07d6237b55648134f53af04a3dafe323125a4 Mon Sep 17 00:00:00 2001 From: Minojhini Valaiyapathi Date: Tue, 15 Apr 2025 08:26:28 -0400 Subject: [PATCH 07/11] CASH-505 - Fixed the format --- src/helpers/logger.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/helpers/logger.js b/src/helpers/logger.js index d6f5b25a1..824c7dac0 100644 --- a/src/helpers/logger.js +++ b/src/helpers/logger.js @@ -72,7 +72,7 @@ export class Logger { applicationConfig.CONSUMER_CF_DISTRO + applicationConfig.FRONTEND_LOGGER_PATH; const headers = { [headerKeys.EXPERIMENT]: JSON.stringify(store.getters.experimentSettings), - [headerKeys.APPLICATION_NAME]: applicationConfig.APPLICATION_NAME + [headerKeys.APPLICATION_NAME]: applicationConfig.APPLICATION_NAME, }; axios({ From 671d16da375e552fa20d78a5889dafd7ce916b4d Mon Sep 17 00:00:00 2001 From: Chris Redelinghuys Date: Tue, 15 Apr 2025 11:38:16 -0400 Subject: [PATCH 08/11] CASH-203: Truncate full price --- .../service-package-radio-for-afterpay.vue | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/experiment-components/service-package-radio-for-afterpay.vue b/src/experiment-components/service-package-radio-for-afterpay.vue index 3356ee225..255ccc15b 100644 --- a/src/experiment-components/service-package-radio-for-afterpay.vue +++ b/src/experiment-components/service-package-radio-for-afterpay.vue @@ -78,7 +78,7 @@ in 4 interest-free payments
or - + From 2c05886fd57482f2dd376889c23ac17d584625a3 Mon Sep 17 00:00:00 2001 From: Chris Redelinghuys Date: Tue, 15 Apr 2025 11:55:04 -0400 Subject: [PATCH 09/11] CASH-203: Missing comma --- .../service-package-radio-for-afterpay.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/experiment-components/service-package-radio-for-afterpay.vue b/src/experiment-components/service-package-radio-for-afterpay.vue index 255ccc15b..b936e21bf 100644 --- a/src/experiment-components/service-package-radio-for-afterpay.vue +++ b/src/experiment-components/service-package-radio-for-afterpay.vue @@ -143,7 +143,7 @@ export default { }, truncatedSinglePayment() { return "$" + Math.trunc(this.buttonAuxillaryCopy.replace("$", "")); - } + }, }, }; From 9b2c97c2710e07a1a2ce2cef2f4414c6c8cc7088 Mon Sep 17 00:00:00 2001 From: Bryan Mauger Date: Tue, 15 Apr 2025 13:58:32 -0400 Subject: [PATCH 10/11] CASH-500 fix z-index issue for insurance page. --- src/layouts/insurance-company/insurance-company.vue | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/layouts/insurance-company/insurance-company.vue b/src/layouts/insurance-company/insurance-company.vue index 0f7bca7c7..e680a728d 100644 --- a/src/layouts/insurance-company/insurance-company.vue +++ b/src/layouts/insurance-company/insurance-company.vue @@ -203,3 +203,9 @@ export default { }, }; + + From 39cb860888e10877da789ba439c886e01d52e5c2 Mon Sep 17 00:00:00 2001 From: Bryan Mauger Date: Tue, 15 Apr 2025 14:06:41 -0400 Subject: [PATCH 11/11] Format code. --- src/layouts/insurance-company/insurance-company.vue | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/layouts/insurance-company/insurance-company.vue b/src/layouts/insurance-company/insurance-company.vue index e680a728d..c9409eb71 100644 --- a/src/layouts/insurance-company/insurance-company.vue +++ b/src/layouts/insurance-company/insurance-company.vue @@ -205,7 +205,7 @@ export default {