From da41aa8dc500eed511f0ef8458eddf51c4861f99 Mon Sep 17 00:00:00 2001 From: hiteshkumar87 Date: Thu, 16 Jan 2025 22:26:39 +0530 Subject: [PATCH 1/3] CASH-89 move function call resetStoreForExternalParameter when we are actually having external parameter call. --- src/router/index.js | 44 +++++++++++++++++++++++++++----------------- 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/src/router/index.js b/src/router/index.js index da3c1914c..6b11edff5 100644 --- a/src/router/index.js +++ b/src/router/index.js @@ -619,7 +619,14 @@ async function DisplayPageError() { type: globalEventTypes.Danger, } ); - store.commit(storeMutations.UPDATE_IS_EXTERNAL_PARAMETER, externalParameterStatus.INACTIVE); + if ( + store.getters.externalParameterState?.isExternalParameter == + externalParameterStatus.ACTIVE || + store.getters.externalParameterState?.isExternalParameter == + externalParameterStatus.INACTIVE + ) { + store.commit(storeMutations.UPDATE_IS_EXTERNAL_PARAMETER, externalParameterStatus.NOT_SET); + } baseMixin.methods.dispatchStoreAction(storeActions.RESET_SAVE_SESSION_PROMISE); const pageError = getQuerystringParameter(queryStrings.PAGE_ERROR); @@ -700,22 +707,6 @@ function getRedirectedStartPage() { } function updateExternalParameterState() { - // if there is an existing external parameter state then they have already been through from an external source(LeadGen) and - // are returning. clear out prior related things that need to be selected again like parts and damage type. - if ( - store.getters.externalParameterState?.isExternalParameter == - externalParameterStatus.INACTIVE - ) { - store.dispatch(storeActions.RESET_VEHICLE_STATE_AND_DEPENDENCIES); - store.dispatch(storeActions.SAVE_SERVICE_ZIP_CODE_INFO, { - state: null, - zipCode: null, - zipCodeCtu: null, - }); - store.dispatch(storeActions.SAVE_EMAIL, null); - store.dispatch(storeActions.RESET_DAMAGE_STATE_AND_DEPENDENCIES); - } - const externalParameterYear = getQuerystringParameter(queryStrings.VEHICLE_YEAR); const externalParameterMake = getQuerystringParameter(queryStrings.VEHICLE_MAKE); const externalParameterModel = getQuerystringParameter(queryStrings.VEHICLE_MODEL); @@ -734,6 +725,7 @@ function updateExternalParameterState() { externalParameterModel && externalParameterStyle ) { + resetStoreForExternalParameter(); store.commit(storeMutations.UPDATE_IS_EXTERNAL_PARAMETER, externalParameterStatus.ACTIVE); store.commit(storeMutations.UPDATE_EXTERNAL_PARAMETER_YEAR, externalParameterYear); store.commit(storeMutations.UPDATE_EXTERNAL_PARAMETER_MAKE, externalParameterMake); @@ -784,4 +776,22 @@ function updateExternalParameterState() { } } +// if there is an existing external parameter state then they have already been through from an external source(LeadGen) and +// are returning. clear out prior related things that need to be selected again like parts and damage type. +function resetStoreForExternalParameter() { + if ( + store.getters.externalParameterState?.isExternalParameter == + externalParameterStatus.INACTIVE + ) { + store.dispatch(storeActions.RESET_VEHICLE_STATE_AND_DEPENDENCIES); + store.dispatch(storeActions.SAVE_SERVICE_ZIP_CODE_INFO, { + state: null, + zipCode: null, + zipCodeCtu: null, + }); + store.dispatch(storeActions.SAVE_EMAIL, null); + store.dispatch(storeActions.RESET_DAMAGE_STATE_AND_DEPENDENCIES); + } +} + export default router; From 625fc3c168746a266a25358c0b0e76d7e3416a3d Mon Sep 17 00:00:00 2001 From: Bryan Mauger Date: Thu, 16 Jan 2025 16:23:21 -0500 Subject: [PATCH 2/3] Misc UI updates noticed during demo meeting. --- src/digital-components/modal/modal.vue | 5 +++-- src/layouts/quote/quote.vue | 2 +- .../service-package-radio/service-package-radio.vue | 6 +++++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/digital-components/modal/modal.vue b/src/digital-components/modal/modal.vue index 5ca708288..13f3c4522 100644 --- a/src/digital-components/modal/modal.vue +++ b/src/digital-components/modal/modal.vue @@ -216,6 +216,9 @@ export default { overflow: auto; flex: none; } + .textbox-question { + padding: .25rem 0; + } } } &.modal-dialog-centered { @@ -269,8 +272,6 @@ export default { flex-direction: column; .textbox-question { - padding: 0; - label { text-align: left; font-weight: 900; diff --git a/src/layouts/quote/quote.vue b/src/layouts/quote/quote.vue index 366a9d2cc..7557e0156 100644 --- a/src/layouts/quote/quote.vue +++ b/src/layouts/quote/quote.vue @@ -20,7 +20,7 @@
-
+
Date: Thu, 16 Jan 2025 17:24:50 -0500 Subject: [PATCH 3/3] Minor change to force build. --- src/digital-components/modal/modal.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/src/digital-components/modal/modal.vue b/src/digital-components/modal/modal.vue index 13f3c4522..bf1fad5f5 100644 --- a/src/digital-components/modal/modal.vue +++ b/src/digital-components/modal/modal.vue @@ -221,6 +221,7 @@ export default { } } } + &.modal-dialog-centered { align-items: flex-end; min-height: 100%;