From 605109b1fb3b4e9a88ba5cbae03617aee5b01e59 Mon Sep 17 00:00:00 2001 From: Max Date: Tue, 4 Jan 2022 10:44:46 -0500 Subject: [PATCH 1/2] Changes requested via jira --- .../button-question/button-question.vue | 6 +- .../funnel-header/funnel-header.spec.js | 8 +- .../funnel-header/funnel-header.vue | 15 ++- .../funnel-sub-header.spec.js | 15 ++- .../funnel-sub-header/funnel-sub-header.vue | 19 +++- .../vehicle-banner/vehicle-banner.spec.js | 15 ++- .../vehicle-banner/vehicle-banner.vue | 15 ++- .../make-question/make-question.vue | 3 +- src/layouts/vehicle-make/vehicle-make.spec.js | 74 +++++++++++-- src/layouts/vehicle-make/vehicle-make.vue | 15 +-- .../model-question/model-question.vue | 4 +- .../vehicle-model/vehicle-model.spec.js | 103 ++++++++++++++++-- src/layouts/vehicle-model/vehicle-model.vue | 15 +-- .../style-question/style-question.vue | 3 +- .../vehicle-style/vehicle-style.spec.js | 74 +++++++++++-- src/layouts/vehicle-style/vehicle-style.vue | 15 +-- src/layouts/vehicle-year/vehicle-year.spec.js | 54 ++++++++- src/layouts/vehicle-year/vehicle-year.vue | 16 +-- .../year-question/year-question.vue | 4 +- src/mixins/base-mixin.js | 12 +- src/mixins/base-mixin.spec.js | 19 ++-- .../list-button-horizontal.spec.js | 1 - .../list-button-horizontal.vue | 5 +- 23 files changed, 386 insertions(+), 124 deletions(-) diff --git a/src/common-components/button-question/button-question.vue b/src/common-components/button-question/button-question.vue index 9afd36c1f..ac96683f1 100644 --- a/src/common-components/button-question/button-question.vue +++ b/src/common-components/button-question/button-question.vue @@ -6,7 +6,7 @@ }}
-
+
{{groupName}}
@@ -52,7 +52,7 @@ export default { .button_question { height: calc(100vh - 280px); - .car_list { + .overflow-scroll { // Height will be determined by overall height of content above list height: calc(100% - 320px); -webkit-overflow-scrolling: touch; diff --git a/src/common-components/funnel-header/funnel-header.spec.js b/src/common-components/funnel-header/funnel-header.spec.js index cae21a179..ebb4a549c 100644 --- a/src/common-components/funnel-header/funnel-header.spec.js +++ b/src/common-components/funnel-header/funnel-header.spec.js @@ -7,13 +7,19 @@ describe("funnelHeader", () => { // Act const wrapper = shallowMount(funnelHeader, { - propsData: { + setData: { imageSrc: "image_url", }, }); + wrapper.vm.initializeComponent(cmsContent); // Assert expect(wrapper.find("img")).toBeTruthy(); wrapper.unmount(); }); }); + +//Mock CMS content +const cmsContent = { + imageSrc: 'image_url' +}; diff --git a/src/common-components/funnel-header/funnel-header.vue b/src/common-components/funnel-header/funnel-header.vue index 7b6c6efc6..f2934cb37 100644 --- a/src/common-components/funnel-header/funnel-header.vue +++ b/src/common-components/funnel-header/funnel-header.vue @@ -10,12 +10,15 @@ diff --git a/src/common-components/funnel-sub-header/funnel-sub-header.spec.js b/src/common-components/funnel-sub-header/funnel-sub-header.spec.js index 40b50186b..c6d30a71b 100644 --- a/src/common-components/funnel-sub-header/funnel-sub-header.spec.js +++ b/src/common-components/funnel-sub-header/funnel-sub-header.spec.js @@ -2,16 +2,21 @@ import { shallowMount } from "@vue/test-utils"; import FunnelSubHeader from "./funnel-sub-header"; describe("FunnelSubHeader.vue", () => { - it("Should render the 'text' prop value as a span value for the header span text value.", () => { + it("Should render the 'text' data value as a span value for the header span text value.", async () => { // Act - const wrapper = shallowMount(FunnelSubHeader, { - propsData: { - text: "FunnelSubHeader Content", - }, + const wrapper = shallowMount(FunnelSubHeader); + await wrapper.setData ({ + text: "FunnelSubHeader Content", }); + wrapper.vm.initializeComponent(cmsContent); // Assert expect(wrapper.find("h5").text()).toContain("FunnelSubHeader Content"); wrapper.unmount(); }); }); + +//Mock CMS content +const cmsContent = { + HeaderText: 'FunnelSubHeader Content' +}; diff --git a/src/common-components/funnel-sub-header/funnel-sub-header.vue b/src/common-components/funnel-sub-header/funnel-sub-header.vue index 3fd7ebc15..30021c8e6 100644 --- a/src/common-components/funnel-sub-header/funnel-sub-header.vue +++ b/src/common-components/funnel-sub-header/funnel-sub-header.vue @@ -8,9 +8,8 @@ - + @@ -20,20 +19,30 @@ import buttonBack from "@/ux-components/button-back/button-back"; export default { name: "FunnelSubHeader", + data() { + return { + text: '', + } + }, props: { - text: String, hasBackButton: Boolean, + backButtonUrl: String, backButtonAccessibleText: String, backButtonAction: Function, }, components: { buttonBack, - } + }, + methods: { + initializeComponent(cmsContent) { + this.text = cmsContent.HeaderText; + } + }, };