From 978f9c948d55e73cc63034c5f28c6a4b6f04b0cb Mon Sep 17 00:00:00 2001 From: Chloe Herd Date: Wed, 31 Jan 2024 13:50:04 -0500 Subject: [PATCH 1/4] Clip prices to 2 digits in logging. --- src/mixins/analytics-mixin.js | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/mixins/analytics-mixin.js b/src/mixins/analytics-mixin.js index e0d865c35..c6a8033fb 100644 --- a/src/mixins/analytics-mixin.js +++ b/src/mixins/analytics-mixin.js @@ -155,10 +155,9 @@ export default { ...(lineItems.vaps ?? []), ...(lineItems.promos ?? []), ]; - const subtotal = baseMixin.methods.getTotalPriceOfAllLineItemsAndChildParts( - combinedLineItems, - false - ); + const subtotal = baseMixin.methods + .getTotalPriceOfAllLineItemsAndChildParts(combinedLineItems, false) + .toFixed(2); // // get correct zip code const providerZip = order.serviceLocation.provider.address.zipCode; @@ -168,10 +167,9 @@ export default { : providerZip; // // calculate total - const total = baseMixin.methods.getTotalPriceOfAllLineItemsAndChildParts( - combinedLineItems, - true - ); + const total = baseMixin.methods + .getTotalPriceOfAllLineItemsAndChildParts(combinedLineItems, true) + .toFixed(2); const payload = { serviceZipCode: serviceZip, From f1e044549e4eeb967728463ee6143ae9b94b33c5 Mon Sep 17 00:00:00 2001 From: Chloe Herd Date: Wed, 31 Jan 2024 14:58:18 -0500 Subject: [PATCH 2/4] Type coercion --- src/mixins/analytics-mixin.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mixins/analytics-mixin.js b/src/mixins/analytics-mixin.js index c6a8033fb..d394190ff 100644 --- a/src/mixins/analytics-mixin.js +++ b/src/mixins/analytics-mixin.js @@ -176,16 +176,16 @@ export default { damageType: order.damage.isRepair ? "repair" : "replace", accountType: order.payment.isInsurance ? "insurance" : "cash", promoCodes: promoString, - vehicleYear: order.vehicle.year, + vehicleYear: `${order.vehicle.year}`, vehicleMake: order.vehicle.make, vehicleModel: order.vehicle.model, vehicleStyle: order.vehicle.style, glassToReplace: glassString, - workOrderId: order.workOrderId, - providerCtu: order.serviceLocation.zipCodeCtu, + workOrderId: parseInt(order.workOrderId), + providerCtu: parseInt(order.serviceLocation.zipCodeCtu), orderNumber: order.workOrderNumber, - priceTotal: total, - priceSubTotal: subtotal, + priceTotal: parseFloat(total), + priceSubTotal: parseFloat(subtotal), isRecalibrationOnOrder: store.getters.isRecalibrationOnSubmittedOrder, appointmentType: order.serviceLocation.appointmentType, }; From 5b5417f4a935529ae12e0e2a48fad261c1e8c926 Mon Sep 17 00:00:00 2001 From: Scott Kiener Date: Tue, 6 Feb 2024 09:43:25 -0500 Subject: [PATCH 3/4] CSR-1954 | Service-location continue button bug fix Mobile address was not always required to continue with "Mobile" option --- src/layouts/service-location/service-location.vue | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/layouts/service-location/service-location.vue b/src/layouts/service-location/service-location.vue index 4e890e531..5dcbc76f4 100644 --- a/src/layouts/service-location/service-location.vue +++ b/src/layouts/service-location/service-location.vue @@ -152,12 +152,12 @@ const MOBILE_FEE_PART_TYPE = "MOBILE FEE"; // DEFINE VALIDATION RULES defineRule("mobile-location-required", (value) => { if ( - value.addressQuestions.streetAddress == "" || - value.addressQuestions.city == "" || - value.addressQuestions.state == "" || - value.addressQuestions.zipCode == "" || - value.isVehicleProtected == null - ) { + !value.addressQuestions.streetAddress || + !value.addressQuestions.city || + !value.addressQuestions.state || + !value.addressQuestions.zipCode || + !value.isVehicleProtected + ) { return errorMessages.MOBILE_LOCATION_REQUIRED; } return true; From 6cec4d316f49e860c0cf66c0a75aa0b4315ec090 Mon Sep 17 00:00:00 2001 From: Scott Kiener Date: Tue, 6 Feb 2024 09:52:15 -0500 Subject: [PATCH 4/4] CSR-1954 | Formatting --- src/layouts/service-location/service-location.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/layouts/service-location/service-location.vue b/src/layouts/service-location/service-location.vue index 5dcbc76f4..6a43f456f 100644 --- a/src/layouts/service-location/service-location.vue +++ b/src/layouts/service-location/service-location.vue @@ -157,7 +157,7 @@ defineRule("mobile-location-required", (value) => { !value.addressQuestions.state || !value.addressQuestions.zipCode || !value.isVehicleProtected - ) { + ) { return errorMessages.MOBILE_LOCATION_REQUIRED; } return true;