jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Pull package names out to constants file

Browse source
This commit is contained in:
Chloe Herd 2023-06-22 09:08:45 -04:00
parent af6809256e
commit 64ab3afa78
3 changed files with 50 additions and 49 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/constants/package-names.js Normal file
View file

@ -0,0 +1,5 @@
export const packageNames = {
TIER_ONE: "TierOne",
TIER_TWO: "TierTwo",
TIER_THREE: "TierThree",
};

7
src/helpers/service-package-helper.js
View file

@ -1,11 +1,6 @@
import { partTypeStrings } from "@/constants/part-type-strings";
import { damageLocationsSelected as glassLocations } from "@/constants/damage-locations-selected";
export const packageNames = {
TIER_ONE: "TierOne",
TIER_TWO: "TierTwo",
TIER_THREE: "TierThree",
};
import { packageNames } from "@/constants/package-names";
export function containsLineItemWithPartType(typeToFind, itemsToSearch) {
const partTypeMatches = findLineItemsWithPartType(typeToFind, itemsToSearch);

87
src/helpers/service-package-helper.spec.js
View file

@ -1,6 +1,7 @@
import * as servicePackageHelper from "@/helpers/service-package-helper";
import { partTypeStrings } from "@/constants/part-type-strings";
import { damageLocationsSelected as glassLocations } from "@/constants/damage-locations-selected";
import { packageNames } from "@/constants/package-names";
describe("service-package-helper.js", () => {
describe("containsLineItemWithPartType", () => {
@ -310,8 +311,8 @@ describe("service-package-helper.js", () => {
// Assert
expect(results.length).toBe(2);
expect(results[0].packageName).toEqual(servicePackageHelper.packageNames.TIER_ONE);
expect(results[1].packageName).toEqual(servicePackageHelper.packageNames.TIER_THREE);
expect(results[0].packageName).toEqual(packageNames.TIER_ONE);
expect(results[1].packageName).toEqual(packageNames.TIER_THREE);
});
it("Returns three packages when wipers are available in tier two", () => {
@ -333,9 +334,9 @@ describe("service-package-helper.js", () => {
// Assert
expect(results.length).toBe(3);
expect(results[0].packageName).toEqual(servicePackageHelper.packageNames.TIER_ONE);
expect(results[1].packageName).toEqual(servicePackageHelper.packageNames.TIER_TWO);
expect(results[2].packageName).toEqual(servicePackageHelper.packageNames.TIER_THREE);
expect(results[0].packageName).toEqual(packageNames.TIER_ONE);
expect(results[1].packageName).toEqual(packageNames.TIER_TWO);
expect(results[2].packageName).toEqual(packageNames.TIER_THREE);
});
});
@ -357,13 +358,13 @@ describe("service-package-helper.js", () => {
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_TWO
packageNames.TIER_TWO
);
const resultThree = servicePackageHelper.shouldFrontWipersBeAvailable(
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_THREE
packageNames.TIER_THREE
);
// Assert
@ -382,13 +383,13 @@ describe("service-package-helper.js", () => {
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_TWO
packageNames.TIER_TWO
);
const resultThree = servicePackageHelper.shouldFrontWipersBeAvailable(
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_THREE
packageNames.TIER_THREE
);
// Assert
@ -407,7 +408,7 @@ describe("service-package-helper.js", () => {
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_TWO
packageNames.TIER_TWO
);
// Assert
@ -425,7 +426,7 @@ describe("service-package-helper.js", () => {
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_THREE
packageNames.TIER_THREE
);
// Assert
@ -443,19 +444,19 @@ describe("service-package-helper.js", () => {
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_ONE
packageNames.TIER_ONE
);
const resultTwo = servicePackageHelper.shouldFrontWipersBeAvailable(
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_TWO
packageNames.TIER_TWO
);
const resultThree = servicePackageHelper.shouldFrontWipersBeAvailable(
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_THREE
packageNames.TIER_THREE
);
// Assert
@ -475,7 +476,7 @@ describe("service-package-helper.js", () => {
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_ONE
packageNames.TIER_ONE
);
// Assert
@ -495,13 +496,13 @@ describe("service-package-helper.js", () => {
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_TWO
packageNames.TIER_TWO
);
const resultThree = servicePackageHelper.shouldRearWipersBeAvailable(
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_THREE
packageNames.TIER_THREE
);
// Assert
@ -520,7 +521,7 @@ describe("service-package-helper.js", () => {
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_TWO
packageNames.TIER_TWO
);
// Assert
@ -538,7 +539,7 @@ describe("service-package-helper.js", () => {
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_THREE
packageNames.TIER_THREE
);
// Assert
@ -560,7 +561,7 @@ describe("service-package-helper.js", () => {
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_THREE
packageNames.TIER_THREE
);
// Assert
@ -578,19 +579,19 @@ describe("service-package-helper.js", () => {
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_ONE
packageNames.TIER_ONE
);
const resultTwo = servicePackageHelper.shouldRearWipersBeAvailable(
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_TWO
packageNames.TIER_TWO
);
const resultThree = servicePackageHelper.shouldRearWipersBeAvailable(
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_THREE
packageNames.TIER_THREE
);
// Assert
@ -610,7 +611,7 @@ describe("service-package-helper.js", () => {
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_ONE
packageNames.TIER_ONE
);
// Assert
@ -635,19 +636,19 @@ describe("service-package-helper.js", () => {
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_ONE
packageNames.TIER_ONE
);
const resultTwo = servicePackageHelper.shouldRainDefenseBeAvailable(
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_TWO
packageNames.TIER_TWO
);
const resultThree = servicePackageHelper.shouldRainDefenseBeAvailable(
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_THREE
packageNames.TIER_THREE
);
// Assert
@ -674,7 +675,7 @@ describe("service-package-helper.js", () => {
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_THREE
packageNames.TIER_THREE
);
// Assert
@ -692,19 +693,19 @@ describe("service-package-helper.js", () => {
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_ONE
packageNames.TIER_ONE
);
const resultTwo = servicePackageHelper.shouldRainDefenseBeAvailable(
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_TWO
packageNames.TIER_TWO
);
const resultThree = servicePackageHelper.shouldRainDefenseBeAvailable(
damageLocations,
availableLineItems,
isRepair,
servicePackageHelper.packageNames.TIER_THREE
packageNames.TIER_THREE
);
// Assert
@ -737,7 +738,7 @@ describe("service-package-helper.js", () => {
);
// Assert
expect(result).toEqual(servicePackageHelper.packageNames.TIER_THREE);
expect(result).toEqual(packageNames.TIER_THREE);
});
it("Should return tier 2 for items in tier 2 and 3", () => {
@ -768,8 +769,8 @@ describe("service-package-helper.js", () => {
);
// Assert
expect(resultFront).toEqual(servicePackageHelper.packageNames.TIER_TWO);
expect(resultRear).toEqual(servicePackageHelper.packageNames.TIER_TWO);
expect(resultFront).toEqual(packageNames.TIER_TWO);
expect(resultRear).toEqual(packageNames.TIER_TWO);
});
it("Should return tier 1 for any item not in any tier", () => {
@ -793,7 +794,7 @@ describe("service-package-helper.js", () => {
);
// Assert
expect(resultFront).toEqual(servicePackageHelper.packageNames.TIER_ONE);
expect(resultFront).toEqual(packageNames.TIER_ONE);
});
});
@ -823,7 +824,7 @@ describe("service-package-helper.js", () => {
);
// Assert
expect(result).toEqual(servicePackageHelper.packageNames.TIER_THREE);
expect(result).toEqual(packageNames.TIER_THREE);
});
it("Should not return a higher tier than items require", () => {
@ -847,7 +848,7 @@ describe("service-package-helper.js", () => {
);
// Assert
expect(result).toEqual(servicePackageHelper.packageNames.TIER_TWO);
expect(result).toEqual(packageNames.TIER_TWO);
});
it("Should return tier 1 for empty set", () => {
@ -871,7 +872,7 @@ describe("service-package-helper.js", () => {
);
// Assert
expect(result).toEqual(servicePackageHelper.packageNames.TIER_ONE);
expect(result).toEqual(packageNames.TIER_ONE);
});
it("Should return tier 1 if no vaps are part of tiers", () => {
@ -895,7 +896,7 @@ describe("service-package-helper.js", () => {
);
// Assert
expect(result).toEqual(servicePackageHelper.packageNames.TIER_ONE);
expect(result).toEqual(packageNames.TIER_ONE);
});
});
@ -926,7 +927,7 @@ describe("service-package-helper.js", () => {
);
// Assert
expect(result).toEqual(servicePackageHelper.packageNames.TIER_THREE);
expect(result).toEqual(packageNames.TIER_THREE);
});
it("Should only return *satisfied* tier", () => {
@ -950,7 +951,7 @@ describe("service-package-helper.js", () => {
);
// Assert
expect(result).toEqual(servicePackageHelper.packageNames.TIER_TWO);
expect(result).toEqual(packageNames.TIER_TWO);
});
it("Should not return a tier if it is only partially satisfied", () => {
@ -974,7 +975,7 @@ describe("service-package-helper.js", () => {
);
// Assert
expect(result).toEqual(servicePackageHelper.packageNames.TIER_ONE);
expect(result).toEqual(packageNames.TIER_ONE);
});
it("Should return tier 1 if no vaps are selected.", () => {
@ -998,7 +999,7 @@ describe("service-package-helper.js", () => {
);
// Assert
expect(result).toEqual(servicePackageHelper.packageNames.TIER_ONE);
expect(result).toEqual(packageNames.TIER_ONE);
});
});
});