jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #519 from Safelite/feature/CSR-622

Browse source 
CSR-622 Don't load if referralNumber is empty
This commit is contained in:
Frank Rua 2022-05-31 03:22:52 -06:00 committed by GitHub
commit 62ef851b4e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/helpers/heritage-integration/order-helper.js
View file

@ -11,8 +11,8 @@ import baseMixin from "@/mixins/base-mixin";
export async function loadOrderIfPresent() { export async function loadOrderIfPresent() {
const funnelCookie = getFunnelCookie(); const funnelCookie = getFunnelCookie();
// Do nothing if there is no cookie or no correlation id. // Do nothing if there is no cookie, correlation id, or referral number.
if (funnelCookie == null || funnelCookie.ReferralCorrelationId == null) { if (funnelCookie == null || funnelCookie.ReferralCorrelationId == null || !funnelCookie.ReferralNumber) {
return null; return null;
} }

9
src/helpers/heritage-integration/order-helper.spec.js
View file

@ -18,7 +18,8 @@ describe("loadOrderIfPresent", () => {
const testCookieValue = { const testCookieValue = {
ShouldResetState: testShouldResetState, ShouldResetState: testShouldResetState,
ReferralCorrelationId: "xxx" ReferralCorrelationId: "xxx",
ReferralNumber: "12345"
} }
document.cookie = `${cookieNames.FUNNEL_SESSION_INFO}=${JSON.stringify(testCookieValue)}; path=/; ${cookieHelper.getCookieDomainValue()}`; document.cookie = `${cookieNames.FUNNEL_SESSION_INFO}=${JSON.stringify(testCookieValue)}; path=/; ${cookieHelper.getCookieDomainValue()}`;
@ -33,7 +34,11 @@ describe("loadOrderIfPresent", () => {
test("ShouldResetState == true => reset store", () => { test("ShouldResetState == true => reset store", () => {
// Arrange // Arrange
cookieHelper.getFunnelCookie = jest.spyOn(cookieHelper, "getFunnelCookie").mockReturnValueOnce({ ShouldResetState: true, ReferralCorrelationId: "xxx-xxx-xxx" }); cookieHelper.getFunnelCookie = jest.spyOn(cookieHelper, "getFunnelCookie").mockReturnValueOnce({
ShouldResetState: true,
ReferralCorrelationId: "xxx-xxx-xxx",
ReferralNumber: "12345"
});
const mockData = { const mockData = {
actionList: [{ actionList: [{