Changes requested via jira

This commit is contained in:
Max 2022-01-04 10:44:46 -05:00
parent 86191a16fe
commit 605109b1fb
23 changed files with 386 additions and 124 deletions

View file

@ -6,7 +6,7 @@
}}</span> }}</span>
</div> </div>
<div class="w-100 d-flex justify-content-center"> <div class="w-100 d-flex justify-content-center">
<fieldset class="car_list overflow-scroll position-absolute container-fluid w-100 pt-1 px-5 py-0" role="radiogroup"> <fieldset class="overflow-scroll position-absolute container-fluid w-100 pt-1 px-5 py-0" role="radiogroup">
<legend class="sr-only">{{groupName}}</legend> <legend class="sr-only">{{groupName}}</legend>
<listButton v-for="answer in answers" :key="answer" <listButton v-for="answer in answers" :key="answer"
:buttonID="answer" :buttonID="answer"
@ -20,7 +20,7 @@
textPosition="text-start" textPosition="text-start"
:isRequired="true" :isRequired="true"
:value="modelValue" :value="modelValue"
screenReaderOnlyText=" opens new window" screenReaderOnlyText="(opens new window)"
/> />
</fieldset> </fieldset>
</div> </div>
@ -52,7 +52,7 @@ export default {
.button_question { .button_question {
height: calc(100vh - 280px); height: calc(100vh - 280px);
.car_list { .overflow-scroll {
// Height will be determined by overall height of content above list // Height will be determined by overall height of content above list
height: calc(100% - 320px); height: calc(100% - 320px);
-webkit-overflow-scrolling: touch; -webkit-overflow-scrolling: touch;

View file

@ -7,13 +7,19 @@ describe("funnelHeader", () => {
// Act // Act
const wrapper = shallowMount(funnelHeader, { const wrapper = shallowMount(funnelHeader, {
propsData: { setData: {
imageSrc: "image_url", imageSrc: "image_url",
}, },
}); });
wrapper.vm.initializeComponent(cmsContent);
// Assert // Assert
expect(wrapper.find("img")).toBeTruthy(); expect(wrapper.find("img")).toBeTruthy();
wrapper.unmount(); wrapper.unmount();
}); });
}); });
//Mock CMS content
const cmsContent = {
imageSrc: 'image_url'
};

View file

@ -10,12 +10,15 @@
<script> <script>
export default { export default {
name: "funnel-header", name: "funnel-header",
props: { data() {
imageSrc: { return {
type: String, imageSrc: '',
required: true, }
default: "", },
}, methods: {
initializeComponent(cmsContent) {
this.imageSrc = cmsContent.LogoImage;
}
}, },
}; };
</script> </script>

View file

@ -2,16 +2,21 @@ import { shallowMount } from "@vue/test-utils";
import FunnelSubHeader from "./funnel-sub-header"; import FunnelSubHeader from "./funnel-sub-header";
describe("FunnelSubHeader.vue", () => { describe("FunnelSubHeader.vue", () => {
it("Should render the 'text' prop value as a span value for the header span text value.", () => { it("Should render the 'text' data value as a span value for the header span text value.", async () => {
// Act // Act
const wrapper = shallowMount(FunnelSubHeader, { const wrapper = shallowMount(FunnelSubHeader);
propsData: { await wrapper.setData ({
text: "FunnelSubHeader Content", text: "FunnelSubHeader Content",
},
}); });
wrapper.vm.initializeComponent(cmsContent);
// Assert // Assert
expect(wrapper.find("h5").text()).toContain("FunnelSubHeader Content"); expect(wrapper.find("h5").text()).toContain("FunnelSubHeader Content");
wrapper.unmount(); wrapper.unmount();
}); });
}); });
//Mock CMS content
const cmsContent = {
HeaderText: 'FunnelSubHeader Content'
};

View file

@ -8,9 +8,8 @@
<buttonBack <buttonBack
v-if="hasBackButton" v-if="hasBackButton"
:backButtonAction="backButtonAction" :backButtonAction="backButtonAction"
:backButtonAccessibleText="backButtonAccessibleText"
/> />
</h5> </h5>
</div> </div>
</div> </div>
</template> </template>
@ -20,20 +19,30 @@ import buttonBack from "@/ux-components/button-back/button-back";
export default { export default {
name: "FunnelSubHeader", name: "FunnelSubHeader",
data() {
return {
text: '',
}
},
props: { props: {
text: String,
hasBackButton: Boolean, hasBackButton: Boolean,
backButtonUrl: String,
backButtonAccessibleText: String, backButtonAccessibleText: String,
backButtonAction: Function, backButtonAction: Function,
}, },
components: { components: {
buttonBack, buttonBack,
} },
methods: {
initializeComponent(cmsContent) {
this.text = cmsContent.HeaderText;
}
},
}; };
</script> </script>
<style lang="scss"> <style lang="scss">
h5 { h2 {
color: $gray-550; color: $gray-550;
button { button {

View file

@ -2,18 +2,23 @@ import { shallowMount } from "@vue/test-utils";
import vehicleBanner from "./vehicle-banner"; import vehicleBanner from "./vehicle-banner";
describe("vehicleBanner", () => { describe("vehicleBanner", () => {
test("renders the blurrycar image", () => { test("renders the blurrycar image", async () => {
// Arrange // Arrange
// Act // Act
const wrapper = shallowMount(vehicleBanner, { const wrapper = shallowMount(vehicleBanner);
propsData: { await wrapper.setData ({
vehicleImageSrc: "image_url", vehicleImageSrc: "image_url",
},
}); });
wrapper.vm.initializeComponent(cmsContent);
// Assert // Assert
expect(wrapper.find("img").attributes("class")).toContain("blurrycar"); expect(wrapper.find("img").attributes("class")).toContain("blurrycar");
wrapper.unmount(); wrapper.unmount();
}); });
}); });
//Mock CMS content
const cmsContent = {
GenericVehicleImage: 'image_url'
};

View file

@ -11,12 +11,15 @@
<script> <script>
export default { export default {
name: "vehicle-banner", name: "vehicle-banner",
props: { data() {
vehicleImageSrc: { return {
type: String, vehicleImageSrc: '',
required: true, }
default: "", },
}, methods: {
initializeComponent(cmsContent) {
this.vehicleImageSrc = cmsContent.GenericVehicleImage;
}
}, },
}; };
</script> </script>

View file

@ -12,6 +12,7 @@ import buttonQuestion from "@/common-components/button-question/button-question"
// Supporting files // Supporting files
import store from "@/store"; import store from "@/store";
import { storeActions } from "@/constants/store-actions.js"; import { storeActions } from "@/constants/store-actions.js";
import baseMixin from "@/mixins/base-mixin.js";
export default { export default {
name: "make-question", name: "make-question",
@ -30,7 +31,7 @@ export default {
}, },
methods: { methods: {
loadInitialData() { loadInitialData() {
return store.dispatch(storeActions.GET_VEHICLE_MAKES, {year: store.getters.vehicle.year}); return baseMixin.methods.dispatchNonBlockingStoreAction(storeActions.GET_VEHICLE_MAKES, {year: store.getters.vehicle.year});
}, },
initializeComponent(cmsContent, initialData) { initializeComponent(cmsContent, initialData) {
this.questionText = cmsContent.QuestionText; this.questionText = cmsContent.QuestionText;

View file

@ -2,6 +2,9 @@ import { shallowMount, flushPromises } from "@vue/test-utils";
import { getMountOptions } from "@/helpers/unit-test-helper.js"; import { getMountOptions } from "@/helpers/unit-test-helper.js";
import vehicleMake from "@/layouts/vehicle-make/vehicle-make.vue"; import vehicleMake from "@/layouts/vehicle-make/vehicle-make.vue";
import makeQuestion from "@/layouts/vehicle-make/make-question/make-question"; import makeQuestion from "@/layouts/vehicle-make/make-question/make-question";
import funnelHeader from "@/common-components/funnel-header/funnel-header";
import vehicleBanner from "@/common-components/vehicle-banner/vehicle-banner";
import funnelSubHeader from "@/common-components/funnel-sub-header/funnel-sub-header";
import { settleAllPromises } from "@/helpers/layout-helper.js"; import { settleAllPromises } from "@/helpers/layout-helper.js";
import { nextTick } from "vue"; import { nextTick } from "vue";
@ -33,18 +36,60 @@ describe("vehicle-make.vue", () => {
}); });
describe("vehicle-make.vue", () => { describe("vehicle-make.vue", () => {
test("Page header is passed data from CMS", async (done) => { test("Page header is initailized with api data", async (done) => {
//Arrange //Arrange
const { wrapper, apiPromise } = setupMocks( { funnelSubHeaderWidgetHeaderText: "Select a make to get started" }); const pageHeaderWidgetHeaderText = "Select a make to get started";
const { wrapper, apiPromise } = setupMocks( { pageHeaderWidgetHeaderText: pageHeaderWidgetHeaderText });
//Act //Act
vehicleMake.beforeRouteEnter.call(wrapper.vm, { query: { fmgPage: "vehicle-make" } }, undefined, (c) => c(wrapper.vm)); vehicleMake.beforeRouteEnter.call(wrapper.vm, { query: { fmgPage: "vehicle-make" } }, undefined, (c) => c(wrapper.vm));
//Assert //Assert
const header = await wrapper.find(".Header");
apiPromise.finally(() => { apiPromise.finally(() => {
expect(header.attributes("text")).toEqual("Select a make to get started"); expect(funnelSubHeader.methods.initializeComponent).toHaveBeenCalledWith(pageHeaderWidgetHeaderText);
done();
});
});
});
describe("vehicle-make.vue", () => {
test("Page logo image is initailized with api data", async (done) => {
//Arrange
const SiteHeaderWidget = {
LogoImage:
"https://digitalconsumercms-dev.safelite.com/images/default-source/default-album/safelite-logo.svg?sfvrsn=45e7ed06_3",
}
const { wrapper, apiPromise } = setupMocks( { SiteHeaderWidget: SiteHeaderWidget});
//Act
vehicleMake.beforeRouteEnter.call(wrapper.vm, { query: { fmgPage: "vehicle-make" } }, undefined, (c) => c(wrapper.vm));
//Assert
apiPromise.finally(() => {
expect(funnelHeader.methods.initializeComponent).toHaveBeenCalledWith(SiteHeaderWidget);
done();
});
});
});
describe("vehicle-make.vue", () => {
test("Vehicle image is initailized with api data", async (done) => {
//Arrange
const VehicleBannerWidget = {
GenericVehicleImage:
"https://digitalconsumercms-dev.safelite.com/images/default-source/default-album/blurred-image.jpg?sfvrsn=a6ce3034_3",
}
const { wrapper, apiPromise } = setupMocks( { VehicleBannerWidget: VehicleBannerWidget});
//Act
vehicleMake.beforeRouteEnter.call(wrapper.vm, { query: { fmgPage: "vehicle-make" } }, undefined, (c) => c(wrapper.vm));
//Assert
apiPromise.finally(() => {
expect(vehicleBanner.methods.initializeComponent).toHaveBeenCalledWith(VehicleBannerWidget);
done(); done();
}); });
}); });
@ -55,7 +100,7 @@ describe("vehicle-make.vue", () => {
//Arrange //Arrange
const { wrapper, apiPromise } = setupMocks( { const { wrapper, apiPromise } = setupMocks( {
funnelSubHeaderWidgetHeaderText: "Select a make to get started", pageHeaderWidgetHeaderText: "Select a make to get started",
mountOptionsMockData: { mountOptionsMockData: {
router: { router: {
navigate: jest.fn() navigate: jest.fn()
@ -79,14 +124,14 @@ describe("vehicle-make.vue", () => {
function setupMocks({ function setupMocks({
radioQuestionCmsContent = {}, radioQuestionCmsContent = {},
makeQuestionInitialData = {}, makeQuestionInitialData = {},
funnelSubHeaderWidgetHeaderText = {}, pageHeaderWidgetHeaderText = {},
mountOptionsMockData = {}, mountOptionsMockData = {},
}) { }) {
//Mock api responses //Mock api responses
const apiResponses = { const apiResponses = {
cmsContent: { cmsContent: {
FunnelSubHeaderWidget: [{ HeaderText: funnelSubHeaderWidgetHeaderText }], FunnelSubHeaderWidget: [pageHeaderWidgetHeaderText],
RadioQuestionWidget: [radioQuestionCmsContent], RadioQuestionWidget: [radioQuestionCmsContent],
VehicleBannerWidget: [ VehicleBannerWidget: [
{ {
@ -111,10 +156,25 @@ function setupMocks({
loadInitialData: jest.fn(), loadInitialData: jest.fn(),
initializeComponent: jest.fn(), initializeComponent: jest.fn(),
}; };
funnelHeader.methods = {
initializeComponent: jest.fn(),
};
vehicleBanner.methods = {
initializeComponent: jest.fn(),
};
funnelSubHeader.methods = {
initializeComponent: jest.fn(),
};
const mountOptions = getMountOptions(mountOptionsMockData); const mountOptions = getMountOptions(mountOptionsMockData);
const wrapper = shallowMount(vehicleMake, mountOptions); const wrapper = shallowMount(vehicleMake, mountOptions);
const makeQuestionWrapper = wrapper.findComponent({ name: "makeQuestion" }); const makeQuestionWrapper = wrapper.findComponent({ name: "makeQuestion" });
makeQuestionWrapper.vm.initializeComponent = makeQuestion.methods.initializeComponent; makeQuestionWrapper.vm.initializeComponent = makeQuestion.methods.initializeComponent;
const funnelHeaderWrapper = wrapper.findComponent({ name: "funnelHeader" });
funnelHeaderWrapper.vm.initializeComponent = funnelHeader.methods.initializeComponent;
const vehicleBannerWrapper = wrapper.findComponent({ name: "vehicleBanner" });
vehicleBannerWrapper.vm.initializeComponent = vehicleBanner.methods.initializeComponent;
const funnelSubHeaderWrapper = wrapper.findComponent({ name: "funnelSubHeader" });
funnelSubHeaderWrapper.vm.initializeComponent = funnelSubHeader.methods.initializeComponent;
return { wrapper, apiPromise }; return { wrapper, apiPromise };
} }

View file

@ -1,11 +1,11 @@
<template> <template>
<div class="container-fluid shadow rounded-3 p-0"> <div class="container-fluid shadow rounded-3 p-0">
<funnelHeader :imageSrc="funnelHeaderWidget.LogoImage" /> <funnelHeader ref="funnelHeader" />
<div class="select-car"> <div class="select-car">
<div class="select-car-form rounded text-center"> <div class="select-car-form rounded text-center">
<vehicleBanner :vehicleImageSrc="vehicleBannerWidget.GenericVehicleImage" /> <vehicleBanner ref="vehicleBanner" />
<funnelSubHeader <funnelSubHeader
:text="funnelSubHeaderWidget.HeaderText" ref="funnelSubHeader"
:hasBackButton="true" :hasBackButton="true"
backButtonAccessibleText="Change Vehicle Year" backButtonAccessibleText="Change Vehicle Year"
:backButtonAction="backButtonAction" :backButtonAction="backButtonAction"
@ -30,9 +30,6 @@ export default {
name: "vehicle-make", name: "vehicle-make",
data() { data() {
return { return {
funnelSubHeaderWidget: {},
funnelHeaderWidget: {},
vehicleBannerWidget: {},
selectedMake: null, selectedMake: null,
}; };
}, },
@ -58,9 +55,9 @@ export default {
settleAllPromises(promiseResultMap).then((resultMap) => { settleAllPromises(promiseResultMap).then((resultMap) => {
// Call the "next" function to complete the transition to this page. // Call the "next" function to complete the transition to this page.
next((vm) => { next((vm) => {
vm.funnelSubHeaderWidget = resultMap.cmsContent.FunnelSubHeaderWidget[0]; vm.$refs.funnelSubHeader.initializeComponent(resultMap.cmsContent.FunnelSubHeaderWidget[0]);
vm.funnelHeaderWidget = resultMap.cmsContent.FunnelHeaderWidget[0]; vm.$refs.funnelHeader.initializeComponent(resultMap.cmsContent.FunnelHeaderWidget[0]);
vm.vehicleBannerWidget = resultMap.cmsContent.VehicleBannerWidget[0]; vm.$refs.vehicleBanner.initializeComponent(resultMap.cmsContent.VehicleBannerWidget[0]);
vm.$refs.makeQuestion.initializeComponent(resultMap.cmsContent.RadioQuestionWidget[0], resultMap.makeQuestionInitialData); vm.$refs.makeQuestion.initializeComponent(resultMap.cmsContent.RadioQuestionWidget[0], resultMap.makeQuestionInitialData);
}); });
}); });

View file

@ -12,9 +12,11 @@ import buttonQuestion from "@/common-components/button-question/button-question"
// Supporting files // Supporting files
import store from "@/store"; import store from "@/store";
import { storeActions } from "@/constants/store-actions.js"; import { storeActions } from "@/constants/store-actions.js";
import baseMixin from "@/mixins/base-mixin.js";
export default { export default {
name: "model-question", name: "model-question",
mixins: [baseMixin],
data() { data() {
return { return {
questionText: null, questionText: null,
@ -30,7 +32,7 @@ export default {
}, },
methods: { methods: {
loadInitialData() { loadInitialData() {
return store.dispatch(storeActions.GET_VEHICLE_MODELS, {year: store.getters.vehicle.year, make: encodeURIComponent(store.getters.vehicle.make)}); return baseMixin.methods.dispatchNonBlockingStoreAction(storeActions.GET_VEHICLE_MODELS, {year: store.getters.vehicle.year, make: store.getters.vehicle.make});
}, },
initializeComponent(cmsContent, initialData) { initializeComponent(cmsContent, initialData) {
this.questionText = cmsContent.QuestionText; this.questionText = cmsContent.QuestionText;

View file

@ -2,6 +2,9 @@ import { shallowMount, flushPromises } from "@vue/test-utils";
import { getMountOptions } from "@/helpers/unit-test-helper.js"; import { getMountOptions } from "@/helpers/unit-test-helper.js";
import vehicleModel from "@/layouts/vehicle-model/vehicle-model.vue"; import vehicleModel from "@/layouts/vehicle-model/vehicle-model.vue";
import modelQuestion from "@/layouts/vehicle-model/model-question/model-question"; import modelQuestion from "@/layouts/vehicle-model/model-question/model-question";
import funnelHeader from "@/common-components/funnel-header/funnel-header";
import vehicleBanner from "@/common-components/vehicle-banner/vehicle-banner";
import funnelSubHeader from "@/common-components/funnel-sub-header/funnel-sub-header";
import { settleAllPromises } from "@/helpers/layout-helper.js"; import { settleAllPromises } from "@/helpers/layout-helper.js";
import { nextTick } from "vue"; import { nextTick } from "vue";
@ -33,18 +36,86 @@ describe("vehicle-model.vue", () => {
}); });
describe("vehicle-model.vue", () => { describe("vehicle-model.vue", () => {
test("Page header is passed data from CMS", async (done) => { test("Page header is initailized with api data", async (done) => {
//Arange //Arrange
const { wrapper, apiPromise } = setupMocks( { funnelSubHeaderWidgetHeaderText: "Select a model to get started" }); const pageHeaderWidgetHeaderText = "Select a model to get started";
const { wrapper, apiPromise } = setupMocks( { pageHeaderWidgetHeaderText: pageHeaderWidgetHeaderText });
//Act //Act
vehicleModel.beforeRouteEnter.call(wrapper.vm, { query: { fmgPage: "vehicle-model" } }, undefined, (c) => c(wrapper.vm)); vehicleModel.beforeRouteEnter.call(wrapper.vm, { query: { fmgPage: "vehicle-model" } }, undefined, (c) => c(wrapper.vm));
//Assert //Assert
const header = await wrapper.find(".Header");
apiPromise.finally(() => { apiPromise.finally(() => {
expect(header.attributes("text")).toEqual("Select a model to get started"); expect(funnelSubHeader.methods.initializeComponent).toHaveBeenCalledWith(pageHeaderWidgetHeaderText);
done();
});
});
});
describe("vehicle-model.vue", () => {
test("Page logo image is initailized with api data", async (done) => {
//Arrange
const SiteHeaderWidget = {
LogoImage:
"https://digitalconsumercms-dev.safelite.com/images/default-source/default-album/safelite-logo.svg?sfvrsn=45e7ed06_3",
}
const { wrapper, apiPromise } = setupMocks( { SiteHeaderWidget: SiteHeaderWidget});
//Act
vehicleModel.beforeRouteEnter.call(wrapper.vm, { query: { fmgPage: "vehicle-model" } }, undefined, (c) => c(wrapper.vm));
//Assert
apiPromise.finally(() => {
expect(funnelHeader.methods.initializeComponent).toHaveBeenCalledWith(SiteHeaderWidget);
done();
});
});
});
describe("vehicle-model.vue", () => {
test("Vehicle image is initailized with api data", async (done) => {
//Arrange
const VehicleBannerWidget = {
GenericVehicleImage:
"https://digitalconsumercms-dev.safelite.com/images/default-source/default-album/blurred-image.jpg?sfvrsn=a6ce3034_3",
}
const { wrapper, apiPromise } = setupMocks( { VehicleBannerWidget: VehicleBannerWidget});
//Act
vehicleModel.beforeRouteEnter.call(wrapper.vm, { query: { fmgPage: "vehicle-model" } }, undefined, (c) => c(wrapper.vm));
//Assert
apiPromise.finally(() => {
expect(vehicleBanner.methods.initializeComponent).toHaveBeenCalledWith(VehicleBannerWidget);
done();
});
});
});
describe("vehicle-model.vue", () => {
test("BackButtonAction triggers a router.navigate change", async (done) => {
//Arrange
const { wrapper, apiPromise } = setupMocks( {
pageHeaderWidgetHeaderText: "Select a model to get started",
mountOptionsMockData: {
router: {
navigate: jest.fn()
},
},
});
//Act
vehicleModel.beforeRouteEnter.call(wrapper.vm, { query: { fmgPage: "vehicle-model" } }, undefined, (c) => c(wrapper.vm));
wrapper.vm.backButtonAction();
await nextTick();
//Assert
apiPromise.finally(() => {
expect(wrapper.vm.$router.navigate).toHaveBeenCalled();
done(); done();
}); });
}); });
@ -53,13 +124,14 @@ describe("vehicle-model.vue", () => {
function setupMocks({ function setupMocks({
radioQuestionCmsContent = {}, radioQuestionCmsContent = {},
modelQuestionInitialData = {}, modelQuestionInitialData = {},
funnelSubHeaderWidgetHeaderText = {}, pageHeaderWidgetHeaderText = {},
mountOptionsMockData = {},
}) { }) {
//Mock api responses //Mock api responses
const apiResponses = { const apiResponses = {
cmsContent: { cmsContent: {
FunnelSubHeaderWidget: [{ HeaderText: funnelSubHeaderWidgetHeaderText }], FunnelSubHeaderWidget: [pageHeaderWidgetHeaderText],
RadioQuestionWidget: [radioQuestionCmsContent], RadioQuestionWidget: [radioQuestionCmsContent],
VehicleBannerWidget: [ VehicleBannerWidget: [
{ {
@ -84,10 +156,25 @@ function setupMocks({
loadInitialData: jest.fn(), loadInitialData: jest.fn(),
initializeComponent: jest.fn(), initializeComponent: jest.fn(),
}; };
const mountOptions = getMountOptions({ }); funnelHeader.methods = {
initializeComponent: jest.fn(),
};
vehicleBanner.methods = {
initializeComponent: jest.fn(),
};
funnelSubHeader.methods = {
initializeComponent: jest.fn(),
};
const mountOptions = getMountOptions(mountOptionsMockData);
const wrapper = shallowMount(vehicleModel, mountOptions); const wrapper = shallowMount(vehicleModel, mountOptions);
const modelQuestionWrapper = wrapper.findComponent({ name: "modelQuestion" }); const modelQuestionWrapper = wrapper.findComponent({ name: "modelQuestion" });
modelQuestionWrapper.vm.initializeComponent = modelQuestion.methods.initializeComponent; modelQuestionWrapper.vm.initializeComponent = modelQuestion.methods.initializeComponent;
const funnelHeaderWrapper = wrapper.findComponent({ name: "funnelHeader" });
funnelHeaderWrapper.vm.initializeComponent = funnelHeader.methods.initializeComponent;
const vehicleBannerWrapper = wrapper.findComponent({ name: "vehicleBanner" });
vehicleBannerWrapper.vm.initializeComponent = vehicleBanner.methods.initializeComponent;
const funnelSubHeaderWrapper = wrapper.findComponent({ name: "funnelSubHeader" });
funnelSubHeaderWrapper.vm.initializeComponent = funnelSubHeader.methods.initializeComponent;
return { wrapper, apiPromise }; return { wrapper, apiPromise };
} }

View file

@ -1,11 +1,11 @@
<template> <template>
<div class="container-fluid shadow rounded-3 p-0"> <div class="container-fluid shadow rounded-3 p-0">
<funnelHeader :imageSrc="funnelHeaderWidget.LogoImage" /> <funnelHeader ref="funnelHeader" />
<div class="select-car"> <div class="select-car">
<div class="select-car-form rounded text-center"> <div class="select-car-form rounded text-center">
<vehicleBanner :vehicleImageSrc="vehicleBannerWidget.GenericVehicleImage" /> <vehicleBanner ref="vehicleBanner" />
<funnelSubHeader <funnelSubHeader
:text="funnelSubHeaderWidget.HeaderText" ref="funnelSubHeader"
:hasBackButton="true" :hasBackButton="true"
backButtonAccessibleText="Change Vehicle Make" backButtonAccessibleText="Change Vehicle Make"
:backButtonAction="backButtonAction" :backButtonAction="backButtonAction"
@ -30,9 +30,6 @@ export default {
name: "vehicle-model", name: "vehicle-model",
data() { data() {
return { return {
funnelSubHeaderWidget: {},
funnelHeaderWidget: {},
vehicleBannerWidget: {},
selectedModel: null, selectedModel: null,
}; };
}, },
@ -58,9 +55,9 @@ export default {
settleAllPromises(promiseResultMap).then((resultMap) => { settleAllPromises(promiseResultMap).then((resultMap) => {
// Call the "next" function to complete the transition to this page. // Call the "next" function to complete the transition to this page.
next((vm) => { next((vm) => {
vm.funnelSubHeaderWidget = resultMap.cmsContent.FunnelSubHeaderWidget[0]; vm.$refs.funnelSubHeader.initializeComponent(resultMap.cmsContent.FunnelSubHeaderWidget[0]);
vm.funnelHeaderWidget = resultMap.cmsContent.FunnelHeaderWidget[0]; vm.$refs.funnelHeader.initializeComponent(resultMap.cmsContent.FunnelHeaderWidget[0]);
vm.vehicleBannerWidget = resultMap.cmsContent.VehicleBannerWidget[0]; vm.$refs.vehicleBanner.initializeComponent(resultMap.cmsContent.VehicleBannerWidget[0]);
vm.$refs.modelQuestion.initializeComponent(resultMap.cmsContent.RadioQuestionWidget[0], resultMap.modelQuestionInitialData); vm.$refs.modelQuestion.initializeComponent(resultMap.cmsContent.RadioQuestionWidget[0], resultMap.modelQuestionInitialData);
}); });
}); });

View file

@ -12,6 +12,7 @@ import buttonQuestion from "@/common-components/button-question/button-question"
// Supporting files // Supporting files
import store from "@/store"; import store from "@/store";
import { storeActions } from "@/constants/store-actions.js"; import { storeActions } from "@/constants/store-actions.js";
import baseMixin from "@/mixins/base-mixin.js";
export default { export default {
name: "style-question", name: "style-question",
@ -30,7 +31,7 @@ export default {
}, },
methods: { methods: {
loadInitialData() { loadInitialData() {
return store.dispatch(storeActions.GET_VEHICLE_STYLES, {year: store.getters.vehicle.year, make: encodeURIComponent(store.getters.vehicle.make), model: encodeURIComponent(store.getters.vehicle.model)}); return baseMixin.methods.dispatchNonBlockingStoreAction(storeActions.GET_VEHICLE_STYLES, {year: store.getters.vehicle.year, make: store.getters.vehicle.make, model: store.getters.vehicle.model});
}, },
initializeComponent(cmsContent, initialData) { initializeComponent(cmsContent, initialData) {
this.questionText = cmsContent.QuestionText; this.questionText = cmsContent.QuestionText;

View file

@ -1,6 +1,9 @@
import { shallowMount, flushPromises } from "@vue/test-utils"; import { shallowMount, flushPromises } from "@vue/test-utils";
import { getMountOptions } from "@/helpers/unit-test-helper.js"; import { getMountOptions } from "@/helpers/unit-test-helper.js";
import vehicleStyle from "@/layouts/vehicle-style/vehicle-style.vue"; import vehicleStyle from "@/layouts/vehicle-style/vehicle-style.vue";
import funnelHeader from "@/common-components/funnel-header/funnel-header";
import vehicleBanner from "@/common-components/vehicle-banner/vehicle-banner";
import funnelSubHeader from "@/common-components/funnel-sub-header/funnel-sub-header";
import styleQuestion from "@/layouts/vehicle-style/style-question/style-question"; import styleQuestion from "@/layouts/vehicle-style/style-question/style-question";
import { settleAllPromises } from "@/helpers/layout-helper.js"; import { settleAllPromises } from "@/helpers/layout-helper.js";
import { nextTick } from "vue"; import { nextTick } from "vue";
@ -33,18 +36,60 @@ describe("vehicle-style.vue", () => {
}); });
describe("vehicle-style.vue", () => { describe("vehicle-style.vue", () => {
test("Page header is passed data from CMS", async (done) => { test("Page header is initailized with api data", async (done) => {
//Arrange //Arrange
const { wrapper, apiPromise } = setupMocks( { funnelSubHeaderWidgetHeaderText: "Select a style to get started" }); const pageHeaderWidgetHeaderText = "Select a style to get started";
const { wrapper, apiPromise } = setupMocks( { pageHeaderWidgetHeaderText: pageHeaderWidgetHeaderText });
//Act //Act
vehicleStyle.beforeRouteEnter.call(wrapper.vm, { query: { fmgPage: "vehicle-style" } }, undefined, (c) => c(wrapper.vm)); vehicleStyle.beforeRouteEnter.call(wrapper.vm, { query: { fmgPage: "vehicle-style" } }, undefined, (c) => c(wrapper.vm));
//Assert //Assert
const header = await wrapper.find(".Header");
apiPromise.finally(() => { apiPromise.finally(() => {
expect(header.attributes("text")).toEqual("Select a style to get started"); expect(funnelSubHeader.methods.initializeComponent).toHaveBeenCalledWith(pageHeaderWidgetHeaderText);
done();
});
});
});
describe("vehicle-style.vue", () => {
test("Page logo image is initailized with api data", async (done) => {
//Arrange
const SiteHeaderWidget = {
LogoImage:
"https://digitalconsumercms-dev.safelite.com/images/default-source/default-album/safelite-logo.svg?sfvrsn=45e7ed06_3",
}
const { wrapper, apiPromise } = setupMocks( { SiteHeaderWidget: SiteHeaderWidget});
//Act
vehicleStyle.beforeRouteEnter.call(wrapper.vm, { query: { fmgPage: "vehicle-style" } }, undefined, (c) => c(wrapper.vm));
//Assert
apiPromise.finally(() => {
expect(funnelHeader.methods.initializeComponent).toHaveBeenCalledWith(SiteHeaderWidget);
done();
});
});
});
describe("vehicle-style.vue", () => {
test("Vehicle image is initailized with api data", async (done) => {
//Arrange
const VehicleBannerWidget = {
GenericVehicleImage:
"https://digitalconsumercms-dev.safelite.com/images/default-source/default-album/blurred-image.jpg?sfvrsn=a6ce3034_3",
}
const { wrapper, apiPromise } = setupMocks( { VehicleBannerWidget: VehicleBannerWidget});
//Act
vehicleStyle.beforeRouteEnter.call(wrapper.vm, { query: { fmgPage: "vehicle-style" } }, undefined, (c) => c(wrapper.vm));
//Assert
apiPromise.finally(() => {
expect(vehicleBanner.methods.initializeComponent).toHaveBeenCalledWith(VehicleBannerWidget);
done(); done();
}); });
}); });
@ -55,7 +100,7 @@ describe("vehicle-style.vue", () => {
//Arrange //Arrange
const { wrapper, apiPromise } = setupMocks( { const { wrapper, apiPromise } = setupMocks( {
funnelSubHeaderWidgetHeaderText: "Select a style to get started", pageHeaderWidgetHeaderText: "Select a style to get started",
mountOptionsMockData: { mountOptionsMockData: {
router: { router: {
navigate: jest.fn() navigate: jest.fn()
@ -79,14 +124,14 @@ describe("vehicle-style.vue", () => {
function setupMocks({ function setupMocks({
radioQuestionCmsContent = {}, radioQuestionCmsContent = {},
styleQuestionInitialData = {}, styleQuestionInitialData = {},
funnelSubHeaderWidgetHeaderText = {}, pageHeaderWidgetHeaderText = {},
mountOptionsMockData = {}, mountOptionsMockData = {},
}) { }) {
//Mock api responses //Mock api responses
const apiResponses = { const apiResponses = {
cmsContent: { cmsContent: {
FunnelSubHeaderWidget: [{ HeaderText: funnelSubHeaderWidgetHeaderText }], FunnelSubHeaderWidget: [pageHeaderWidgetHeaderText],
RadioQuestionWidget: [radioQuestionCmsContent], RadioQuestionWidget: [radioQuestionCmsContent],
VehicleBannerWidget: [ VehicleBannerWidget: [
{ {
@ -111,10 +156,25 @@ function setupMocks({
loadInitialData: jest.fn(), loadInitialData: jest.fn(),
initializeComponent: jest.fn(), initializeComponent: jest.fn(),
}; };
funnelHeader.methods = {
initializeComponent: jest.fn(),
};
vehicleBanner.methods = {
initializeComponent: jest.fn(),
};
funnelSubHeader.methods = {
initializeComponent: jest.fn(),
};
const mountOptions = getMountOptions(mountOptionsMockData); const mountOptions = getMountOptions(mountOptionsMockData);
const wrapper = shallowMount(vehicleStyle, mountOptions); const wrapper = shallowMount(vehicleStyle, mountOptions);
const styleQuestionWrapper = wrapper.findComponent({ name: "styleQuestion" }); const styleQuestionWrapper = wrapper.findComponent({ name: "styleQuestion" });
styleQuestionWrapper.vm.initializeComponent = styleQuestion.methods.initializeComponent; styleQuestionWrapper.vm.initializeComponent = styleQuestion.methods.initializeComponent;
const funnelHeaderWrapper = wrapper.findComponent({ name: "funnelHeader" });
funnelHeaderWrapper.vm.initializeComponent = funnelHeader.methods.initializeComponent;
const vehicleBannerWrapper = wrapper.findComponent({ name: "vehicleBanner" });
vehicleBannerWrapper.vm.initializeComponent = vehicleBanner.methods.initializeComponent;
const funnelSubHeaderWrapper = wrapper.findComponent({ name: "funnelSubHeader" });
funnelSubHeaderWrapper.vm.initializeComponent = funnelSubHeader.methods.initializeComponent;
return { wrapper, apiPromise }; return { wrapper, apiPromise };
} }

View file

@ -1,11 +1,11 @@
<template> <template>
<div class="container-fluid shadow rounded-3 p-0"> <div class="container-fluid shadow rounded-3 p-0">
<funnelHeader :imageSrc="funnelHeaderWidget.LogoImage" /> <funnelHeader ref="funnelHeader" />
<div class="select-car"> <div class="select-car">
<div class="select-car-form rounded text-center"> <div class="select-car-form rounded text-center">
<vehicleBanner :vehicleImageSrc="vehicleBannerWidget.GenericVehicleImage" /> <vehicleBanner ref="vehicleBanner" />
<funnelSubHeader <funnelSubHeader
:text="funnelSubHeaderWidget.HeaderText" ref="funnelSubHeader"
:hasBackButton="true" :hasBackButton="true"
backButtonAccessibleText="Change Vehicle Model" backButtonAccessibleText="Change Vehicle Model"
:backButtonAction="backButtonAction" :backButtonAction="backButtonAction"
@ -30,9 +30,6 @@ export default {
name: "vehicle-style", name: "vehicle-style",
data() { data() {
return { return {
funnelSubHeaderWidget: {},
funnelHeaderWidget: {},
vehicleBannerWidget: {},
selectedStyle: null, selectedStyle: null,
}; };
}, },
@ -58,9 +55,9 @@ export default {
settleAllPromises(promiseResultMap).then((resultMap) => { settleAllPromises(promiseResultMap).then((resultMap) => {
// Call the "next" function to complete the transition to this page. // Call the "next" function to complete the transition to this page.
next((vm) => { next((vm) => {
vm.funnelSubHeaderWidget = resultMap.cmsContent.FunnelSubHeaderWidget[0]; vm.$refs.funnelSubHeader.initializeComponent(resultMap.cmsContent.FunnelSubHeaderWidget[0]);
vm.funnelHeaderWidget = resultMap.cmsContent.FunnelHeaderWidget[0]; vm.$refs.funnelHeader.initializeComponent(resultMap.cmsContent.FunnelHeaderWidget[0]);
vm.vehicleBannerWidget = resultMap.cmsContent.VehicleBannerWidget[0]; vm.$refs.vehicleBanner.initializeComponent(resultMap.cmsContent.VehicleBannerWidget[0]);
vm.$refs.styleQuestion.initializeComponent(resultMap.cmsContent.RadioQuestionWidget[0], resultMap.styleQuestionInitialData); vm.$refs.styleQuestion.initializeComponent(resultMap.cmsContent.RadioQuestionWidget[0], resultMap.styleQuestionInitialData);
}); });
}); });

View file

@ -2,6 +2,9 @@ import { shallowMount, flushPromises } from "@vue/test-utils";
import { getMountOptions } from "@/helpers/unit-test-helper.js"; import { getMountOptions } from "@/helpers/unit-test-helper.js";
import vehicleYear from "@/layouts/vehicle-year/vehicle-year.vue"; import vehicleYear from "@/layouts/vehicle-year/vehicle-year.vue";
import yearQuestion from "@/layouts/vehicle-year/year-question/year-question"; import yearQuestion from "@/layouts/vehicle-year/year-question/year-question";
import funnelHeader from "@/common-components/funnel-header/funnel-header";
import vehicleBanner from "@/common-components/vehicle-banner/vehicle-banner";
import funnelSubHeader from "@/common-components/funnel-sub-header/funnel-sub-header";
import { settleAllPromises } from "@/helpers/layout-helper.js"; import { settleAllPromises } from "@/helpers/layout-helper.js";
import { nextTick } from "vue"; import { nextTick } from "vue";
@ -33,18 +36,42 @@ describe("vehicle-year.vue", () => {
}); });
describe("vehicle-year.vue", () => { describe("vehicle-year.vue", () => {
test("Page header is passed data from CMS", async (done) => { test("Page logo image is initailized with api data", async (done) => {
//Arrange //Arrange
const { wrapper, apiPromise } = setupMocks( { funnelSubHeaderWidgetHeaderText: "Select a year to get started" }); const SiteHeaderWidget = {
LogoImage:
"https://digitalconsumercms-dev.safelite.com/images/default-source/default-album/safelite-logo.svg?sfvrsn=45e7ed06_3",
}
const { wrapper, apiPromise } = setupMocks( { SiteHeaderWidget: SiteHeaderWidget});
//Act //Act
vehicleYear.beforeRouteEnter.call(wrapper.vm, { query: { fmgPage: "vehicle-year" } }, undefined, (c) => c(wrapper.vm)); vehicleYear.beforeRouteEnter.call(wrapper.vm, { query: { fmgPage: "vehicle-year" } }, undefined, (c) => c(wrapper.vm));
//Assert //Assert
const header = await wrapper.find(".Header");
apiPromise.finally(() => { apiPromise.finally(() => {
expect(header.attributes("text")).toEqual("Select a year to get started"); expect(funnelHeader.methods.initializeComponent).toHaveBeenCalledWith(SiteHeaderWidget);
done();
});
});
});
describe("vehicle-year.vue", () => {
test("Vehicle image is initailized with api data", async (done) => {
//Arrange
const VehicleBannerWidget = {
GenericVehicleImage:
"https://digitalconsumercms-dev.safelite.com/images/default-source/default-album/blurred-image.jpg?sfvrsn=a6ce3034_3",
}
const { wrapper, apiPromise } = setupMocks( { VehicleBannerWidget: VehicleBannerWidget});
//Act
vehicleYear.beforeRouteEnter.call(wrapper.vm, { query: { fmgPage: "vehicle-year" } }, undefined, (c) => c(wrapper.vm));
//Assert
apiPromise.finally(() => {
expect(vehicleBanner.methods.initializeComponent).toHaveBeenCalledWith(VehicleBannerWidget);
done(); done();
}); });
}); });
@ -53,14 +80,14 @@ describe("vehicle-year.vue", () => {
function setupMocks({ function setupMocks({
radioQuestionCmsContent = {}, radioQuestionCmsContent = {},
yearQuestionInitialData = {}, yearQuestionInitialData = {},
funnelSubHeaderWidgetHeaderText = {}, pageHeaderWidgetHeaderText = {},
mountOptionsMockData = {}, mountOptionsMockData = {},
}) { }) {
//Mock api responses //Mock api responses
const apiResponses = { const apiResponses = {
cmsContent: { cmsContent: {
FunnelSubHeaderWidget: [{ HeaderText: funnelSubHeaderWidgetHeaderText }], FunnelSubHeaderWidget: [{ HeaderText: pageHeaderWidgetHeaderText }],
RadioQuestionWidget: [radioQuestionCmsContent], RadioQuestionWidget: [radioQuestionCmsContent],
VehicleBannerWidget: [ VehicleBannerWidget: [
{ {
@ -85,10 +112,25 @@ function setupMocks({
loadInitialData: jest.fn(), loadInitialData: jest.fn(),
initializeComponent: jest.fn(), initializeComponent: jest.fn(),
}; };
funnelHeader.methods = {
initializeComponent: jest.fn(),
};
vehicleBanner.methods = {
initializeComponent: jest.fn(),
};
funnelSubHeader.methods = {
initializeComponent: jest.fn(),
};
const mountOptions = getMountOptions(mountOptionsMockData); const mountOptions = getMountOptions(mountOptionsMockData);
const wrapper = shallowMount(vehicleYear, mountOptions); const wrapper = shallowMount(vehicleYear, mountOptions);
const yearQuestionWrapper = wrapper.findComponent({ name: "yearQuestion" }); const yearQuestionWrapper = wrapper.findComponent({ name: "yearQuestion" });
yearQuestionWrapper.vm.initializeComponent = yearQuestion.methods.initializeComponent; yearQuestionWrapper.vm.initializeComponent = yearQuestion.methods.initializeComponent;
const funnelHeaderWrapper = wrapper.findComponent({ name: "funnelHeader" });
funnelHeaderWrapper.vm.initializeComponent = funnelHeader.methods.initializeComponent;
const vehicleBannerWrapper = wrapper.findComponent({ name: "vehicleBanner" });
vehicleBannerWrapper.vm.initializeComponent = vehicleBanner.methods.initializeComponent;
const funnelSubHeaderWrapper = wrapper.findComponent({ name: "funnelSubHeader" });
funnelSubHeaderWrapper.vm.initializeComponent = funnelSubHeader.methods.initializeComponent;
return { wrapper, apiPromise }; return { wrapper, apiPromise };
} }

View file

@ -1,12 +1,12 @@
<template> <template>
<div class="container-fluid shadow rounded-3 p-0"> <div class="container-fluid shadow rounded-3 p-0">
<funnelHeader :imageSrc="funnelHeaderWidget.LogoImage" /> <funnelHeader ref="funnelHeader" />
<div class="select-car"> <div class="select-car">
<div class="select-car-form rounded text-center"> <div class="select-car-form rounded text-center">
<vehicleBanner :vehicleImageSrc="vehicleBannerWidget.GenericVehicleImage" /> <vehicleBanner ref="vehicleBanner" />
<funnelSubHeader <funnelSubHeader
:text="funnelSubHeaderWidget.HeaderText"
class="Header" class="Header"
ref="funnelSubHeader"
/> />
<yearQuestion v-model="selectedYear" ref="yearQuestion" /> <yearQuestion v-model="selectedYear" ref="yearQuestion" />
</div> </div>
@ -28,9 +28,6 @@ export default {
name: "vehicle-year", name: "vehicle-year",
data() { data() {
return { return {
funnelSubHeaderWidget: {},
funnelHeaderWidget: {},
vehicleBannerWidget: {},
selectedYear: null, selectedYear: null,
}; };
}, },
@ -54,12 +51,11 @@ export default {
}, },
]; ];
settleAllPromises(promiseResultMap).then((resultMap) => { settleAllPromises(promiseResultMap).then((resultMap) => {
// Call the "next" function to complete the transition to this page. // Call the "next" function to complete the transition to this page.
next((vm) => { next((vm) => {
vm.funnelSubHeaderWidget = resultMap.cmsContent.FunnelSubHeaderWidget[0]; vm.$refs.funnelSubHeader.initializeComponent(resultMap.cmsContent.FunnelSubHeaderWidget[0]);
vm.funnelHeaderWidget = resultMap.cmsContent.FunnelHeaderWidget[0]; vm.$refs.funnelHeader.initializeComponent(resultMap.cmsContent.FunnelHeaderWidget[0]);
vm.vehicleBannerWidget = resultMap.cmsContent.VehicleBannerWidget[0]; vm.$refs.vehicleBanner.initializeComponent(resultMap.cmsContent.VehicleBannerWidget[0]);
vm.$refs.yearQuestion.initializeComponent(resultMap.cmsContent.RadioQuestionWidget[0], resultMap.yearQuestionInitialData); vm.$refs.yearQuestion.initializeComponent(resultMap.cmsContent.RadioQuestionWidget[0], resultMap.yearQuestionInitialData);
}); });
}); });

View file

@ -10,8 +10,8 @@
<script> <script>
import buttonQuestion from "@/common-components/button-question/button-question"; import buttonQuestion from "@/common-components/button-question/button-question";
// Supporting files // Supporting files
import store from "@/store";
import { storeActions } from "@/constants/store-actions.js"; import { storeActions } from "@/constants/store-actions.js";
import baseMixin from "@/mixins/base-mixin.js";
export default { export default {
name: "year-question", name: "year-question",
@ -30,7 +30,7 @@ export default {
}, },
methods: { methods: {
loadInitialData() { loadInitialData() {
return store.dispatch(storeActions.GET_VEHICLE_YEARS, {}); return baseMixin.methods.dispatchNonBlockingStoreAction(storeActions.GET_VEHICLE_YEARS, {});
}, },
initializeComponent(cmsContent, initialData) { initializeComponent(cmsContent, initialData) {
this.questionText = cmsContent.QuestionText; this.questionText = cmsContent.QuestionText;

View file

@ -1,3 +1,4 @@
import store from "@/store";
import { storeActions } from "@/constants/store-actions.js"; import { storeActions } from "@/constants/store-actions.js";
import { storeMutations } from "@/constants/store-mutations.js"; import { storeMutations } from "@/constants/store-mutations.js";
import { navigationScenarios } from "@/router/router-constants/navigation-scenarios"; import { navigationScenarios } from "@/router/router-constants/navigation-scenarios";
@ -9,20 +10,13 @@ export default {
}; };
}, },
methods: { methods: {
// dispatchBlockingStoreAction(type, payload) { dispatchNonBlockingStoreAction(type, payload, encodePayload = true) {
// // globalMethods.showWaitingModal(true);
// return this.dispatchNonBlockingStoreAction(type, payload).finally(() => {
// // globalMethods.showWaitingModal(false);
// });
// },
dispatchNonBlockingStoreAction(type, payload, encodePayload = false) {
// Encode the payload if required // Encode the payload if required
if (encodePayload) { if (encodePayload) {
encodeUriData(payload); encodeUriData(payload);
} }
return this.$store.dispatch(type, payload); return store.dispatch(type, payload);
}, },
}, },
computed: { computed: {

View file

@ -1,38 +1,37 @@
import baseMixin from "@/mixins/base-mixin"; import baseMixin from "@/mixins/base-mixin";
import { storeActions } from "@/constants/store-actions.js"; import { storeActions } from "@/constants/store-actions.js";
import { widgetNames } from "@/constants/widget-names.js"; import { widgetNames } from "@/constants/widget-names.js";
import store from "@/store";
describe("baseMixin.js", () => { describe("baseMixin.js", () => {
test("dispatchNonblockingStoreAction: calls dispatch with type and payload", () => { test("dispatchNonblockingStoreAction: calls dispatch with type and payload", () => {
const mixIn = getMixInInstance({}); const mixIn = getMixInInstance({});
const type = {}; const type = '';
const payload = {}; const payload = {};
mixIn.methods.dispatchNonBlockingStoreAction(type, payload); mixIn.methods.dispatchNonBlockingStoreAction(type, payload);
expect(mixIn.methods.$store.dispatch).toBeCalledWith(type, payload); expect(store.dispatch).toBeCalledWith(type, payload);
}); });
test("dispatchNonblockingStoreAction: calls dispatch with type and payload, handles Uri encode", () => { test("dispatchNonblockingStoreAction: calls dispatch with type and payload, handles Uri encode", () => {
const mixIn = getMixInInstance({}); const mixIn = getMixInInstance({});
const type = {}; const type = '';
const payload = { make: "Alfa Romeo/Chrysler" }; const payload = { make: "Alfa Romeo/Chrysler" };
mixIn.methods.dispatchNonBlockingStoreAction(type, payload, true); mixIn.methods.dispatchNonBlockingStoreAction(type, payload, true);
expect(mixIn.methods.$store.dispatch).toBeCalledWith(type, payload); expect(store.dispatch).toBeCalledWith(type, payload);
}); });
}); });
function getMixInInstance({ isDispatchSuccess = true }) { function getMixInInstance({ isDispatchSuccess = true }) {
// Mock Store // Mock Store
const store = { const storeDispatch = jest.fn();
dispatch: jest.fn(),
};
if (isDispatchSuccess) { if (isDispatchSuccess) {
store.dispatch.mockReturnValue(Promise.resolve()); storeDispatch.mockReturnValue(Promise.resolve());
} else { } else {
store.dispatch.mockReturnValue(Promise.reject()); storeDispatch.mockReturnValue(Promise.reject());
} }
// Mock Route // Mock Route
@ -45,7 +44,7 @@ function getMixInInstance({ isDispatchSuccess = true }) {
// Attach mocks to mixin // Attach mocks to mixin
const baseMixIn = baseMixin; const baseMixIn = baseMixin;
baseMixIn.methods.$route = route; baseMixIn.methods.$route = route;
baseMixIn.methods.$store = store; store.dispatch = storeDispatch;
baseMixIn.methods.storeActions = storeActions; baseMixIn.methods.storeActions = storeActions;
baseMixIn.methods.widgetNames = widgetNames; baseMixIn.methods.widgetNames = widgetNames;

View file

@ -33,7 +33,6 @@ describe("list-button.vue", () => {
expect(label.attributes()).toEqual({ expect(label.attributes()).toEqual({
tabindex: "-1", tabindex: "-1",
for: "2023", for: "2023",
"aria-labelledby": "2023",
class: "d-flex flex-column justify-content-center py-3 px-4 last-item", class: "d-flex flex-column justify-content-center py-3 px-4 last-item",
"aria-checked": "false", "aria-checked": "false",
}); });

View file

@ -3,7 +3,7 @@
<!-- IMPORTANT: Refrain from using more than 4 horizontal buttons on desktop, 3 on mobile. --> <!-- IMPORTANT: Refrain from using more than 4 horizontal buttons on desktop, 3 on mobile. -->
<div v-if="isMultiSelect" class="list-group list-button-horizontal d-flex flex-column w-100 mb-2"> <div v-if="isMultiSelect" class="list-group list-button-horizontal d-flex flex-column w-100 mb-2">
<input type="checkbox" :id="buttonID" :name="groupName" :value="buttonID" :aria-required="isRequired"> <input type="checkbox" :id="buttonID" :name="groupName" :value="buttonID" :aria-required="isRequired">
<label tabindex="-1" aria-checked="false" :for="buttonID" :aria-labelledby="buttonID" class="d-flex flex-column justify-content-center py-3 px-4" :class="isFirstOrLastButton"> <label tabindex="-1" aria-checked="false" :for="buttonID" class="d-flex flex-column justify-content-center py-3 px-4" :class="isFirstOrLastButton">
<span class="m-0" :class="[this.textPosition]">{{buttonID}}</span> <span class="m-0" :class="[this.textPosition]">{{buttonID}}</span>
<span v-if="buttonLabelSubCopy" class="m-0 small" :class="[this.textPosition]">{{buttonLabelSubCopy}}</span> <span v-if="buttonLabelSubCopy" class="m-0 small" :class="[this.textPosition]">{{buttonLabelSubCopy}}</span>
<span v-if="screenReaderOnlyText" class="sr-only">{{screenReaderOnlyText}}</span> <span v-if="screenReaderOnlyText" class="sr-only">{{screenReaderOnlyText}}</span>
@ -12,7 +12,7 @@
</div> </div>
<div v-else class="col list-group list-button-horizontal d-flex flex-column mb-2"> <div v-else class="col list-group list-button-horizontal d-flex flex-column mb-2">
<input type="radio" :id="buttonID" :name="groupName" :value="buttonID" aria-required="true" @keyup.space="displayLoader()"/> <input type="radio" :id="buttonID" :name="groupName" :value="buttonID" aria-required="true" @keyup.space="displayLoader()"/>
<label tabindex="-1" aria-checked="false" :for="buttonID" :aria-labelledby="buttonID" class="d-flex flex-column justify-content-center py-3 px-4" :class="isFirstOrLastButton" @click="displayLoader()"> <label tabindex="-1" aria-checked="false" :for="buttonID" class="d-flex flex-column justify-content-center py-3 px-4" :class="isFirstOrLastButton" @click="displayLoader()">
<span class="m-0" :class="[this.textPosition]">{{buttonID}}</span> <span class="m-0" :class="[this.textPosition]">{{buttonID}}</span>
<span v-if="buttonLabelSubCopy" class="m-0 small" :class="[this.textPosition]">{{buttonLabelSubCopy}}</span> <span v-if="buttonLabelSubCopy" class="m-0 small" :class="[this.textPosition]">{{buttonLabelSubCopy}}</span>
<span v-if="screenReaderOnlyText" class="sr-only">{{screenReaderOnlyText}}</span> <span v-if="screenReaderOnlyText" class="sr-only">{{screenReaderOnlyText}}</span>
@ -42,7 +42,6 @@ export default {
}, },
data() { data() {
return { return {
isError: false,
isLoaderDisplayed: false, isLoaderDisplayed: false,
}; };
}, },