From 5f7840057a9c1ff8451ee31e47078ea298e4cae3 Mon Sep 17 00:00:00 2001 From: Chloe Herd Date: Tue, 13 May 2025 11:50:30 -0400 Subject: [PATCH] Progress bar cleanup --- .../funnel-header/progress-bar/progres-bar.spec.js | 8 ++++---- .../funnel-header/progress-bar/progress-bar.vue | 14 +++++--------- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/src/fmg-components/funnel-header/progress-bar/progres-bar.spec.js b/src/fmg-components/funnel-header/progress-bar/progres-bar.spec.js index a8d22cc2c..9970b266c 100644 --- a/src/fmg-components/funnel-header/progress-bar/progres-bar.spec.js +++ b/src/fmg-components/funnel-header/progress-bar/progres-bar.spec.js @@ -15,7 +15,7 @@ describe("progressBar", () => { }); // Assert - expect(wrapper.vm.getProgress()).toBe(0); + expect(wrapper.vm.progress).toBe(0); wrapper.unmount(); }); }); @@ -33,7 +33,7 @@ describe("progressBar", () => { }); // Assert - expect(wrapper.vm.getProgress()).toBe(4); + expect(wrapper.vm.progress).toBe(4); wrapper.unmount(); }); }); @@ -51,7 +51,7 @@ describe("progressBar", () => { }); // Assert - expect(wrapper.vm.getProgress()).toBe(48); + expect(wrapper.vm.progress).toBe(48); wrapper.unmount(); }); }); @@ -69,7 +69,7 @@ describe("progressBar", () => { }); // Assert - expect(wrapper.vm.getProgress()).toBe(100); + expect(wrapper.vm.progress).toBe(100); wrapper.unmount(); }); }); diff --git a/src/fmg-components/funnel-header/progress-bar/progress-bar.vue b/src/fmg-components/funnel-header/progress-bar/progress-bar.vue index da370e415..c25476338 100644 --- a/src/fmg-components/funnel-header/progress-bar/progress-bar.vue +++ b/src/fmg-components/funnel-header/progress-bar/progress-bar.vue @@ -10,15 +10,11 @@ import { getProgressBarPercentage } from "@/constants/progress-bar-mapper"; export default { name: "progressBar", - data() { - return { - progress: this.getProgress(), - }; - }, - methods: { - getProgress() { - var pageName = this.pageName; - return getProgressBarPercentage(pageName); + data() {}, + computed: { + progress() { + console.log(`Progress: ${this.pageName} - ${getProgressBarPercentage(this.pageName)}`); + return getProgressBarPercentage(this.pageName); }, }, };