From 57e520d2c45aa3d015f9e01bd108c17922b64e8d Mon Sep 17 00:00:00 2001
From: Chloe Herd <chloe.herd@safelite.com>
Date: Thu, 7 Sep 2023 17:24:26 -0400
Subject: [PATCH] Move hard-coded values to constants file

---
 src/constants/payment-method-constants.js     | 13 ++++++++++
 .../payment-method-question.vue               | 24 +++++--------------
 src/layouts/payment-method/payment-method.vue |  7 +++---
 3 files changed, 23 insertions(+), 21 deletions(-)
 create mode 100644 src/constants/payment-method-constants.js

diff --git a/src/constants/payment-method-constants.js b/src/constants/payment-method-constants.js
new file mode 100644
index 000000000..807e44c0e
--- /dev/null
+++ b/src/constants/payment-method-constants.js
@@ -0,0 +1,13 @@
+export const paymentMethods = {
+    NONE: null,
+    LATER: "Later",
+    CREDIT_CARD: "CreditCard",
+    PAYPAL: "Paypal",
+    AFTERPAY: "Afterpay",
+};
+
+export const paymentTimes = {
+    NONE: null,
+    ADVANCE: "Advance",
+    LATER: "Later",
+};
diff --git a/src/layouts/payment-method/payment-method-question/payment-method-question.vue b/src/layouts/payment-method/payment-method-question/payment-method-question.vue
index 72d1c7732..ecd461bec 100644
--- a/src/layouts/payment-method/payment-method-question/payment-method-question.vue
+++ b/src/layouts/payment-method/payment-method-question/payment-method-question.vue
@@ -23,19 +23,7 @@
 <script>
 import buttonQuestion from "@/digital-components/button-question/button-question";
 
-const paymentMethods = {
-    NONE: null,
-    LATER: "Later",
-    CREDIT_CARD: "CreditCard",
-    PAYPAL: "Paypal",
-    AFTERPAY: "Afterpay",
-};
-
-const payTimes = {
-    NONE: null,
-    ADVANCE: "Advance",
-    LATER: "Later",
-};
+import { paymentMethods, paymentTimes } from "@/constants/payment-method-constants";
 
 export default {
     name: "payment-method-question",
@@ -50,14 +38,14 @@ export default {
     methods: {
         inferPayInAdvanceValue() {
             if (this.modelValue === paymentMethods.NONE) {
-                return payTimes.NONE;
+                return paymentTimes.NONE;
             }
 
             if (this.modelValue === paymentMethods.LATER) {
-                return payTimes.LATER;
+                return paymentTimes.LATER;
             }
 
-            return payTimes.ADVANCE;
+            return paymentTimes.ADVANCE;
         },
         getAnswersNullSafe(widgetName) {
             const rawData = this.getCmsContent(widgetName, "Answers");
@@ -79,7 +67,7 @@ export default {
             },
         },
         shouldDisplaySecondaryQuestion() {
-            return this.paymentTime === payTimes.ADVANCE;
+            return this.paymentTime === paymentTimes.ADVANCE;
         },
         paymentTimeQuestionText() {
             return this.getCmsContent("PaymentTimeWidget", "QuestionText");
@@ -114,7 +102,7 @@ export default {
     },
     watch: {
         paymentTime(newValue) {
-            if (newValue === payTimes.LATER) {
+            if (newValue === paymentTimes.LATER) {
                 this.selectedMethod = paymentMethods.LATER;
             } else {
                 this.selectedMethod = paymentMethods.NONE;
diff --git a/src/layouts/payment-method/payment-method.vue b/src/layouts/payment-method/payment-method.vue
index 3d8486234..b74e0b220 100644
--- a/src/layouts/payment-method/payment-method.vue
+++ b/src/layouts/payment-method/payment-method.vue
@@ -27,6 +27,7 @@ import paymentMethodQuestion from "@/layouts/payment-method/payment-method-quest
 
 import { fetchCmsContentForPage } from "@/helpers/cms-content-helper";
 import { settleAllPromises } from "@/helpers/layout-helper";
+import { paymentMethods } from "@/constants/payment-method-constants";
 
 // Validation
 import { Form } from "vee-validate";
@@ -68,11 +69,11 @@ export default {
     computed: {
         customCtaCopy() {
             switch (this.paymentMethod) {
-                case "CreditCard":
+                case paymentMethods.CREDIT_CARD:
                     return "Continue to checkout";
-                case "Paypal":
+                case paymentMethods.PAYPAL:
                     return "Continue to Paypal";
-                case "Afterpay":
+                case paymentMethods.AFTERPAY:
                     return "Continue to Afterpay";
                 default:
                     return null;