From f2b4cd5e90e9fcdbfd89cb503baafc86022c01bb Mon Sep 17 00:00:00 2001 From: Adam Caouette Date: Wed, 19 Feb 2025 15:11:01 -0500 Subject: [PATCH 1/6] CASH-153: updates after tech review --- ...-2.vue => date-picker-for-pricing-by-day.vue} | 14 +++++++++++--- src/layouts/schedule/schedule.vue | 16 +++++++++------- 2 files changed, 20 insertions(+), 10 deletions(-) rename src/experiment-components/{date-picker-2.vue => date-picker-for-pricing-by-day.vue} (99%) diff --git a/src/experiment-components/date-picker-2.vue b/src/experiment-components/date-picker-for-pricing-by-day.vue similarity index 99% rename from src/experiment-components/date-picker-2.vue rename to src/experiment-components/date-picker-for-pricing-by-day.vue index 414f794e0..df4c9b140 100644 --- a/src/experiment-components/date-picker-2.vue +++ b/src/experiment-components/date-picker-for-pricing-by-day.vue @@ -99,8 +99,16 @@ // Supporting files import loader from "@/ux-components/loader/loader"; import store from "@/store"; -import { TIMINGFUNC_MAP, BUFFER_OFFSET, MONTHS_OF_YEAR } from "@/digital-components/date-picker/mixins/constants"; -import { selectableDaysOptions, requiredParameter, forceTwoDigitString } from "@/digital-components/date-picker/mixins/helpers"; +import { + TIMINGFUNC_MAP, + BUFFER_OFFSET, + MONTHS_OF_YEAR, +} from "@/digital-components/date-picker/mixins/constants"; +import { + selectableDaysOptions, + requiredParameter, + forceTwoDigitString, +} from "@/digital-components/date-picker/mixins/helpers"; import { convertDateToDateString, convertDateStringToDate, @@ -111,7 +119,7 @@ import { deepClone } from "@/helpers/object-helper"; import { v4 as uuidv4 } from "uuid"; export default { - name: "datePicker2", + name: "datePickerForPricingByDay", data() { return { isLoading: true, diff --git a/src/layouts/schedule/schedule.vue b/src/layouts/schedule/schedule.vue index 0853664e2..27587d08c 100644 --- a/src/layouts/schedule/schedule.vue +++ b/src/layouts/schedule/schedule.vue @@ -18,8 +18,8 @@ marginTopSizeOverride="1" /> - - Date: Fri, 21 Feb 2025 18:15:56 +0530 Subject: [PATCH 2/6] CASH-151 remove extra spacing from service packages tiles --- src/experiment-components/service-package-radio.vue | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/experiment-components/service-package-radio.vue b/src/experiment-components/service-package-radio.vue index a3bfd9937..4aae00bc0 100644 --- a/src/experiment-components/service-package-radio.vue +++ b/src/experiment-components/service-package-radio.vue @@ -233,8 +233,7 @@ export default { min-height: 52px; max-height: 126px; @include media-breakpoint-up(md) { - max-height: 500px; - padding-bottom: 3rem; + max-height: 500px; } transition: max-height 0.25s ease-in; From 2683e837a6b34f27742daaec77478549c8620d88 Mon Sep 17 00:00:00 2001 From: Bryan Mauger Date: Fri, 21 Feb 2025 12:44:25 -0500 Subject: [PATCH 3/6] CASH-132 add experiment. --- src/constants/experiments.js | 1 + src/experiment-components/donation-block.vue | 16 +++++++++++++--- src/layouts/confirmation/confirmation.vue | 8 +++++++- 3 files changed, 21 insertions(+), 4 deletions(-) diff --git a/src/constants/experiments.js b/src/constants/experiments.js index 696707827..8209cae9c 100644 --- a/src/constants/experiments.js +++ b/src/constants/experiments.js @@ -19,6 +19,7 @@ const experimentSettings = { INSURANCE_TAB_TO_DISPLAY_THRESHOLD_EXTERNAL: "NextGen_ExternalInsuranceTabDisplayThreshold", DISPLAY_MSR: "DisplayMSR", PRICING_BY_DAY: "DisplayPricingByDay", + FOSTER_LOVE: "DisplayFosterLove", }; const experimentTriggers = { diff --git a/src/experiment-components/donation-block.vue b/src/experiment-components/donation-block.vue index 211cc3e28..10ebec7a5 100644 --- a/src/experiment-components/donation-block.vue +++ b/src/experiment-components/donation-block.vue @@ -20,7 +20,9 @@ target="_blank" /> -
+
@@ -31,9 +33,17 @@ :value="donationValues[0]" checked /> - + - +
diff --git a/src/layouts/confirmation/confirmation.vue b/src/layouts/confirmation/confirmation.vue index b839ae1ad..8221a933a 100644 --- a/src/layouts/confirmation/confirmation.vue +++ b/src/layouts/confirmation/confirmation.vue @@ -64,7 +64,7 @@ :isItac="isItac" :isNoComp="isNoComp" /> -
+
Date: Fri, 21 Feb 2025 16:24:51 -0500 Subject: [PATCH 4/6] CASH-151 style updates. --- .../service-package-radio.vue | 41 ++++++++++++++++--- 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/src/experiment-components/service-package-radio.vue b/src/experiment-components/service-package-radio.vue index 4aae00bc0..42b96a17b 100644 --- a/src/experiment-components/service-package-radio.vue +++ b/src/experiment-components/service-package-radio.vue @@ -201,19 +201,44 @@ export default { If this experiment wins, move this to package-label ::before/::after below */ &:before { - top: 15px; + top: 0.9375rem; } &:after { - top: 30px; + top: 1.875rem; + } + @include media-breakpoint-up(lg) { + &:before { + top: .5rem; + } + &:after { + top: 1.875rem; + } + p { + span { + align-self: center; + } + } } } + .package-label.pricing-by-day-pkg-lbl-ins { &:before { - top: 5px; + top: .3125rem; } &:after { - top: 20px; + top: 1.25rem; + } + } + + + .package-label.pricing-by-day-pkg-lbl { + &:before { + top: 0.9375rem; + @include media-breakpoint-up(lg) { + top: .3125rem; + } + } + &:after { + top: 1.25rem; } } @@ -350,7 +375,8 @@ export default { &.pricing-info-pricing-by-day { text-align: end; color: $green; - font-size: 0.875rem; + font-size: 1rem; + line-height: 1; span.strikethrough-price { text-decoration: line-through; font-size: 0.75rem; @@ -376,6 +402,7 @@ export default { justify-content: flex-end; align-items: center; align-self: flex-start; + line-height: 1; div.strikethrough-discount-price { display: inline; text-decoration: line-through; @@ -392,8 +419,12 @@ export default { div.discount-price { color: $green; display: inline; + font-size: 1rem; } } + .caption { + font-size: 0.625rem; + } } ul { margin: 1rem 0 0 -5px; From a8a0724b842f42d8d3b460c99307cfb3d242fb62 Mon Sep 17 00:00:00 2001 From: Bryan Mauger Date: Sat, 22 Feb 2025 14:13:56 -0500 Subject: [PATCH 5/6] CSS update. --- src/experiment-components/service-package-radio.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/experiment-components/service-package-radio.vue b/src/experiment-components/service-package-radio.vue index 42b96a17b..3b9e5d9c9 100644 --- a/src/experiment-components/service-package-radio.vue +++ b/src/experiment-components/service-package-radio.vue @@ -211,7 +211,7 @@ export default { top: .5rem; } &:after { - top: 1.875rem; + top: 1.4375rem; } p { span { From 8fbe2173aa48bfb43f3d6627eff4ce7a5553412a Mon Sep 17 00:00:00 2001 From: Bryan Mauger Date: Sun, 23 Feb 2025 15:39:12 -0500 Subject: [PATCH 6/6] Fix unit test. --- src/layouts/confirmation/confirmation.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/layouts/confirmation/confirmation.vue b/src/layouts/confirmation/confirmation.vue index 8221a933a..c87da58dd 100644 --- a/src/layouts/confirmation/confirmation.vue +++ b/src/layouts/confirmation/confirmation.vue @@ -245,7 +245,7 @@ export default { }; }, computed: { - displayFosterLove() { + DisplayFosterLove() { return experimentMixin.methods.hasSettingEqualTo( experimentSettings.FOSTER_LOVE, "true"