From 53adf2f939ccf144ec903f6d3d29f4dfbca08fe3 Mon Sep 17 00:00:00 2001 From: Katie Date: Thu, 8 Dec 2022 13:25:22 -0500 Subject: [PATCH] CSR-747 Cleanup --- src/constants/store-actions.js | 3 +- src/global-methods.js | 9 +- .../heritage-integration/navigation-helper.js | 1 - src/layouts/estimate/estimate.vue | 1 - src/layouts/quote/quote.vue | 54 --------- src/layouts/vehicle-damage/vehicle-damage.vue | 3 +- src/mixins/vehicle-questions-mixin.js | 3 - src/router/index.js | 5 - src/store/index.js | 108 +----------------- 9 files changed, 5 insertions(+), 182 deletions(-) diff --git a/src/constants/store-actions.js b/src/constants/store-actions.js index d023db8c3..108b64941 100644 --- a/src/constants/store-actions.js +++ b/src/constants/store-actions.js @@ -40,8 +40,7 @@ const storeActions = { RUN_EXPERIMENTS_FOR_TRIGGER: "runExperimentsForTrigger", CLEAR_VIN: "clearVin", RESET_SAVE_SESSION_PROMISE: "resetSaveSessionPromise", - GET_PRICES_FOR_LINE_ITEMS: "getPricesForLineItems", - + // DEPENDENCY MUTATIONS RESET_DAMAGE_STATE_AND_DEPENDENCIES: "resetDamageAndDependencies", RESET_REGISTRATION_STATE_AND_DEPENDENCIES: "resetRegistrationAndDependencies", diff --git a/src/global-methods.js b/src/global-methods.js index ffab23425..14e5cca0e 100644 --- a/src/global-methods.js +++ b/src/global-methods.js @@ -9,14 +9,7 @@ import { headerKeys } from "@/constants/header-keys"; export default { callHttpClient({ method, endpoint, payload, logApiCall = true }) { return new Promise((resolve, reject) => { - let cfDistroUrl = applicationConfig.CONSUMER_CF_DISTRO; - - if (endpoint.includes("/order/")) { - cfDistroUrl = "https://localhost:44346"; - } else if (endpoint.includes("/price/")) { - cfDistroUrl = "https://localhost:44372"; - } - + const cfDistroUrl = applicationConfig.CONSUMER_CF_DISTRO; const payloadAndAnalyticsData = Object.assign({}, payload, { AppName: "FixMyGlass" }); const headers = { [headerKeys.EXPERIMENT]: JSON.stringify(store.getters.experimentSettings), diff --git a/src/helpers/heritage-integration/navigation-helper.js b/src/helpers/heritage-integration/navigation-helper.js index 090abac64..d489b3f20 100644 --- a/src/helpers/heritage-integration/navigation-helper.js +++ b/src/helpers/heritage-integration/navigation-helper.js @@ -49,7 +49,6 @@ export async function navigateToHeritageFunnel({ shouldSaveSession = true, loadi await saveSession(); } - // TODO KO Can we trigger loading modal from here? if (loadingModal && loadingModal.showModal) { loadingModal.showModal(); } diff --git a/src/layouts/estimate/estimate.vue b/src/layouts/estimate/estimate.vue index 49aecee76..403c4eab4 100644 --- a/src/layouts/estimate/estimate.vue +++ b/src/layouts/estimate/estimate.vue @@ -208,7 +208,6 @@ export default { this.displayNonServiceableZipAlert = false; const payment = this.$store.getters.payment; - // TODO KO If coverageStatus is null, they haven't gone to heritage yet... I think const vehicleChangedDuringPolicyLookupInHeritage = payment.isInsurance && payment.insuranceCoverage.coverageStatus; if (vehicleChangedDuringPolicyLookupInHeritage) { diff --git a/src/layouts/quote/quote.vue b/src/layouts/quote/quote.vue index 21b2290e2..20604c91e 100644 --- a/src/layouts/quote/quote.vue +++ b/src/layouts/quote/quote.vue @@ -8,7 +8,6 @@ :displayGenericVehicleImage="false" />
- { vm.setCmsContent(cmsContent); - vm.availableLineItems = [ - { - partNumber: "001", - Description: "Windshield with Recal", - partType: "Windshield", - Quantity: "1", - BasePartNumber: "001", - Color: "Green", - CanSafeliteRecalibrate: true, - price: 350.22, - }, - { - partNumber: "SBB16", - description: "SAFELITE BEAM BLADE 16", - partType: "FRONT WIPER", - price: 32.64, - }, - { - partNumber: "A DISPOSAL FEE", - partType: "DISPOSAL FEE", - price: 15.0, - }, - { - partNumber: "SBB26", - description: "SAFELITE BEAM BLADE 26", - partType: "FRONT WIPER", - price: 53.04, - }, - { - partNumber: "SBBR12A", - description: "SAFELITE REAR BLADE 12A", - partType: "REAR WIPER", - price: 24.48, - }, - { - partNumber: "RAIN DEFENSE", - description: null, - partType: "RAIN DEFENSE", - price: 35.5, - }, - { - partNumber: "RECAL STATIC", - Description: "Recalibration", - partType: "recalibration", - Quantity: "1", - price: 150.0, - }, - ]; - vm.supportingItems = resultMap.supportingItems; vm.availableLineItems = pricingResults; vm.isInsuranceSelected = vm.getDefaultIsInsuranceSelectedValue(); @@ -180,10 +130,6 @@ export default { }; }, methods: { - pricingTest() { - const test = this.dispatchStoreAction(storeActions.GET_PRICES_FOR_LINE_ITEMS); - console.log({ test }); - }, arePagePrerequisitesValid() { return ( store.getters.order.damage.isRepair || diff --git a/src/layouts/vehicle-damage/vehicle-damage.vue b/src/layouts/vehicle-damage/vehicle-damage.vue index a07124710..c72e99449 100644 --- a/src/layouts/vehicle-damage/vehicle-damage.vue +++ b/src/layouts/vehicle-damage/vehicle-damage.vue @@ -329,7 +329,8 @@ export default { navigateForward() { const payment = store.getters.payment; - if (payment.isInsurance && payment.insuranceCoverage.coverageStatus === "VERIFIED") { + const vehicleChangedDuringPolicyLookupInHeritage = payment.isInsurance && payment.insuranceCoverage.coverageStatus && payment.insuranceCoverage.coverageStatus !== ""; + if (vehicleChangedDuringPolicyLookupInHeritage) { if (store.getters.damage.isRepair) { this.$router.navigateWithSaving( this.navigationScenarios.CLICKED_FORWARD_WITH_REPAIR_AND_VERIFIED_INSURANCE, diff --git a/src/mixins/vehicle-questions-mixin.js b/src/mixins/vehicle-questions-mixin.js index c7001ed48..08d9fa790 100644 --- a/src/mixins/vehicle-questions-mixin.js +++ b/src/mixins/vehicle-questions-mixin.js @@ -450,9 +450,6 @@ export default { self.$store.commit(storeMutations.UPDATE_GLASS_PARTS, collectedGlassParts); const payment = self.$store.getters.payment; - // TODO KO If coverageStatus is null, they haven't been to heritage yet... - // TODO KO what happens if you go to CCPolicyInfo (insurance), go back to vin-lookup, and go forward. - // Does it skip quote? shouldGoToHeritageQuote || (payment.isInsurance && payment.insuranceCoverage.isVerified) ? navigateToHeritageFunnel({ loadingModal: self.$refs.loadingModal }) diff --git a/src/router/index.js b/src/router/index.js index 411bf58fe..67961ece2 100644 --- a/src/router/index.js +++ b/src/router/index.js @@ -290,11 +290,6 @@ function navigateToUrl(url, optionalQuery = {}) { externalUrl.searchParams.append(queryKey, optionalQuery[queryKey]); } - externalUrl.searchParams.append( - "experiments", - "ConceptFunnel=ConceptFunnel_V1=ConceptFunnel_TEST=true" - ); - window.location.assign(externalUrl); } diff --git a/src/store/index.js b/src/store/index.js index fd177326d..1aa3897f7 100644 --- a/src/store/index.js +++ b/src/store/index.js @@ -360,7 +360,6 @@ export const mutations = { state.order.payment.isInsurance = sessionInformation.order.payment.isInsurance; state.order.payment.insuranceCoverage.isVerified = sessionInformation?.order.payment.insuranceCoverage.isVerified; - // TODO KO CSR-747 double check this state.order.payment.insuranceCoverage.coverageStatus = sessionInformation?.insuranceInfo?.coverageStatus; @@ -907,7 +906,7 @@ export const actions = { const carId = context.getters.vehicle.carId; const isRepair = context.getters.damage.isRepair; const numberOfChips = context.getters.damage.numberOfChips; - const parentAccountNumber = "167132"; //context.getters.order.accountNumber.toString(); + const parentAccountNumber = context.getters.order.accountNumber.toString(); return globalMethods.callHttpClient({ method: endpoints.GetSupportingItems.method, endpoint: endpoints.GetSupportingItems.url, @@ -1063,111 +1062,6 @@ export const actions = { }); }, - // START Pricing service call actions - getPricesForLineItems(context) { - const vehicle = context.getters.vehicle; - const lineItems = { - glassParts: [ - { - partNumber: "FW04186GTYN", - description: "solar, soundproofing, lane keep assist", - color: "Green Tint", - requiresRecalibration: true, - requiresCapabilityQuestions: false, - recalibrationType: "DUAL", - childParts: [ - { - partNumber: "GGG 3563 KIT", - }, - ], - }, - { - partNumber: "FD25457GTYN", - description: "solar, driver side, rear", - color: "Green Tint", - requiresRecalibration: false, - requiresCapabilityQuestions: false, - recalibrationType: "", - childParts: null, - }, - { - partNumber: "FD27090GTYN", - description: "solar, driver side, front", - color: "Green Tint", - requiresRecalibration: false, - requiresCapabilityQuestions: false, - recalibrationType: "", - childParts: null, - }, - { - partNumber: "FB25460GTYN", - description: "heated glass, solar", - color: "Green Tint", - requiresRecalibration: false, - requiresCapabilityQuestions: false, - recalibrationType: "", - childParts: null, - }, - ], - supportingItems: [ - { - partNumber: "PART1", - description: "solar, soundproofing, lane keep assist", - color: "Green Tint", - requiresRecalibration: true, - requiresCapabilityQuestions: false, - recalibrationType: "DUAL", - childParts: [ - { - partNumber: "GGG 3563 KIT", - }, - ], - }, - { - partNumber: "PART2", - description: "solar, driver side, rear", - color: "Green Tint", - requiresRecalibration: false, - requiresCapabilityQuestions: false, - recalibrationType: "", - childParts: null, - }, - ], - }; - - const commaSeparatedPartNumbers = Object.values(context.getters.order.lineItems) - .map((lineItemGroup) => lineItemGroup.map((lineItem) => lineItem.partNumber)) - .flat() - .join(","); - - console.log({ - lineItems: Object.values(lineItems) - .map((lineItemGroup) => lineItemGroup.map((lineItem) => lineItem.partNumber)) - .flat() - .join(","), - commaSeparatedPartNumbers, - }); - - // context.getters.order.lineItems.map(lineItemGroup => ) - - return globalMethods - .callHttpClient({ - method: endpoints.GetPriceForLineItems.method, - endpoint: `${endpoints.GetPriceForLineItems.url}?CTU=01833&carId=${vehicle.carId}&make=${vehicle.make}&model=${vehicle.model}&year=${vehicle.year}&EON=S169140586&zipCode=34785&lineItems=${commaSeparatedPartNumbers}&parentAccountNumber=167132`, - }) - .then((response) => { - // Flatten location and name properties - - // clear the state if the existing EON does not equal what is returned from loadSession - // if (context.state.order.eon && context.state.order.eon != response.data.eon) { - // context.commit(storeMutations.RESET_STATE); - // } - // context.commit(storeMutations.UPDATE_STATE_WITH_ORDER_INFORMATION, response.data); - return response; - }); - }, - // END Pricing service call actions - // Business domain actions // Vehicle