From cc12098c197269a777ba4dc8a31ee41bbf73253d Mon Sep 17 00:00:00 2001 From: credelinghuys Date: Tue, 17 Mar 2026 15:41:01 -0400 Subject: [PATCH] CASH-1951: Service Package Discount decom --- src/constants/experiments.js | 2 - src/constants/part-type-strings.js | 1 - src/layouts/quote/quote.spec.js | 86 ------------------- .../service-package-question.spec.js | 8 +- src/mixins/analytics-mixin.js | 4 +- 5 files changed, 3 insertions(+), 98 deletions(-) diff --git a/src/constants/experiments.js b/src/constants/experiments.js index f8691fc46..b9f38ca36 100644 --- a/src/constants/experiments.js +++ b/src/constants/experiments.js @@ -19,8 +19,6 @@ const experimentSettings = { PIA_INSURANCE: "DisplayPIAInsurance", SUBMIT_ORDER_ENABLE_PIA: "SubmitOrder_Enable_PIA", IS_EMAIL_OPTIONAL: "isEmailOptional", - SERVICE_PACKAGE_DISCOUNT: "OfferServicePackageDiscount", - PROMO_ON_PACKAGE: "Offer_Promo_On_Pkg", RECAL_PRICE_REMOVE: "RecalPriceRemove", INSURANCE_TAB_TO_DISPLAY_THRESHOLD_INTERNAL: "NextGen_InternalInsuranceTabDisplayThreshold", INSURANCE_TAB_TO_DISPLAY_THRESHOLD_EXTERNAL: "NextGen_ExternalInsuranceTabDisplayThreshold", diff --git a/src/constants/part-type-strings.js b/src/constants/part-type-strings.js index 0118c0b2c..7f62088d5 100644 --- a/src/constants/part-type-strings.js +++ b/src/constants/part-type-strings.js @@ -9,7 +9,6 @@ const partTypeStrings = { MOBILE_FEE: "MOBILE FEE", REPAIR_FEE: "REPAIR FEE", EARLY_BIRD: "EARLY BIRD", - SERVICE_PACKAGE_DISCOUNT: "SERVICE PACKAGE DISCOUNT", QUOTE_PAGE_DISCOUNT: "QUOTE PAGE DISCOUNT", DONATION: "DONATION", WINDSHIELD: "WINDSHIELD", diff --git a/src/layouts/quote/quote.spec.js b/src/layouts/quote/quote.spec.js index d9a36f11d..8042b8f24 100644 --- a/src/layouts/quote/quote.spec.js +++ b/src/layouts/quote/quote.spec.js @@ -100,9 +100,6 @@ const mockExperimentSettings = experimentSettings; jest.mock("@/mixins/experiment-mixin.js", () => ({ methods: { getSettingValue(settingName) { - if (settingName === mockExperimentSettings.SERVICE_PACKAGE_DISCOUNT) { - return true; - } if ( settingName === mockExperimentSettings.INSURANCE_TAB_TO_DISPLAY_THRESHOLD_INTERNAL ) { @@ -367,9 +364,6 @@ describe("quote.vue", () => { vehicle: { cardId: "123", }, - experimentSettings: { - settingName: "SERVICE_PACKAGE_DISCOUNT", - }, }; const { wrapper } = setupMocks({}); @@ -391,59 +385,6 @@ describe("quote.vue", () => { // This should have its own test //expect(vm.isInsuranceSelected !== null).toBe(true); }); - test("Returns true if service package discount setting is true", async () => { - //Arrange - store.getters = { - lineItems: { - glassParts: ["item", "item2"], - }, - pageData: jest.fn((page) => { - if (page === "quote") { - return { saveProgressPopupSkipped: true }; - } - return {}; - }), - applicationUser: { - experiments: [], - }, - order: { - lineItems: { - glassParts: ["item", "item2"], - }, - payment: {}, - customer: { - emailAddress: "test@test.com", - }, - serviceLocation: { - zipCode: "12345", - zipCodeCtu: "value", - }, - }, - vehicle: { - cardId: "123", - }, - experimentSettings: { - settingName: "SERVICE_PACKAGE_DISCOUNT", - }, - }; - const { wrapper } = setupMocks({}); - - wrapper.vm.$route = { query: { isInsurance: "false" } }; - - const isServicePackageDiscount = experimentMixin.methods.getSettingValue( - experimentSettings.SERVICE_PACKAGE_DISCOUNT - ); - - //Act - await quote.beforeRouteEnter.call( - wrapper.vm, - { query: { fmgPage: "quote" } }, - undefined, - (c) => c(wrapper.vm) - ); - //Assert - expect(isServicePackageDiscount).toBe(true); - }); test("should default to insurance if query param 'isInsurance' is true", async () => { //Arrange store.getters = { @@ -476,9 +417,6 @@ describe("quote.vue", () => { vehicle: { cardId: "123", }, - experimentSettings: { - settingName: "SERVICE_PACKAGE_DISCOUNT", - }, }; const { wrapper } = setupMocks({}); wrapper.vm.$route = { query: { isInsurance: "true" } }; @@ -526,9 +464,6 @@ describe("quote.vue", () => { vehicle: { cardId: "123", }, - experimentSettings: { - settingName: "SERVICE_PACKAGE_DISCOUNT", - }, }; mockTierOnePrice = 200; const { wrapper } = setupMocks({}); @@ -577,9 +512,6 @@ describe("quote.vue", () => { vehicle: { cardId: "123", }, - experimentSettings: { - settingName: "SERVICE_PACKAGE_DISCOUNT", - }, }; const { wrapper } = setupMocks({}); // Ensure that query param isn't overriding selection @@ -628,9 +560,6 @@ describe("quote.vue", () => { vehicle: { cardId: "123", }, - experimentSettings: { - settingName: "SERVICE_PACKAGE_DISCOUNT", - }, }; const { wrapper } = setupMocks({}); // Ensure that query param isn't overriding selection @@ -680,9 +609,6 @@ describe("quote.vue", () => { vehicle: { cardId: "123", }, - experimentSettings: { - settingName: "SERVICE_PACKAGE_DISCOUNT", - }, }; mockTierOnePrice = 200; const { wrapper } = setupMocks({}); @@ -734,9 +660,6 @@ describe("quote.vue", () => { vehicle: { cardId: "123", }, - experimentSettings: { - settingName: "SERVICE_PACKAGE_DISCOUNT", - }, }; mockTierOnePrice = 505; const { wrapper } = setupMocks({}); @@ -786,9 +709,6 @@ describe("quote.vue", () => { vehicle: { cardId: "123", }, - experimentSettings: { - settingName: "SERVICE_PACKAGE_DISCOUNT", - }, }; mockTierOnePrice = 505; const { wrapper } = setupMocks({}); @@ -839,9 +759,6 @@ describe("quote.vue", () => { vehicle: { cardId: "123", }, - experimentSettings: { - settingName: "SERVICE_PACKAGE_DISCOUNT", - }, }; const { wrapper } = setupMocks({}); wrapper.vm.$route = { query: null }; @@ -962,9 +879,6 @@ describe("quote.vue", () => { vehicle: { cardId: "123", }, - experimentSettings: { - settingName: "SERVICE_PACKAGE_DISCOUNT", - }, }; // Set up the component diff --git a/src/layouts/quote/service-package-question/service-package-question.spec.js b/src/layouts/quote/service-package-question/service-package-question.spec.js index b3e4742e7..f87faeec8 100644 --- a/src/layouts/quote/service-package-question/service-package-question.spec.js +++ b/src/layouts/quote/service-package-question/service-package-question.spec.js @@ -31,14 +31,10 @@ const mockExperimentSettings = experimentSettings; jest.mock("@/mixins/experiment-mixin.js", () => ({ methods: { getSettingValue(settingName) { - if (settingName === mockExperimentSettings.PROMO_ON_PACKAGE) { - return true; - } + return false; }, hasSetting(settingName) { - if (settingName === mockExperimentSettings.PROMO_ON_PACKAGE) { - return false; - } + return false; }, hasSettingEqualTo(settingName, settingValue) { return false; diff --git a/src/mixins/analytics-mixin.js b/src/mixins/analytics-mixin.js index a3b599331..781c0cb34 100644 --- a/src/mixins/analytics-mixin.js +++ b/src/mixins/analytics-mixin.js @@ -807,9 +807,7 @@ export default { coupons = promoString; } const additionalDiscounts = submittedOrder.lineItems?.supportingItems?.find( - (x) => - x.partType == partTypeStrings.SERVICE_PACKAGE_DISCOUNT || - x.partType == partTypeStrings.QUOTE_PAGE_DISCOUNT + (x) => x.partType == partTypeStrings.QUOTE_PAGE_DISCOUNT ); if (isDefined(additionalDiscounts)) { if (coupons) {