Merge remote-tracking branch 'origin/develop' into feature/CSR-700

jest.config.js

@@ -11,13 +11,9 @@ module.exports = {
     "!src/constants/*.js",
     "!src/router/**/*.js",
     "!src/helpers/unit-test-helper.js",
-    "!src/layouts/vehicle-damage/windshield-damage-type-question/windshield-damage-type-question.vue",
     "!src/layouts/vehicle-damage/windshield-options/windshield-options.vue",
     "!src/layouts/part-questions/**/*.vue",
-    "!src/layouts/reveal/**/*.vue",
+    "!src/layouts/reveal/**/*.vue"
-    // TODO REMOVE THESE AFTER WRITING UNIT TESTS 
-    "!src/ux-components/alert/alert.vue",
-    "!src/helpers/validation-rules.js",
     // END
   ], // ! means exclude from coverage.
   testMatch: ["**/*.spec.(js|jsx|ts|tsx)|**/__tests__/*.(js|jsx|ts|tsx)"],

src/common-components/textbox-question/textbox-question.spec.js

@@ -54,34 +54,6 @@ describe("textboxQuestion.vue", () => {
 
   }); 
 
-  it("Should render the 'questionText' data value with '⁠' after the first character of each word in the label text when disableAutoFill is true.", async () => {
-    // Arrange
-    const wrapper = shallowMount(textboxQuestion, {
-      global: {
-        directives: {
-          maska: maska,
-        }
-      },
-      propsData: {
-        disableAutoFill: true,
-      },
-      mixins: [mockMixin]
-    });
-
-    // Mock CMS content ...
-    // Trust me, the below instance of the string "Q⁠uestion Text" actually has the ⁠ in it. You just can't see it
-    // Don't believe me? Copy and paste it into Google. Then inspect the search field element in Dev Tools, 
-    // you will see "Q⁠uestion T⁠ext"
-    const expectedQuestionText = "Q⁠uestion T⁠ext"; 
-
-    // Act
-    const label = wrapper.find("label");
-
-    // Assert
-    expect(label.text()).toContain(expectedQuestionText);
-
-  });
-  
   it("Should return input id as the id of the input field", async () => {
     // Arrange
     const wrapper = shallowMount(textboxQuestion, {

src/common-components/textbox-question/textbox-question.vue

@@ -1,7 +1,6 @@
 <template>
 	<div class="textbox-question" :class="(errors && errors.length) || hasError ? 'has-error' : ''">
 		<label :for="inputId" :aria-label="questionText" class="form-label" v-html="labelText"></label>
-		<!-- See https://stackoverflow.com/a/30976223 for information about "do-not-autofill" -->
 		<input
 			v-model.trim="value"
 			v-maska="mask"
@@ -14,7 +13,6 @@
 			:aria-disabled="isDisabled"
 			:disabled="isDisabled"
 			:aria-required="isRequired"
-			autocomplete="do-not-autofill"
 			:class="[hasIcon ? 'has-icon' : '', iconRight ? 'icon-right' : '']"
 			:validationRules="validationRules"
 			@change="handleChange"
@@ -46,7 +44,6 @@ export default {
 		inputId: String,
 		isDisabled: Boolean,
 		isRequired: Boolean,
-		disableAutoFill: Boolean,
 		hasIcon: Boolean, // If input has an icon
 		iconRight: Boolean, // Place icon on right side of text input, otherwise default is left if hasIcon prop is used
 		hasError: Boolean,

src/helpers/damage-helper.js

@@ -19,7 +19,7 @@ export function getDamageString() {
     if (damageLocations.length > 1) {
       returnString = "match"
     } else {
-      switch(damageLocations[0]?.location) {
+      switch(damageLocations[0]?.glassLocation) {
         case "Windshield":
           returnString = "windshield"
           break;
@@ -36,7 +36,7 @@ export function getDamageString() {
 
   export function getIsWindshieldOnly () {
     const damageLocations = store.getters.damage.glassToReplace;
-    const returnString = damageLocations.length === 1 && damageLocations[0]?.location === "Windshield" ? "windshield" : "glass";
+    const returnString = damageLocations.length === 1 && damageLocations[0]?.glassLocation === "Windshield" ? "windshield" : "glass";
     return returnString;
   }
 
@@ -56,7 +56,7 @@ export async function isGlassAvailableForCarId(carId){
     }
 
     for(const option of currentGlassOptions){
-      if(!newGlassOptions.data[optionsMap[option.location]].availableReplacementOptions.includes(option.name)){
+      if(!newGlassOptions.data[optionsMap[option.glassLocation]].availableReplacementOptions.includes(option.glassName)){
         return false;
       }
     }

src/helpers/damage-helper.spec.js

@@ -16,7 +16,7 @@ jest.mock("@/mixins/base-mixin.js", () => ({
     it("Should return match when multiple selected damage options are in the store", () => {
 
       // Arrange / Act
-      store.getters.damage.glassToReplace = [{location: "Windshield", name: "windshield"}, {location: "Passenger", name: "sideWindow"}];
+      store.getters.damage.glassToReplace = [{glassLocation: "Windshield", glassName: "windshield"}, {glassLocation: "Passenger", glassName: "sideWindow"}];
 
       const damage = getDamageString();
 
@@ -29,7 +29,7 @@ jest.mock("@/mixins/base-mixin.js", () => ({
     it("Should return windshield when Windshield is the only selected damage option in the store", () => {
 
       // Arrange / Act
-      store.getters.damage.glassToReplace = [{location: "Windshield", name: "windshield"}];
+      store.getters.damage.glassToReplace = [{glassLocation: "Windshield", glassName: "windshield"}];
 
       const damage = getDamageString();
 
@@ -42,7 +42,7 @@ jest.mock("@/mixins/base-mixin.js", () => ({
     it("Should return side window when Driver or Passenger is the only selected damage option in the store", () => {
 
       // Arrange / Act
-      store.getters.damage.glassToReplace = [{location: "Passenger", name: "sideWindow"}];
+      store.getters.damage.glassToReplace = [{glassLocation: "Passenger", glassName: "sideWindow"}];
 
       const damage = getDamageString();
 
@@ -55,7 +55,7 @@ jest.mock("@/mixins/base-mixin.js", () => ({
     it("Should return rear window when Rear is the only selected damage option in the store", () => {
 
       // Arrange / Act
-      store.getters.damage.glassToReplace = [{location: "Rear", name: "rear"}];
+      store.getters.damage.glassToReplace = [{glassLocation: "Rear", glassName: "rear"}];
 
       const damage = getDamageString();
 
@@ -67,7 +67,7 @@ jest.mock("@/mixins/base-mixin.js", () => ({
   describe("damage-helper.js", () => {
     it("Should return true if no mismatches between each array exist", async () => {
       // Arrange
-      store.getters.damage.glassToReplace = [{location: "Windshield", name: "windshield"}];
+      store.getters.damage.glassToReplace = [{glassLocation: "Windshield", glassName: "windshield"}];
 
       // Act
       const isGlassAvailable = await isGlassAvailableForCarId();
@@ -80,7 +80,7 @@ jest.mock("@/mixins/base-mixin.js", () => ({
   describe("damage-helper.js", () => {
     it("Should return false if any mismatches between each array exist", async () => {
       // Arrange
-      store.getters.damage.glassToReplace = [{location: "Windshield", name: "sideWindow"}];
+      store.getters.damage.glassToReplace = [{glassLocation: "Windshield", glassName: "sideWindow"}];
 
       const isGlassAvailable = await isGlassAvailableForCarId();
 

src/layouts/address-lookup/address-lookup.vue

@@ -42,7 +42,7 @@
 					<div class="service-zip-field" v-if="showServiceZipField" aria-live="polite">
 						<div class="row mb-4">
 							<div class="col">
-								<textboxQuestion cmsWidgetName="ServiceZipQuestionWidget" v-model="serviceZipCode" ref="serviceZip" inputId="7add1b26df344f2caf1678de5797803f" aria-haspopup="" mask="#####" disableAutoFill validationRules="service-zip-required|service-zip-format" />
+								<textboxQuestion cmsWidgetName="ServiceZipQuestionWidget" v-model="serviceZipCode" ref="serviceZip" inputId="7add1b26df344f2caf1678de5797803f" aria-haspopup="" mask="#####" validationRules="service-zip-required|service-zip-format" />
 							</div>
 						</div>
 					</div>

src/layouts/estimate/estimate.vue

@@ -52,6 +52,7 @@ import { required } from "@/helpers/validation-rules";
 import { errorMessages } from "@/constants/error-messages";
 import { Form, defineRule } from "vee-validate";
 import store from "@/store";
+import { storeMutations } from "@/constants/store-mutations";
 import { vinLookupMethodSelections } from "@/constants/vin-lookup-method-selections.js";
 // Define Validation Rules
 defineRule("option-required", required(errorMessages.OPTION_REQUIRED));
@@ -94,21 +95,22 @@ export default {
       );
     },
     forwardButtonAction() {
-      if (this.selectedValues[0]===vinLookupMethodSelections.MANUALVIN) {
+      if (this.selectedValues[0] === vinLookupMethodSelections.MANUALVIN) {
+        store.commit(storeMutations.UPDATE_VEHICLE_VIN, null);
         this.$router.navigate(
           this.navigationScenarios.SELECTED_MANUAL_VIN,
           this.$route
         );
         return; 
       }
-      if (this.selectedValues[0]===vinLookupMethodSelections.LICENSEPLATE) {
+      if (this.selectedValues[0] === vinLookupMethodSelections.LICENSEPLATE) {
         this.$router.navigate(
           this.navigationScenarios.SELECTED_LICENSE_PLATE,
           this.$route
         );
         return; 
       }
-      if (this.selectedValues[0]===vinLookupMethodSelections.HOMEADDRESS) {
+      if (this.selectedValues[0] === vinLookupMethodSelections.HOMEADDRESS) {
         this.$router.navigate(
           this.navigationScenarios.SELECTED_HOME_ADDRESS,
           this.$route

src/layouts/license-plate-lookup/license-plate-lookup.vue

@@ -267,8 +267,7 @@ export default {
           `Continue with ${vinLookup.data.vehicle.year} ${vinLookup.data.vehicle.make} ${vinLookup.data.vehicle.model}`
         );
         this.isVinValid = true;
-        this.isSelectedGlassAvailableForVehicle =
+        this.isSelectedGlassAvailableForVehicle = await isGlassAvailableForCarId(vinLookup.data.vehicle.carId);
-          await isGlassAvailableForCarId(vinLookup.data.vehicle.carId);
         this.$refs.funnelFooter.removeLoader();
         return;
       }

src/layouts/vehicle-damage/vehicle-damage.spec.js

@@ -145,8 +145,8 @@ describe("vehicle-damage.vue", () => {
 
       wrapper.vm.selectedRearReplaceOptions = ["Stationary"];
 
-      const expectedGlassToReplace = [{ location: "Windshield", name: "Single" }, { location: "Driver", name: "Back" },
+      const expectedGlassToReplace = [{ glassLocation: "Windshield", glassName: "Single" }, { glassLocation: "Driver", glassName: "Back" },
-      { location: "Passenger", name: "Quarter" }, { location: "Rear", name: "Stationary" }];
+      { glassLocation: "Passenger", glassName: "Quarter" }, { glassLocation: "Rear", glassName: "Stationary" }];
 
       //Act
       vehicleDamage.beforeRouteEnter.call(
@@ -237,7 +237,7 @@ describe("vehicle-damage.vue", () => {
         selectedWindshieldDamageType: ["Replace"]
       };
 
-      const expectedGlassToReplace = [{ location: "Windshield", name: "Single" },];
+      const expectedGlassToReplace = [{ glassLocation: "Windshield", glassName: "Single" },];
 
       //Act
       vehicleDamage.beforeRouteEnter.call(

src/layouts/vehicle-damage/vehicle-damage.vue

@@ -314,25 +314,25 @@ export default {
       const selectedGlassToReplace = [];
       if (this.isWindshieldDamageLocation && !this.isWindshieldRepair){
           this.selectedWindshieldOptions.selectedWindshieldReplaceOptions.forEach(wsItem => {
-            selectedGlassToReplace.push({ location: damageLocationsSelected.WINDSHIELD, name: wsItem});
+            selectedGlassToReplace.push({ glassLocation: damageLocationsSelected.WINDSHIELD, glassName: wsItem});
           })
       }
 
       if (this.isDriverSideReplace){
         this.sideDoorOptionsData.selectedDriverSideReplaceOptions.forEach(driverItem => {
-          selectedGlassToReplace.push({ location: damageLocationsSelected.DRIVER, name: driverItem});
+          selectedGlassToReplace.push({ glassLocation: damageLocationsSelected.DRIVER, glassName: driverItem});
         })
       }
 
       if (this.isPassengerSideReplace){
         this.sideDoorOptionsData.selectedPassengerSideReplaceOptions.forEach(passengerItem => {
-          selectedGlassToReplace.push({ location: damageLocationsSelected.PASSENGER, name: passengerItem});
+          selectedGlassToReplace.push({ glassLocation: damageLocationsSelected.PASSENGER, glassName: passengerItem});
         })
       }
 
       if (this.isRearWindowDamageLocation) {
           this.selectedRearReplaceOptions.forEach(rearItem => {
-            selectedGlassToReplace.push({ location: damageLocationsSelected.REAR, name: rearItem});
+            selectedGlassToReplace.push({ glassLocation: damageLocationsSelected.REAR, glassName: rearItem});
           })
       }
 

src/layouts/vin-lookup/vin-lookup.vue

@@ -23,11 +23,9 @@
               isRequired
               disableAutoFill
               validationRules="vin-required|vin-format"
-              :isDisabled="isVinFieldReadOnly"
+              :isDisabled="vinPopulatedOnPageLoad"
               maxLength="17"
               :mask="vinMask"
-              @focus="setVinTouched"
-              @maska="rawVinValue = $event.target.dataset.maskRawValue"
             />
           </div>
         </div>
@@ -70,10 +68,10 @@
         />
         <alert
           class="my-4"
-          :manualHeadline="PerfectMatchNewVinAlertReadOnlyHeader"
+          :manualHeadline="PerfectMatchInsuranceVerifiedAlertHeader"
-          :manualCopy="PerfectMatchNewVinAlertReadOnlyBody"
+          :manualCopy="PerfectMatchInsuranceVerifiedAlertBody"
           v-model="customAlertData"
-          v-if="isVinFieldReadOnly" 
+          v-if="vinPopulatedOnPageLoad && isInsuranceVerified" 
           alertClass="alert-success"
         />
         <alert
@@ -101,10 +99,10 @@
         />
         <alert
           class="my-4"
-          :manualHeadline="PerfectMatchNewVinAlertHeader"
+          :manualHeadline="PerfectMatchInsuranceNotVerifiedAlertHeader"
-          :manualCopy="PerfectMatchNewVinAlertBody"
+          :manualCopy="PerfectMatchInsuranceNotVerifiedAlertBody"
           v-model="customAlertData"
-          v-if="perfectMatchNewVinAlert && !noServiceZip && !vinNotFound && meta.valid && !isVinFieldReadOnly"
+          v-if="vinPopulatedOnPageLoad && !isInsuranceVerified"
           alertClass="alert-success"
         />
         <funnelFooter
@@ -140,10 +138,8 @@ import { errorMessages } from "@/constants/error-messages";
 import { getDamageString, getIsWindshieldOnly, isGlassAvailableForCarId } from "@/helpers/damage-helper";
 import { required, regex } from "@/helpers/validation-rules";
 import { Form, defineRule } from "vee-validate";
-import { navigateAfterSaveToHeritageFunnel } from "@/helpers/heritage-integration/navigation-helper";
 import { getFunnelCookie } from "@/helpers/heritage-integration/cookie-helper";
 import vinPagesMixin from "@/mixins/vin-pages-mixin";
-import { StatusCodes } from 'http-status-codes';
 
 // DEFINE VALIDATION RULES
 defineRule("zip-required", required(errorMessages.SERVICE_ZIP_REQUIRED));
@@ -187,15 +183,14 @@ export default {
       previouslyEnteredCarId: '',
       invalidZip: '',
       vinPopulatedOnPageLoad: this.getVinFromStore()?.length > 0,
-      initialVin: this.getVinFromStore(),
+      isInsuranceVerified: false,
-      vinTouched: false,
-      rawVinValue: "",
     };
   },
   mounted() {
     this.attachCustomEvents();
     if (this.vinPopulatedOnPageLoad) {
       this.setupVinMask();
+      this.isInsuranceVerified = store.getters.payment.insuranceCoverage.isVerified || getFunnelCookie().HasDelayedClaimRegistration;
     }    
   },
   watch: {
@@ -210,12 +205,6 @@ export default {
     },
   },
   computed: {
-    perfectMatchNewVinAlert() {
-      const vinToCheck = this.vinTouched ? this.rawVinValue : this.initialVin;
-      const isVinPerfectMatch = this.vinPopulatedOnPageLoad && vinToCheck === this.getVinFromStore();
-      this.updateIsCarIdDifferent(isVinPerfectMatch);
-      return isVinPerfectMatch;
-    },
     MatchedDifferentVehicleAlertHeader(){
       const text = this.getCmsContent("MatchedDifferentVehicle",
       "HeadlineText").replaceAll("{custom:damage}", getDamageString());
@@ -231,41 +220,29 @@ export default {
     },
     NoServiceZipHeader(){
       const text = this.getCmsContent("NoServiceZipWidget", "HeadlineText").replaceAll("{custom:serviceZip}", this.invalidZip);
-
       return text;
     },
     NoServiceZipBody(){
       return this.getCmsContent("NoServiceZipWidget", "BodyText");
     },
-    PerfectMatchNewVinAlertHeader() {
+    PerfectMatchInsuranceNotVerifiedAlertHeader() {
-      return this.getCmsContent("PerfectMatchNewVinAlert", "HeadlineText");
+      return this.getCmsContent("PerfectMatchInsuranceNotVerifiedAlert", "HeadlineText");
     },
-    PerfectMatchNewVinAlertBody() {
+    PerfectMatchInsuranceNotVerifiedAlertBody() {
-      return this.getCmsContent("PerfectMatchNewVinAlert", "BodyText").replaceAll("{custom:damage}",
+      return this.getCmsContent("PerfectMatchInsuranceNotVerifiedAlert", "BodyText").replaceAll("{custom:damage}",
       getDamageString())
     },
-    PerfectMatchNewVinAlertReadOnlyHeader () {
+    PerfectMatchInsuranceVerifiedAlertHeader () {
-      return this.getCmsContent("PerfectMatchNewVinAlertReadOnly", "HeadlineText");
+      return this.getCmsContent("PerfectMatchInsuranceVerifiedAlert", "HeadlineText");
     },
-    PerfectMatchNewVinAlertReadOnlyBody () {
+    PerfectMatchInsuranceVerifiedAlertBody () {
-      return this.getCmsContent("PerfectMatchNewVinAlertReadOnly", "BodyText").replaceAll("{custom:damage}",
+      return this.getCmsContent("PerfectMatchInsuranceVerifiedAlert", "BodyText").replaceAll("{custom:damage}",
       getIsWindshieldOnly())
     },
-    isVinFieldReadOnly(){
-      return this.$store.getters.payment.insuranceCoverage.isVerified || getFunnelCookie().HasDelayedClaimRegistration;
-    },
   },
   methods: {
-    setVinTouched() {
-      if (!this.vinTouched) {
-        this.vinMask = "XXXXXXXXXXXXXXXXX";
-        this.vin = this.initialVin;
-      }      
-
-      this.vinTouched = true;
-    },
     setupVinMask() {
-      const lastSixChars = this.initialVin.substring(11, this.initialVin.length);
+      const lastSixChars = this.vin.substring(11, this.vin.length);
       this.vinMask = `!X!X!X!X!X!X!X!X!X!X!X${lastSixChars}`;
     },
     arePagePrerequisitesValid() {
@@ -316,16 +293,15 @@ export default {
 
       const zipValidation = this.validateZip(this.zip);
       
-      if (this.vinTouched && this.vin != this.initialVin) {      
+      // If this is a new VIN Lookup, do both a Vehicle Lookup and a Zip Validation
-        // If the user has clicked on the VIN field, either they are doing a new VIN lookup or changing the VIN previously matched.
+      if (!this.vinPopulatedOnPageLoad) {          
-        // Therefore we need to do a Vehicle Lookup        
+        // Perform Zip Validation      
-        const vinToLookup = this.vinTouched ? this.vin : this.initialVin;
-        const vehicleLookup = this.lookupVehicle(vinToLookup);
-        
         zipValidationResponse = await zipValidation;
+
+        // Perform Vehicle Lookup
+        const vehicleLookup = this.lookupVehicle(this.vin);
         vehicleLookupResponse = await vehicleLookup.catch(() => {
           this.vinNotFound = true;
-          this.$refs.funnelFooter.removeLoader();
           return false;
         });
 
@@ -335,44 +311,46 @@ export default {
         }
       
         if (!vehicleLookupResponse || !zipValidationResponse.data.isServiceable) {
+          // If either lookup fails, remove the loader and stop processing the page.
           this.$refs.funnelFooter.removeLoader();
           return;
         }
+
+        this.isCarIdDifferent = vehicleLookupResponse.data.carId !== store.getters.vehicle.carId;
+
+        if (this.isCarIdDifferent && (vehicleLookupResponse.data.carId !== this.previouslyEnteredCarId)) {
+          this.previouslyEnteredCarId = vehicleLookupResponse.data.carId;
+          this.noServiceZip = false;
+          this.customAlertData.vehicleInfo = vehicleLookupResponse.data;
+          this.$refs.funnelFooter.updateButtonText(`Continue with ${vehicleLookupResponse.data.year} ${vehicleLookupResponse.data.make} ${vehicleLookupResponse.data.model}`);
+          this.isVinValid = true;
+          this.isSelectedGlassAvailableForVehicle = await isGlassAvailableForCarId(vehicleLookupResponse.data.carId);
+          this.$refs.funnelFooter.removeLoader();
+          this.isCarIdDifferent = true;
+          return;
+        }
+
+        this.updateStore(vehicleLookupResponse.data, zipValidationResponse.data);
+        this.navigateForward();
+
       } else {
+        // If a VIN has already been found. Validate the Service Zip (in case of changes)
         const zipValidationResponse = await zipValidation;
         
-        // Check if Service Zip entered is serviceable, if not display an alert
+        // Check if Service Zip entered is serviceable
-        if (!zipValidationResponse.data.isServiceable) {
+        if (zipValidationResponse.data.isServiceable) {
+          // If the Service Zip entered is serviceable then save the Zip Info and Email Address and navigate forward
+          store.commit(storeMutations.UPDATE_SERVICE_LOCATION_ZIP_CODE, this.zip);
+          store.commit(storeMutations.UPDATE_SERVICE_LOCATION_STATE, zipValidationResponse.data.state);          
+          store.commit(storeMutations.UPDATE_CUSTOMER_EMAIL_ADDRESS, this.email);
+          this.navigateForward();
+        } else {
+          // If the Service Zip is NOT serviceable then show an alert
           this.setupUiForNonServiceableZip(this.zip);
           this.$refs.funnelFooter.removeLoader();
-          return;
-        } else {
-          this.navigateForward();
-          return;
         }
       }
 
-      if (!vehicleLookupResponse) {
-        return;
-      }
-
-      this.isCarIdDifferent = vehicleLookupResponse.data.carId !== store.getters.vehicle.carId;
-
-      if (this.isCarIdDifferent && (vehicleLookupResponse.data.carId !== this.previouslyEnteredCarId)) {
-        this.previouslyEnteredCarId = vehicleLookupResponse.data.carId;
-        this.noServiceZip = false;
-        this.customAlertData.vehicleInfo = vehicleLookupResponse.data;
-        this.$refs.funnelFooter.updateButtonText(`Continue with ${vehicleLookupResponse.data.year} ${vehicleLookupResponse.data.make} ${vehicleLookupResponse.data.model}`);
-        this.isVinValid = true;
-        this.isSelectedGlassAvailableForVehicle = await isGlassAvailableForCarId(vehicleLookupResponse.data.carId);
-        this.$refs.funnelFooter.removeLoader();
-        this.isCarIdDifferent = true;
-        return;
-      }
-
-      this.updateStore(vehicleLookupResponse.data, zipValidationResponse.data);
-      this.navigateForward();
-
     },
     navigateForward(){
         if (this.isCarIdDifferent && !this.isSelectedGlassAvailableForVehicle) {