jason/DigitalConsumer.FixMyGlass
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #3247 from Safelite/feature/CASH-2943

Browse source 
CASH-2943: Remove bailout for all VinRequired vehicles
This commit is contained in:
Chris 2026-06-29 15:03:43 -04:00 committed by GitHub
commit 4a96e363c2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 31 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/mixins/vin-pages-mixin.js
View file

@ -37,7 +37,7 @@ export default {
pageNameToLog: pageName,
});
if (result.PartNotFound || store.getters.vehicle.vinRequired) {
if (result.PartNotFound) {
return bailoutMixin.methods.navigateToBailoutPage(
this,
bailoutCodes.PART_NOT_FOUND

34
src/mixins/vin-pages-mixin.spec.js
View file

@ -35,10 +35,9 @@ describe("vin-pages-mixin", () => {
expect(vehicleQuestionsMixin.methods.navigateForward).toHaveBeenCalled();
});
test("vinRequired vehicles navigate to bailout after VIN is saved", async () => {
test("navigate to bailout when parts are not found", async () => {
// Arrange
store.commit(storeMutations.UPDATE_VIN_REQUIRED, true);
const { wrapper } = setupMocks({});
const { wrapper } = setupMocks({ partNotFound: true });
bailoutMixin.methods.navigateToBailoutPage = jest.fn();
vehicleQuestionsMixin.methods.navigateForward = jest.fn();
@ -52,10 +51,29 @@ describe("vin-pages-mixin", () => {
);
expect(vehicleQuestionsMixin.methods.navigateForward).not.toHaveBeenCalled();
});
test("vinRequired vehicles navigate forward when parts are found", async () => {
// Arrange
store.commit(storeMutations.UPDATE_VIN_REQUIRED, true);
const partsOrQuestions = [{ partNumber: "123" }];
const { wrapper } = setupMocks({ partsOrQuestions });
bailoutMixin.methods.navigateToBailoutPage = jest.fn();
vehicleQuestionsMixin.methods.navigateForward = jest.fn();
// Act
await wrapper.vm.navigateForwardWithSingleCarMatch();
// Assert
expect(bailoutMixin.methods.navigateToBailoutPage).not.toHaveBeenCalled();
expect(vehicleQuestionsMixin.methods.navigateForward).toHaveBeenCalledWith(
partsOrQuestions,
wrapper.vm
);
});
});
});
function setupMocks({ partsOrQuestions = [] }) {
function setupMocks({ partsOrQuestions = [], partNotFound = false } = {}) {
const baseMixin = setupMocksForJsFiles({
actionList: [
{
@ -67,6 +85,14 @@ function setupMocks({ partsOrQuestions = [] }) {
],
});
if (partNotFound) {
baseMixin.baseMixin.methods.dispatchStoreAction.mockImplementation((actionName) => {
if (actionName === storeActions.GET_PARTS_OR_QUESTIONS) {
return Promise.resolve({ PartNotFound: true });
}
});
}
const mocks = getMountOptions({
router: {
navigate: jest.fn(),